RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Yogesh Narayan Gaur
.com; > > > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > Cyrille Pitchen ; > > > computersforpe...@gmail.com; dw...@infradead.org; > > > linux-arm-ker...@lists.infradead.org > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-un

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Yogesh Narayan Gaur
.com; > > > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > Cyrille Pitchen ; > > > computersforpe...@gmail.com; dw...@infradead.org; > > > linux-arm-ker...@lists.infradead.org > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-un

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Tue, 23 Oct 2018 10:48:27 +0200 > > Boris Brezillon wrote

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Tue, 23 Oct 2018 10:48:27 +0200 > > Boris Brezillon wrote

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Tue, 23 Oct 2018 08:18:35 + > > Yogesh Narayan Gau

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Tue, 23 Oct 2018 08:18:35 + > > Yogesh Narayan Gau

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Yogesh Narayan Gaur
nel.org; > nicolas.fe...@microchip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille Pitchen > ; computersforpe...@gmail.com; > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Yogesh Narayan Gaur
nel.org; > nicolas.fe...@microchip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille Pitchen > ; computersforpe...@gmail.com; > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Boris Brezillon
On Tue, 23 Oct 2018 10:48:27 +0200 Boris Brezillon wrote: > On Tue, 23 Oct 2018 08:18:35 + > Yogesh Narayan Gaur wrote: > > > > > I have added the prints in m25p80_read() and in flexspi controller > > prepare_lut and read_rxfifo() func. > > In these have added prints for data variable of

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Boris Brezillon
On Tue, 23 Oct 2018 10:48:27 +0200 Boris Brezillon wrote: > On Tue, 23 Oct 2018 08:18:35 + > Yogesh Narayan Gaur wrote: > > > > > I have added the prints in m25p80_read() and in flexspi controller > > prepare_lut and read_rxfifo() func. > > In these have added prints for data variable of

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Yogesh Narayan Gaur
nel.org; > nicolas.fe...@microchip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille Pitchen > ; computersforpe...@gmail.com; > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add s

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Yogesh Narayan Gaur
nel.org; > nicolas.fe...@microchip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille Pitchen > ; computersforpe...@gmail.com; > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add s

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Boris Brezillon
On Tue, 23 Oct 2018 08:18:35 + Yogesh Narayan Gaur wrote: > > I have added the prints in m25p80_read() and in flexspi controller > prepare_lut and read_rxfifo() func. > In these have added prints for data variable of struct op and data which > being read by the controller from the flash.

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Boris Brezillon
On Tue, 23 Oct 2018 08:18:35 + Yogesh Narayan Gaur wrote: > > I have added the prints in m25p80_read() and in flexspi controller > prepare_lut and read_rxfifo() func. > In these have added prints for data variable of struct op and data which > being read by the controller from the flash.

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Yogesh Narayan Gaur
nel.org; > nicolas.fe...@microchip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille Pitchen > ; computersforpe...@gmail.com; > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add s

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-23 Thread Yogesh Narayan Gaur
nel.org; > nicolas.fe...@microchip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille Pitchen > ; computersforpe...@gmail.com; > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add s

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 11:46:55 + > > Yogesh Narayan Gaur wro

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 11:46:55 + > > Yogesh Narayan Gaur wro

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
gt; cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > Cyrille Pitchen ; > > > computersforpe...@gmail.com; dw...@infradead.org; > > > linux-arm-ker...@lists.infradead.org > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
gt; cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > Cyrille Pitchen ; > > > computersforpe...@gmail.com; dw...@infradead.org; > > > linux-arm-ker...@lists.infradead.org > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 11:03:09 + > > Yogesh Narayan Gaur wro

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 11:03:09 + > > Yogesh Narayan Gaur wro

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
gt; cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > Cyrille Pitchen ; > > > computersforpe...@gmail.com; dw...@infradead.org; > > > linux-arm-ker...@lists.infradead.org > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
gt; cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > Cyrille Pitchen ; > > > computersforpe...@gmail.com; dw...@infradead.org; > > > linux-arm-ker...@lists.infradead.org > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 12:46:27 +0200

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
t; ; computersforpe...@gmail.com; > > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 12:46:27 +0200

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
nel.org; > nicolas.fe...@microchip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille Pitchen > ; computersforpe...@gmail.com; > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
nel.org; > nicolas.fe...@microchip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; Cyrille Pitchen > ; computersforpe...@gmail.com; > dw...@infradead.org; linux-arm-ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 12:46:27 +0200 Boris Brezillon wrote: > On Mon, 22 Oct 2018 10:39:48 + > Yogesh Narayan Gaur wrote: > > > > > [1.632190] Start [addr_width:, read_dumy:08, > > read_opcode:] > > [1.639148]

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 12:46:27 +0200 Boris Brezillon wrote: > On Mon, 22 Oct 2018 10:39:48 + > Yogesh Narayan Gaur wrote: > > > > > [1.632190] Start [addr_width:, read_dumy:08, > > read_opcode:] > > [1.639148]

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 10:39:48 + Yogesh Narayan Gaur wrote: > > [1.632190] Start [addr_width:, read_dumy:08, > read_opcode:] > [1.639148] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 10:39:48 + Yogesh Narayan Gaur wrote: > > [1.632190] Start [addr_width:, read_dumy:08, > read_opcode:] > [1.639148] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc >

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > cristian.bir...@microchip.com; Cyrille Pitchen ; > computersforpe...@gmail.com; dw...@infradead.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > cristian.bir...@microchip.com; Cyrille Pitchen ; > computersforpe...@gmail.com; dw...@infradead.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 10:03:55 + Yogesh Narayan Gaur wrote: > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2863,26 +2863,36 @@ static u8 spi_nor_smpt_read_dummy(const struct > spi_nor *nor, const u32 settings) > * @nor: pointer to a 'struct spi_nor'

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 10:03:55 + Yogesh Narayan Gaur wrote: > --- a/drivers/mtd/spi-nor/spi-nor.c > +++ b/drivers/mtd/spi-nor/spi-nor.c > @@ -2863,26 +2863,36 @@ static u8 spi_nor_smpt_read_dummy(const struct > spi_nor *nor, const u32 settings) > * @nor: pointer to a 'struct spi_nor'

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 10:17:58 + Yogesh Narayan Gaur wrote: > It works, Not really. > [1.628162] m25p80 spi0.0: found s25fl512s, expected m25p80 > > [1.633854] Start [addr_width:, read_dumy:08, >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 10:17:58 + Yogesh Narayan Gaur wrote: > It works, Not really. > [1.628162] m25p80 spi0.0: found s25fl512s, expected m25p80 > > [1.633854] Start [addr_width:, read_dumy:08, >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 10:03:55 + Yogesh Narayan Gaur wrote: > [1.624684] m25p80 spi0.0: found s25fl512s, expected m25p80 > [1.630377] Start [addr_width:, read_dumy:08, read_opcode:] > [1.637335] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc > [1.642641]

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 10:03:55 + Yogesh Narayan Gaur wrote: > [1.624684] m25p80 spi0.0: found s25fl512s, expected m25p80 > [1.630377] Start [addr_width:, read_dumy:08, read_opcode:] > [1.637335] spi_nor_get_map_in_use:2882 smpt[0]=08ff65fc > [1.642641]

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
rochip.com; linux-...@lists.infradead.org; > > > cristian.bir...@microchip.com; Cyrille Pitchen > > > ; computersforpe...@gmail.com; > > > dw...@infradead.org; linux-arm- ker...@lists.infradead.org > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-unifo

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
rochip.com; linux-...@lists.infradead.org; > > > cristian.bir...@microchip.com; Cyrille Pitchen > > > ; computersforpe...@gmail.com; > > > dw...@infradead.org; linux-arm- ker...@lists.infradead.org > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-unifo

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
computersforpe...@gmail.com; dw...@infradead.org; linux-arm- > > ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 06:04:13 + > > Yogesh Narayan Gaur wro

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
computersforpe...@gmail.com; dw...@infradead.org; linux-arm- > > ker...@lists.infradead.org > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 06:04:13 + > > Yogesh Narayan Gaur wro

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
crochip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > cristian.bir...@microchip.com; Cyrille Pitchen ; > computersforpe...@gmail.com; dw...@infradead.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add s

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
crochip.com; marek.va...@gmail.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > cristian.bir...@microchip.com; Cyrille Pitchen ; > computersforpe...@gmail.com; dw...@infradead.org; linux-arm- > ker...@lists.infradead.org > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add s

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 06:04:13 + Yogesh Narayan Gaur wrote: > - /* Find the matching configuration map */ > - while (SMPT_MAP_ID(smpt[i]) != map_id) { > - if (smpt[i] & SMPT_DESC_END) > - goto out; > + if (map_id_is_valid) > +

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 06:04:13 + Yogesh Narayan Gaur wrote: > - /* Find the matching configuration map */ > - while (SMPT_MAP_ID(smpt[i]) != map_id) { > - if (smpt[i] & SMPT_DESC_END) > - goto out; > + if (map_id_is_valid) > +

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
ker...@lists.infradead.org; cristian.bir...@microchip.com; Mark Brown > > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 06:04:13 + > > Yogesh Narayan Gaur wrote: &

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
ker...@lists.infradead.org; cristian.bir...@microchip.com; Mark Brown > > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Mon, 22 Oct 2018 06:04:13 + > > Yogesh Narayan Gaur wrote: &

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
l.com; rich...@nod.at; > linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com; Mark Brown > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add s

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
l.com; rich...@nod.at; > linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com; Mark Brown > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add s

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Tudor Ambarus
Hi, Please amend this as well. Thanks! --- drivers/mtd/spi-nor/spi-nor.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 3a9b69e9ba6d..3019708696cd 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Tudor Ambarus
Hi, Please amend this as well. Thanks! --- drivers/mtd/spi-nor/spi-nor.c | 12 +--- 1 file changed, 9 insertions(+), 3 deletions(-) diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c index 3a9b69e9ba6d..3019708696cd 100644 --- a/drivers/mtd/spi-nor/spi-nor.c +++

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 06:04:13 + Yogesh Narayan Gaur wrote: > -static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32 > *smpt) > +static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32 > *smpt, u32 smpt_len) > { > const u32 *ret = NULL; > -

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
On Mon, 22 Oct 2018 06:04:13 + Yogesh Narayan Gaur wrote: > -static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32 > *smpt) > +static const u32 *spi_nor_get_map_in_use(struct spi_nor *nor, const u32 > *smpt, u32 smpt_len) > { > const u32 *ret = NULL; > -

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
gt; > ker...@lists.infradead.org; cristian.bir...@microchip.com > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Wed, 17 Oct 2018 07:46:30 + > > Yogesh Narayan Gaur wrote: > > &

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Boris Brezillon
gt; > ker...@lists.infradead.org; cristian.bir...@microchip.com > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Wed, 17 Oct 2018 07:46:30 + > > Yogesh Narayan Gaur wrote: > > &

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
fe...@microchip.com; > > > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > linux-arm- ker...@lists.infradead.org; cristian.bir...@microchip.com > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform > > > SFDP SPI NOR fla

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-22 Thread Yogesh Narayan Gaur
fe...@microchip.com; > > > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > > > linux-arm- ker...@lists.infradead.org; cristian.bir...@microchip.com > > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform > > > SFDP SPI NOR fla

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
gt; > ker...@lists.infradead.org; cristian.bir...@microchip.com > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Wed, 17 Oct 2018 09:10:45 +0200 > > Boris Brezillon wrote: > > > &g

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
gt; > ker...@lists.infradead.org; cristian.bir...@microchip.com > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > On Wed, 17 Oct 2018 09:10:45 +0200 > > Boris Brezillon wrote: > > > &g

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Cyrille Pitchen
>> ker...@lists.infradead.org; cristian.bir...@microchip.com >> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI >> NOR flash memories >> >> Hi Tudor, >> >> Le 16/10/2018 à 17:14, Tudor Ambarus a écrit : >>> Hi, Yogesh, >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Cyrille Pitchen
>> ker...@lists.infradead.org; cristian.bir...@microchip.com >> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI >> NOR flash memories >> >> Hi Tudor, >> >> Le 16/10/2018 à 17:14, Tudor Ambarus a écrit : >>> Hi, Yogesh, >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
gt; > ker...@lists.infradead.org; cristian.bir...@microchip.com > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > Hi, Yogesh, > > > > On 10/17/2018 10:46 AM, Yogesh Narayan Gaur wrote:

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
gt; > ker...@lists.infradead.org; cristian.bir...@microchip.com > > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP > > SPI > > NOR flash memories > > > > Hi, Yogesh, > > > > On 10/17/2018 10:46 AM, Yogesh Narayan Gaur wrote:

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Yogesh Narayan Gaur
hip.com; > >> cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > >> linux-arm- ker...@lists.infradead.org; cristian.bir...@microchip.com > >> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform > >> SFDP SPI NOR flash memories > >

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Yogesh Narayan Gaur
hip.com; > >> cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; > >> linux-arm- ker...@lists.infradead.org; cristian.bir...@microchip.com > >> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform > >> SFDP SPI NOR flash memories > >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Tudor Ambarus
@lists.infradead.org; cristian.bir...@microchip.com >> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI >> NOR flash memories >> >> On Wed, 17 Oct 2018 09:10:45 +0200 >> Boris Brezillon wrote: >> >>> On Wed, 17 Oct 2018 09:07:2

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Tudor Ambarus
@lists.infradead.org; cristian.bir...@microchip.com >> Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI >> NOR flash memories >> >> On Wed, 17 Oct 2018 09:10:45 +0200 >> Boris Brezillon wrote: >> >>> On Wed, 17 Oct 2018 09:07:2

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Yogesh Narayan Gaur
pe...@gmail.com; rich...@nod.at; > linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Yogesh Narayan Gaur
pe...@gmail.com; rich...@nod.at; > linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
On Wed, 17 Oct 2018 09:10:45 +0200 Boris Brezillon wrote: > On Wed, 17 Oct 2018 09:07:24 +0200 > Boris Brezillon wrote: > > > On Wed, 17 Oct 2018 02:07:43 + > > Yogesh Narayan Gaur wrote: > > > > > > > > > Actually there is no entry of s25fs512s in current spi-nor.c file. > > >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
On Wed, 17 Oct 2018 09:10:45 +0200 Boris Brezillon wrote: > On Wed, 17 Oct 2018 09:07:24 +0200 > Boris Brezillon wrote: > > > On Wed, 17 Oct 2018 02:07:43 + > > Yogesh Narayan Gaur wrote: > > > > > > > > > Actually there is no entry of s25fs512s in current spi-nor.c file. > > >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
On Wed, 17 Oct 2018 09:10:45 +0200 Boris Brezillon wrote: > On Wed, 17 Oct 2018 09:07:24 +0200 > Boris Brezillon wrote: > > > On Wed, 17 Oct 2018 02:07:43 + > > Yogesh Narayan Gaur wrote: > > > > > > > > > Actually there is no entry of s25fs512s in current spi-nor.c file. > > >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
On Wed, 17 Oct 2018 09:10:45 +0200 Boris Brezillon wrote: > On Wed, 17 Oct 2018 09:07:24 +0200 > Boris Brezillon wrote: > > > On Wed, 17 Oct 2018 02:07:43 + > > Yogesh Narayan Gaur wrote: > > > > > > > > > Actually there is no entry of s25fs512s in current spi-nor.c file. > > >

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
On Wed, 17 Oct 2018 09:07:24 +0200 Boris Brezillon wrote: > On Wed, 17 Oct 2018 02:07:43 + > Yogesh Narayan Gaur wrote: > > > > > > Actually there is no entry of s25fs512s in current spi-nor.c file. > > For my connected flash part, jedec ID read points to s25fl512s. I > > have asked

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
On Wed, 17 Oct 2018 09:07:24 +0200 Boris Brezillon wrote: > On Wed, 17 Oct 2018 02:07:43 + > Yogesh Narayan Gaur wrote: > > > > > > Actually there is no entry of s25fs512s in current spi-nor.c file. > > For my connected flash part, jedec ID read points to s25fl512s. I > > have asked

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
On Wed, 17 Oct 2018 02:07:43 + Yogesh Narayan Gaur wrote: > > > Actually there is no entry of s25fs512s in current spi-nor.c file. > For my connected flash part, jedec ID read points to s25fl512s. I > have asked my board team to confirm the name of exact connected flash > part. When I

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-17 Thread Boris Brezillon
On Wed, 17 Oct 2018 02:07:43 + Yogesh Narayan Gaur wrote: > > > Actually there is no entry of s25fs512s in current spi-nor.c file. > For my connected flash part, jedec ID read points to s25fl512s. I > have asked my board team to confirm the name of exact connected flash > part. When I

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Yogesh Narayan Gaur
at > Cc: linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com > Subject: RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI &

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Yogesh Narayan Gaur
at > Cc: linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com > Subject: RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI &

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Yogesh Narayan Gaur
brezil...@bootlin.com; rich...@nod.at > Cc: linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add supp

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Yogesh Narayan Gaur
brezil...@bootlin.com; rich...@nod.at > Cc: linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add supp

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Yogesh Narayan Gaur
at; > linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI > N

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Yogesh Narayan Gaur
at; > linux-kernel@vger.kernel.org; nicolas.fe...@microchip.com; > cyrille.pitc...@microchip.com; linux-...@lists.infradead.org; linux-arm- > ker...@lists.infradead.org; cristian.bir...@microchip.com > Subject: Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI > N

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Cyrille Pitchen
Hi Tudor, Le 16/10/2018 à 17:14, Tudor Ambarus a écrit : > Hi, Yogesh, > > On 10/16/2018 12:51 PM, Yogesh Narayan Gaur wrote: >> Hi Tudor, >> >> This patch is breaking the 1-4-4 Read protocol for the spansion flash >> "s25fl512s". >> >> Without this patch read request command for Quad mode,

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Cyrille Pitchen
Hi Tudor, Le 16/10/2018 à 17:14, Tudor Ambarus a écrit : > Hi, Yogesh, > > On 10/16/2018 12:51 PM, Yogesh Narayan Gaur wrote: >> Hi Tudor, >> >> This patch is breaking the 1-4-4 Read protocol for the spansion flash >> "s25fl512s". >> >> Without this patch read request command for Quad mode,

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Tudor Ambarus
Hi, Yogesh, On 10/16/2018 12:51 PM, Yogesh Narayan Gaur wrote: > Hi Tudor, > > This patch is breaking the 1-4-4 Read protocol for the spansion flash > "s25fl512s". > > Without this patch read request command for Quad mode, 4-byte enable, is > coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. > But

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Tudor Ambarus
Hi, Yogesh, On 10/16/2018 12:51 PM, Yogesh Narayan Gaur wrote: > Hi Tudor, > > This patch is breaking the 1-4-4 Read protocol for the spansion flash > "s25fl512s". > > Without this patch read request command for Quad mode, 4-byte enable, is > coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. > But

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Boris Brezillon
On Tue, 16 Oct 2018 14:04:11 +0200 Boris Brezillon wrote: > On Tue, 16 Oct 2018 09:51:47 + > Yogesh Narayan Gaur wrote: > > > Hi Tudor, > > > > This patch is breaking the 1-4-4 Read protocol for the spansion flash > > "s25fl512s". > > > > Without this patch read request command for Quad

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Boris Brezillon
On Tue, 16 Oct 2018 14:04:11 +0200 Boris Brezillon wrote: > On Tue, 16 Oct 2018 09:51:47 + > Yogesh Narayan Gaur wrote: > > > Hi Tudor, > > > > This patch is breaking the 1-4-4 Read protocol for the spansion flash > > "s25fl512s". > > > > Without this patch read request command for Quad

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Boris Brezillon
On Tue, 16 Oct 2018 09:51:47 + Yogesh Narayan Gaur wrote: > Hi Tudor, > > This patch is breaking the 1-4-4 Read protocol for the spansion flash > "s25fl512s". > > Without this patch read request command for Quad mode, 4-byte enable, is > coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. > But

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Boris Brezillon
On Tue, 16 Oct 2018 09:51:47 + Yogesh Narayan Gaur wrote: > Hi Tudor, > > This patch is breaking the 1-4-4 Read protocol for the spansion flash > "s25fl512s". > > Without this patch read request command for Quad mode, 4-byte enable, is > coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. > But

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Yogesh Narayan Gaur
Hi Tudor, This patch is breaking the 1-4-4 Read protocol for the spansion flash "s25fl512s". Without this patch read request command for Quad mode, 4-byte enable, is coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. But after applying this patch, read request command for Quad mode is coming as

RE: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-10-16 Thread Yogesh Narayan Gaur
Hi Tudor, This patch is breaking the 1-4-4 Read protocol for the spansion flash "s25fl512s". Without this patch read request command for Quad mode, 4-byte enable, is coming as 0xEC i.e. SPINOR_OP_READ_1_4_4_4B. But after applying this patch, read request command for Quad mode is coming as

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-09-17 Thread Tudor Ambarus
Hi, Boris, On 09/11/2018 06:40 PM, Tudor Ambarus wrote: > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c [cut] > /* I missed to use the opening comment mark for kernel-doc comments: "/**". This observation applies to all newly introduced function descriptions, in

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-09-17 Thread Tudor Ambarus
Hi, Boris, On 09/11/2018 06:40 PM, Tudor Ambarus wrote: > diff --git a/drivers/mtd/spi-nor/spi-nor.c b/drivers/mtd/spi-nor/spi-nor.c [cut] > /* I missed to use the opening comment mark for kernel-doc comments: "/**". This observation applies to all newly introduced function descriptions, in

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-09-11 Thread Marek Vasut
On 09/11/2018 05:40 PM, Tudor Ambarus wrote: > Based on Cyrille Pitchen's patch https://lkml.org/lkml/2017/3/22/935. > > This patch is a transitional patch in introducing the support of > SFDP SPI memories with non-uniform erase sizes like Spansion s25fs512s. > Non-uniform erase maps will be

Re: [PATCH v3 1/2] mtd: spi-nor: add support to non-uniform SFDP SPI NOR flash memories

2018-09-11 Thread Marek Vasut
On 09/11/2018 05:40 PM, Tudor Ambarus wrote: > Based on Cyrille Pitchen's patch https://lkml.org/lkml/2017/3/22/935. > > This patch is a transitional patch in introducing the support of > SFDP SPI memories with non-uniform erase sizes like Spansion s25fs512s. > Non-uniform erase maps will be

  1   2   >