RE: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void

2016-04-11 Thread Felipe Balbi
Hi, "Du, Changbin" writes: >> >root = debugfs_create_dir(dev_name(dwc->dev), NULL); >> > - if (!root) { >> > - ret = -ENOMEM; >> > - goto err0; >> > - } >> > + if (IS_ERR_OR_NULL(root)) >> > + return; >> >> We can definitely keep on

RE: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void

2016-04-11 Thread Felipe Balbi
Hi, "Du, Changbin" writes: >> >root = debugfs_create_dir(dev_name(dwc->dev), NULL); >> > - if (!root) { >> > - ret = -ENOMEM; >> > - goto err0; >> > - } >> > + if (IS_ERR_OR_NULL(root)) >> > + return; >> >> We can definitely keep on going, but I'd still like

RE: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void

2016-04-11 Thread Du, Changbin
> > root = debugfs_create_dir(dev_name(dwc->dev), NULL); > > - if (!root) { > > - ret = -ENOMEM; > > - goto err0; > > - } > > + if (IS_ERR_OR_NULL(root)) > > + return; > > We can definitely keep on going, but I'd still like to know that we > enabled

RE: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void

2016-04-11 Thread Du, Changbin
> > root = debugfs_create_dir(dev_name(dwc->dev), NULL); > > - if (!root) { > > - ret = -ENOMEM; > > - goto err0; > > - } > > + if (IS_ERR_OR_NULL(root)) > > + return; > > We can definitely keep on going, but I'd still like to know that we > enabled

Re: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void

2016-04-11 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > diff --git a/drivers/usb/dwc3/debug.h b/drivers/usb/dwc3/debug.h > index 07fbc2d..71e3180 100644 > --- a/drivers/usb/dwc3/debug.h > +++ b/drivers/usb/dwc3/debug.h > @@ -217,11 +217,11 @@ static inline const char > *dwc3_gadget_event_type_string(u8 event) >

Re: [PATCH v3 1/2] usb: dwc3: make dwc3_debugfs_init return value be void

2016-04-11 Thread Felipe Balbi
Hi, changbin...@intel.com writes: > diff --git a/drivers/usb/dwc3/debug.h b/drivers/usb/dwc3/debug.h > index 07fbc2d..71e3180 100644 > --- a/drivers/usb/dwc3/debug.h > +++ b/drivers/usb/dwc3/debug.h > @@ -217,11 +217,11 @@ static inline const char > *dwc3_gadget_event_type_string(u8 event) >