RE: [PATCH v3 2/2] clk:mmp: clk-mix.c fix divide-by-zero

2019-04-24 Thread Stephen Boyd
Quoting Nixiaoming (2019-04-24 08:34:54) > On Wed, Apr 24, 2019 at 7:00 AM Stephen Boyd wrote: > >Quoting nixiaoming (2019-03-30 06:55:42) > >> The _get_div() function has a branch with a return value of 0 > >> Add a check on the return value of _get_div() to avoid divide-by-zero > >> > > > >Are

RE: [PATCH v3 2/2] clk:mmp: clk-mix.c fix divide-by-zero

2019-04-24 Thread Nixiaoming
On Wed, Apr 24, 2019 at 7:00 AM Stephen Boyd wrote: >Quoting nixiaoming (2019-03-30 06:55:42) >> The _get_div() function has a branch with a return value of 0 >> Add a check on the return value of _get_div() to avoid divide-by-zero >> > >Are you seeing this in practice? Or just trying to avoid a

Re: [PATCH v3 2/2] clk:mmp: clk-mix.c fix divide-by-zero

2019-04-23 Thread Stephen Boyd
Quoting nixiaoming (2019-03-30 06:55:42) > The _get_div() function has a branch with a return value of 0 > Add a check on the return value of _get_div() to avoid divide-by-zero > Are you seeing this in practice? Or just trying to avoid a div-by-zero case that you've found from inspection? >