Re: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

2015-03-05 Thread Naoya Horiguchi
On Thu, Mar 05, 2015 at 01:24:47AM +, Horiguchi Naoya(堀口 直也) wrote: ... > > Is the "UC" entry at the end of the severities[] table just a catch-all for > > things that made it > > past all the other entries? Does it ever really get used? > > I read through the severity check table and it

Re: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

2015-03-05 Thread Borislav Petkov
On Wed, Mar 04, 2015 at 11:12:33PM +, Luck, Tony wrote: > > - fixed AR and UC order in enum severity_level because UC is severer than AR > > by definition. Current code is not affected by this wrong order by chance. > > AR and AO are both UC errors - that happen also to be recoverable. Are

Re: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

2015-03-05 Thread Borislav Petkov
On Wed, Mar 04, 2015 at 11:12:33PM +, Luck, Tony wrote: - fixed AR and UC order in enum severity_level because UC is severer than AR by definition. Current code is not affected by this wrong order by chance. AR and AO are both UC errors - that happen also to be recoverable. Are you

Re: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

2015-03-05 Thread Naoya Horiguchi
On Thu, Mar 05, 2015 at 01:24:47AM +, Horiguchi Naoya(堀口 直也) wrote: ... Is the UC entry at the end of the severities[] table just a catch-all for things that made it past all the other entries? Does it ever really get used? I read through the severity check table and it seems that

Re: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

2015-03-04 Thread Naoya Horiguchi
On Wed, Mar 04, 2015 at 11:12:33PM +, Luck, Tony wrote: > > - fixed AR and UC order in enum severity_level because UC is severer than AR > > by definition. Current code is not affected by this wrong order by chance. > > AR and AO are both UC errors - that happen also to be recoverable.

RE: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

2015-03-04 Thread Luck, Tony
> - fixed AR and UC order in enum severity_level because UC is severer than AR > by definition. Current code is not affected by this wrong order by chance. AR and AO are both UC errors - that happen also to be recoverable. Are you really sure about this re-order not affecting existing code?

RE: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

2015-03-04 Thread Luck, Tony
- fixed AR and UC order in enum severity_level because UC is severer than AR by definition. Current code is not affected by this wrong order by chance. AR and AO are both UC errors - that happen also to be recoverable. Are you really sure about this re-order not affecting existing code? You

Re: [PATCH v4] x86: mce: kexec: switch MCE handler for kexec/kdump

2015-03-04 Thread Naoya Horiguchi
On Wed, Mar 04, 2015 at 11:12:33PM +, Luck, Tony wrote: - fixed AR and UC order in enum severity_level because UC is severer than AR by definition. Current code is not affected by this wrong order by chance. AR and AO are both UC errors - that happen also to be recoverable. Maybe just