RE: [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine
Hi Tomasz, > -Original Message- > > Hi Pankaj, > > On 10.05.2014 08:56, Pankaj Dubey wrote: > > As exynos_cpuidle_init and exynos_cpufreq_init function have just one > > lines of code for registering platform devices. We can move these > > lines to exynos_dt_machine_init and delete exynos_cpuidle_init and > > exynos_cpufreq_init function. This will help in reducing lines of code > > in exynos.c, making it more cleaner. > > > > Suggested-by: Tomasz Figa > > Signed-off-by: Pankaj Dubey > > --- > > arch/arm/mach-exynos/exynos.c | 19 --- > > 1 file changed, 4 insertions(+), 15 deletions(-) > > > > Reviewed-by: Tomasz Figa > Thanks for review. > Btw. This and other simple clean-up patches from this series could be applied > separately, without re-spinning them every time with this series. > OK, I will separate cleanup patches. > Best regards, > Tomasz Thanks, Pankaj Dubey -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
RE: [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine
Hi Tomasz, -Original Message- Hi Pankaj, On 10.05.2014 08:56, Pankaj Dubey wrote: As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines of code for registering platform devices. We can move these lines to exynos_dt_machine_init and delete exynos_cpuidle_init and exynos_cpufreq_init function. This will help in reducing lines of code in exynos.c, making it more cleaner. Suggested-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) Reviewed-by: Tomasz Figa t.f...@samsung.com Thanks for review. Btw. This and other simple clean-up patches from this series could be applied separately, without re-spinning them every time with this series. OK, I will separate cleanup patches. Best regards, Tomasz Thanks, Pankaj Dubey -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine
Hi Pankaj, On 10.05.2014 08:56, Pankaj Dubey wrote: > As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines > of code for registering platform devices. We can move these lines to > exynos_dt_machine_init and delete exynos_cpuidle_init and exynos_cpufreq_init > function. This will help in reducing lines of code in exynos.c, making it > more cleaner. > > Suggested-by: Tomasz Figa > Signed-off-by: Pankaj Dubey > --- > arch/arm/mach-exynos/exynos.c | 19 --- > 1 file changed, 4 insertions(+), 15 deletions(-) > Reviewed-by: Tomasz Figa Btw. This and other simple clean-up patches from this series could be applied separately, without re-spinning them every time with this series. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: [PATCH v4 02/11] ARM: EXYNOS: Move cpufreq and cpuidle device registration to init_machine
Hi Pankaj, On 10.05.2014 08:56, Pankaj Dubey wrote: As exynos_cpuidle_init and exynos_cpufreq_init function have just one lines of code for registering platform devices. We can move these lines to exynos_dt_machine_init and delete exynos_cpuidle_init and exynos_cpufreq_init function. This will help in reducing lines of code in exynos.c, making it more cleaner. Suggested-by: Tomasz Figa t.f...@samsung.com Signed-off-by: Pankaj Dubey pankaj.du...@samsung.com --- arch/arm/mach-exynos/exynos.c | 19 --- 1 file changed, 4 insertions(+), 15 deletions(-) Reviewed-by: Tomasz Figa t.f...@samsung.com Btw. This and other simple clean-up patches from this series could be applied separately, without re-spinning them every time with this series. Best regards, Tomasz -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
