Re: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2.

2012-10-10 Thread Konrad Rzeszutek Wilk
On Wed, Oct 10, 2012 at 01:31:54AM +, Zheng, Lv wrote: > > > Signed-off-by: Lv Zheng > > > Reviewed-by: Len Brown > > > Reviewed-by: Rui Zhang > > > Reviewed-by: Ying Huang > > > Reviewed-by: Konrad Rzeszutek Wilk > > Please don't include that unless I (or other folks looking at your

Re: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2.

2012-10-10 Thread Konrad Rzeszutek Wilk
On Wed, Oct 10, 2012 at 01:31:54AM +, Zheng, Lv wrote: Signed-off-by: Lv Zheng lv.zh...@intel.com Reviewed-by: Len Brown len.br...@intel.com Reviewed-by: Rui Zhang rui.zh...@intel.com Reviewed-by: Ying Huang ying.hu...@intel.com Reviewed-by: Konrad Rzeszutek Wilk

RE: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2.

2012-10-09 Thread Zheng, Lv
> > +int __init acpi_early_console_keep(struct acpi_debug_port *info) > > Why not make it 'bool' like the other (acpi_early_console_enabled)? NAK. "keep" is "int" in "setup_early_printk". Best regards/Lv Zheng -- To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the

RE: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2.

2012-10-09 Thread Zheng, Lv
> > Signed-off-by: Lv Zheng > > Reviewed-by: Len Brown > > Reviewed-by: Rui Zhang > > Reviewed-by: Ying Huang > > Reviewed-by: Konrad Rzeszutek Wilk > Please don't include that unless I (or other folks looking at your code) say > explicitly 'Acked' or 'Reviewed-by' ACK. I'll remove these

Re: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2.

2012-10-09 Thread Konrad Rzeszutek Wilk
On Tue, Oct 09, 2012 at 10:36:56AM +0800, Lv Zheng wrote: > Microsoft Debug Port Table (DBGP or DBG2) is used by the Windows SoC > platforms to describe their debugging facilities. > DBGP: http://msdn.microsoft.com/en-us/windows/hardware/hh134821 > DBG2:

Re: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2.

2012-10-09 Thread Konrad Rzeszutek Wilk
On Tue, Oct 09, 2012 at 10:36:56AM +0800, Lv Zheng wrote: Microsoft Debug Port Table (DBGP or DBG2) is used by the Windows SoC platforms to describe their debugging facilities. DBGP: http://msdn.microsoft.com/en-us/windows/hardware/hh134821 DBG2:

RE: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2.

2012-10-09 Thread Zheng, Lv
Signed-off-by: Lv Zheng lv.zh...@intel.com Reviewed-by: Len Brown len.br...@intel.com Reviewed-by: Rui Zhang rui.zh...@intel.com Reviewed-by: Ying Huang ying.hu...@intel.com Reviewed-by: Konrad Rzeszutek Wilk kon...@kernel.org Please don't include that unless I (or other folks looking

RE: [PATCH v5 1/2] ACPI: Add early console framework for DBGP/DBG2.

2012-10-09 Thread Zheng, Lv
+int __init acpi_early_console_keep(struct acpi_debug_port *info) Why not make it 'bool' like the other (acpi_early_console_enabled)? NAK. keep is int in setup_early_printk. Best regards/Lv Zheng -- To unsubscribe from this list: send the line unsubscribe linux-kernel in the body of a