Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-24 Thread Wolfram Sang
> Do we want to insist on a much larger change (conversion to regmap) > when if this in place, a simple single functional call change will do the > job? I'd assume that regmap conversion will happen later quite likely anyhow. Most of those devices will have I2C/SPI dual interfaces; or people

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-24 Thread Wolfram Sang
Do we want to insist on a much larger change (conversion to regmap) when if this in place, a simple single functional call change will do the job? I'd assume that regmap conversion will happen later quite likely anyhow. Most of those devices will have I2C/SPI dual interfaces; or people will

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-22 Thread Jonathan Cameron
On 22/08/15 05:02, Wolfram Sang wrote: > The series[1] I am working on implements a i2c smbus block data regmap bus driver. Regmap should then automatically do a block read in regmap_bulk_read. >>> >>> Hmm, so doesn't your series make Irina's series obsolete? It >>>

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-22 Thread Jonathan Cameron
On 22/08/15 05:02, Wolfram Sang wrote: The series[1] I am working on implements a i2c smbus block data regmap bus driver. Regmap should then automatically do a block read in regmap_bulk_read. Hmm, so doesn't your series make Irina's series obsolete? It addresses the same problem only

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-21 Thread Wolfram Sang
> > > The series[1] I am working on implements a i2c smbus block data > > > regmap > > > bus driver. Regmap should then automatically do a block read in > > > regmap_bulk_read. > > > > Hmm, so doesn't your series make Irina's series obsolete? It > > addresses > > the same problem only at a

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-21 Thread Pandruvada, Srinivas
On Fri, 2015-08-21 at 12:21 +0200, Wolfram Sang wrote: > On Mon, Aug 17, 2015 at 11:09:43AM +0200, Markus Pargmann wrote: > > On Sun, Aug 16, 2015 at 10:24:47AM +0100, Jonathan Cameron wrote: > > > On 12/08/15 15:31, Irina Tirdea wrote: > > > > Some i2c busses (e.g.: Synopsys DesignWare I2C

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-21 Thread Wolfram Sang
On Mon, Aug 17, 2015 at 11:09:43AM +0200, Markus Pargmann wrote: > On Sun, Aug 16, 2015 at 10:24:47AM +0100, Jonathan Cameron wrote: > > On 12/08/15 15:31, Irina Tirdea wrote: > > > Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to > > > enable/disable the bus at each i2c transfer

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-21 Thread Wolfram Sang
The series[1] I am working on implements a i2c smbus block data regmap bus driver. Regmap should then automatically do a block read in regmap_bulk_read. Hmm, so doesn't your series make Irina's series obsolete? It addresses the same problem only at a different layer (i2c

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-21 Thread Pandruvada, Srinivas
On Fri, 2015-08-21 at 12:21 +0200, Wolfram Sang wrote: On Mon, Aug 17, 2015 at 11:09:43AM +0200, Markus Pargmann wrote: On Sun, Aug 16, 2015 at 10:24:47AM +0100, Jonathan Cameron wrote: On 12/08/15 15:31, Irina Tirdea wrote: Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-21 Thread Wolfram Sang
On Mon, Aug 17, 2015 at 11:09:43AM +0200, Markus Pargmann wrote: On Sun, Aug 16, 2015 at 10:24:47AM +0100, Jonathan Cameron wrote: On 12/08/15 15:31, Irina Tirdea wrote: Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to enable/disable the bus at each i2c transfer and must

RE: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-17 Thread Tirdea, Irina
nivas; Peter Meerwald > Subject: Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in > trigger handler > > On Sun, Aug 16, 2015 at 10:24:47AM +0100, Jonathan Cameron wrote: > > On 12/08/15 15:31, Irina Tirdea wrote: > > > Some i2c busses (e.g.: Synopsys Desi

RE: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-17 Thread Tirdea, Irina
; Subject: Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in > trigger handler > > On 12/08/15 15:31, Irina Tirdea wrote: > > Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to > > enable/disable the bus at each i2c transfer and must wait for >

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-17 Thread Markus Pargmann
On Sun, Aug 16, 2015 at 10:24:47AM +0100, Jonathan Cameron wrote: > On 12/08/15 15:31, Irina Tirdea wrote: > > Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to > > enable/disable the bus at each i2c transfer and must wait for > > the enable/disable to happen before sending the data.

RE: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-17 Thread Tirdea, Irina
Subject: Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler On Sun, Aug 16, 2015 at 10:24:47AM +0100, Jonathan Cameron wrote: On 12/08/15 15:31, Irina Tirdea wrote: Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to enable/disable the bus at each i2c

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-17 Thread Markus Pargmann
On Sun, Aug 16, 2015 at 10:24:47AM +0100, Jonathan Cameron wrote: On 12/08/15 15:31, Irina Tirdea wrote: Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to enable/disable the bus at each i2c transfer and must wait for the enable/disable to happen before sending the data.

RE: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-17 Thread Tirdea, Irina
] iio: gyro: bmg160: optimize i2c transfers in trigger handler On 12/08/15 15:31, Irina Tirdea wrote: Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to enable/disable the bus at each i2c transfer and must wait for the enable/disable to happen before sending the data. When

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-16 Thread Jonathan Cameron
On 12/08/15 15:31, Irina Tirdea wrote: > Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to > enable/disable the bus at each i2c transfer and must wait for > the enable/disable to happen before sending the data. > > When reading data in the trigger handler, the bmg160 driver does >

Re: [PATCH v5 6/8] iio: gyro: bmg160: optimize i2c transfers in trigger handler

2015-08-16 Thread Jonathan Cameron
On 12/08/15 15:31, Irina Tirdea wrote: Some i2c busses (e.g.: Synopsys DesignWare I2C adapter) need to enable/disable the bus at each i2c transfer and must wait for the enable/disable to happen before sending the data. When reading data in the trigger handler, the bmg160 driver does one i2c