RE: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-29 Thread Seungwon Jeon
On Fri, August 30, 2013, Doug Anderson wrote: > Seungwon, > > On Thu, Aug 29, 2013 at 12:04 AM, Seungwon Jeon wrote: > >> I'd really still rather honor the MMC subsystem's request. It > >> shouldn't _hurt_ to turn the clock off when the subsystem requests it, > > Even though turning off by

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-29 Thread Doug Anderson
Seungwon, On Thu, Aug 29, 2013 at 12:04 AM, Seungwon Jeon wrote: >> I'd really still rather honor the MMC subsystem's request. It >> shouldn't _hurt_ to turn the clock off when the subsystem requests it, > Even though turning off by clock programming doesn't hurt, > it is costly behavior when

RE: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-29 Thread Seungwon Jeon
On Tuesday, August 27, 2013, Doug Anderson wrote: > Jaehoon / Seungwon, > > On Mon, Aug 26, 2013 at 2:06 AM, Jaehoon Chung wrote: > > On 08/26/2013 01:34 PM, Seungwon Jeon wrote: > >> On Fri, August 23, 2013, Doug Anderson wrote: > >>> Previously the dw_mmc driver would ignore any requests to

RE: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-29 Thread Seungwon Jeon
On Tuesday, August 27, 2013, Doug Anderson wrote: Jaehoon / Seungwon, On Mon, Aug 26, 2013 at 2:06 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/26/2013 01:34 PM, Seungwon Jeon wrote: On Fri, August 23, 2013, Doug Anderson wrote: Previously the dw_mmc driver would ignore any

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-29 Thread Doug Anderson
Seungwon, On Thu, Aug 29, 2013 at 12:04 AM, Seungwon Jeon tgih@samsung.com wrote: I'd really still rather honor the MMC subsystem's request. It shouldn't _hurt_ to turn the clock off when the subsystem requests it, Even though turning off by clock programming doesn't hurt, it is costly

RE: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-29 Thread Seungwon Jeon
On Fri, August 30, 2013, Doug Anderson wrote: Seungwon, On Thu, Aug 29, 2013 at 12:04 AM, Seungwon Jeon tgih@samsung.com wrote: I'd really still rather honor the MMC subsystem's request. It shouldn't _hurt_ to turn the clock off when the subsystem requests it, Even though turning

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-26 Thread Doug Anderson
Jaehoon / Seungwon, On Mon, Aug 26, 2013 at 2:06 AM, Jaehoon Chung wrote: > On 08/26/2013 01:34 PM, Seungwon Jeon wrote: >> On Fri, August 23, 2013, Doug Anderson wrote: >>> Previously the dw_mmc driver would ignore any requests to disable the >>> card's clock. This doesn't seem like a good

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-26 Thread Jaehoon Chung
On 08/26/2013 01:34 PM, Seungwon Jeon wrote: > On Fri, August 23, 2013, Doug Anderson wrote: >> Previously the dw_mmc driver would ignore any requests to disable the >> card's clock. This doesn't seem like a good thing in general, but had >> one extra bad side effect in the following situtation:

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-26 Thread Jaehoon Chung
On 08/26/2013 01:34 PM, Seungwon Jeon wrote: On Fri, August 23, 2013, Doug Anderson wrote: Previously the dw_mmc driver would ignore any requests to disable the card's clock. This doesn't seem like a good thing in general, but had one extra bad side effect in the following situtation: * mmc

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-26 Thread Doug Anderson
Jaehoon / Seungwon, On Mon, Aug 26, 2013 at 2:06 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: On 08/26/2013 01:34 PM, Seungwon Jeon wrote: On Fri, August 23, 2013, Doug Anderson wrote: Previously the dw_mmc driver would ignore any requests to disable the card's clock. This doesn't seem

RE: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-25 Thread Seungwon Jeon
On Fri, August 23, 2013, Doug Anderson wrote: > Previously the dw_mmc driver would ignore any requests to disable the > card's clock. This doesn't seem like a good thing in general, but had > one extra bad side effect in the following situtation: > * mmc core would set clk to 400kHz at boot time

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-25 Thread Doug Anderson
Jaehoon, On Sun, Aug 25, 2013 at 6:31 PM, Jaehoon Chung wrote: > Hi Doug, > > On 08/24/2013 05:40 AM, Doug Anderson wrote: >> Jaehoon, >> >> On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung >> wrote: >>> Hi Doug, >>> >>> If the clock-gating is enabled, then maybe it's continuously printed the

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-25 Thread Jaehoon Chung
Hi Doug, On 08/24/2013 05:40 AM, Doug Anderson wrote: > Jaehoon, > > On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung wrote: >> Hi Doug, >> >> If the clock-gating is enabled, then maybe it's continuously printed the >> kernel message for Bus_speed. > > Can you explain? I don't think dw_mmc has

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-25 Thread Jaehoon Chung
Hi Doug, On 08/24/2013 05:40 AM, Doug Anderson wrote: Jaehoon, On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Doug, If the clock-gating is enabled, then maybe it's continuously printed the kernel message for Bus_speed. Can you explain? I don't think

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-25 Thread Doug Anderson
Jaehoon, On Sun, Aug 25, 2013 at 6:31 PM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Doug, On 08/24/2013 05:40 AM, Doug Anderson wrote: Jaehoon, On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Doug, If the clock-gating is enabled, then maybe it's

RE: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-25 Thread Seungwon Jeon
On Fri, August 23, 2013, Doug Anderson wrote: Previously the dw_mmc driver would ignore any requests to disable the card's clock. This doesn't seem like a good thing in general, but had one extra bad side effect in the following situtation: * mmc core would set clk to 400kHz at boot time

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-23 Thread Doug Anderson
Jaehoon, On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung wrote: > Hi Doug, > > If the clock-gating is enabled, then maybe it's continuously printed the > kernel message for Bus_speed. Can you explain? I don't think dw_mmc has support for clock gating right now. ...or are there some patches

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-23 Thread Jaehoon Chung
Hi Doug, If the clock-gating is enabled, then maybe it's continuously printed the kernel message for Bus_speed. Best Regards, Jaehoon Chung On 08/23/2013 01:19 AM, Doug Anderson wrote: > Previously the dw_mmc driver would ignore any requests to disable the > card's clock. This doesn't seem

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-23 Thread Jaehoon Chung
Hi Doug, If the clock-gating is enabled, then maybe it's continuously printed the kernel message for Bus_speed. Best Regards, Jaehoon Chung On 08/23/2013 01:19 AM, Doug Anderson wrote: Previously the dw_mmc driver would ignore any requests to disable the card's clock. This doesn't seem like

Re: [PATCH v6 2/3] mmc: dw_mmc: Honor requests to set the clock to 0 (turn off clock)

2013-08-23 Thread Doug Anderson
Jaehoon, On Fri, Aug 23, 2013 at 6:21 AM, Jaehoon Chung jh80.ch...@samsung.com wrote: Hi Doug, If the clock-gating is enabled, then maybe it's continuously printed the kernel message for Bus_speed. Can you explain? I don't think dw_mmc has support for clock gating right now. ...or are