RE: [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER

2014-10-13 Thread Ren, Qiaowei
On 2014-10-14, Hansen, Dave wrote: > On 07/20/2014 11:09 PM, Andi Kleen wrote: >> Qiaowei Ren writes: >>> This patch adds the PR_MPX_REGISTER and PR_MPX_UNREGISTER prctl() >>> commands. These commands can be used to register and unregister MPX >>> related resource on the x86 platform. >> >>

Re: [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER

2014-10-13 Thread Dave Hansen
On 07/20/2014 11:09 PM, Andi Kleen wrote: > Qiaowei Ren writes: >> This patch adds the PR_MPX_REGISTER and PR_MPX_UNREGISTER prctl() >> commands. These commands can be used to register and unregister MPX >> related resource on the x86 platform. > > Please provide a manpage for the API. This is

Re: [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER

2014-10-13 Thread Dave Hansen
On 07/20/2014 11:09 PM, Andi Kleen wrote: Qiaowei Ren qiaowei@intel.com writes: This patch adds the PR_MPX_REGISTER and PR_MPX_UNREGISTER prctl() commands. These commands can be used to register and unregister MPX related resource on the x86 platform. Please provide a manpage for the

RE: [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER

2014-10-13 Thread Ren, Qiaowei
On 2014-10-14, Hansen, Dave wrote: On 07/20/2014 11:09 PM, Andi Kleen wrote: Qiaowei Ren qiaowei@intel.com writes: This patch adds the PR_MPX_REGISTER and PR_MPX_UNREGISTER prctl() commands. These commands can be used to register and unregister MPX related resource on the x86 platform.

Re: [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER

2014-07-23 Thread Dave Hansen
On 07/20/2014 10:38 PM, Qiaowei Ren wrote: > + pr_debug("MPX BD base address %p\n", mm->bd_addr); > + return 0; > +} Please remove all of the pr_debug()s. They're not appropriate for common paths in production code. There's another one in allocate_bt(), btw. -- To unsubscribe from this

Re: [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER

2014-07-23 Thread Dave Hansen
On 07/20/2014 10:38 PM, Qiaowei Ren wrote: + pr_debug(MPX BD base address %p\n, mm-bd_addr); + return 0; +} Please remove all of the pr_debug()s. They're not appropriate for common paths in production code. There's another one in allocate_bt(), btw. -- To unsubscribe from this list:

Re: [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER

2014-07-21 Thread Andi Kleen
Qiaowei Ren writes: > This patch adds the PR_MPX_REGISTER and PR_MPX_UNREGISTER prctl() > commands. These commands can be used to register and unregister MPX > related resource on the x86 platform. Please provide a manpage for the API. This is needed for proper review. Your description is far

Re: [PATCH v7 08/10] x86, mpx: add prctl commands PR_MPX_REGISTER, PR_MPX_UNREGISTER

2014-07-21 Thread Andi Kleen
Qiaowei Ren qiaowei@intel.com writes: This patch adds the PR_MPX_REGISTER and PR_MPX_UNREGISTER prctl() commands. These commands can be used to register and unregister MPX related resource on the x86 platform. Please provide a manpage for the API. This is needed for proper review. Your