RE: [PATCH v9 7/8] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes

2021-03-12 Thread Aisheng Dong
> From: Mirela Rabulea (OSS) 
> Sent: Thursday, March 11, 2021 8:29 AM
> 
> Add jpeg decoder/encoder nodes, for now on imx8qxp only.
> The same should work on imx8qm, but it was not tested.
> 
> Signed-off-by: Mirela Rabulea 

Please rebase to latest shawn/for-next branch and add
the necessary clocks.
I can help review when resend.

Regards
Aisheng

> ---
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 35
> ++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 1d522de7b017..4f2b3edd7850 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -629,4 +629,39 @@
>   };
>   };
>   };
> +
> + img_subsys: bus@5800 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x5800 0x0 0x5800 0x100>;
> +
> + jpegdec: jpegdec@5840 {
> + compatible = "nxp,imx8qxp-jpgdec";
> + reg = <0x5840 0x0005 >;
> + interrupts = ,
> +  ,
> +  ,
> +  ;
> + power-domains = < IMX_SC_R_MJPEG_DEC_MP>,
> + < IMX_SC_R_MJPEG_DEC_S0>,
> + < IMX_SC_R_MJPEG_DEC_S1>,
> + < IMX_SC_R_MJPEG_DEC_S2>,
> + < IMX_SC_R_MJPEG_DEC_S3>;
> + };
> +
> + jpegenc: jpegenc@5845 {
> + compatible = "nxp,imx8qxp-jpgenc";
> + reg = <0x5845 0x0005 >;
> + interrupts = ,
> +  ,
> +  ,
> +  ;
> + power-domains = < IMX_SC_R_MJPEG_ENC_MP>,
> + < IMX_SC_R_MJPEG_ENC_S0>,
> + < IMX_SC_R_MJPEG_ENC_S1>,
> + < IMX_SC_R_MJPEG_ENC_S2>,
> + < IMX_SC_R_MJPEG_ENC_S3>;
> + };
> + };
>  };
> --
> 2.17.1



Re: [PATCH v9 7/8] arm64: dts: imx8qxp: Add jpeg encoder/decoder nodes

2021-03-11 Thread Hans Verkuil
Hi Mirela,

On 11/03/2021 01:28, Mirela Rabulea (OSS) wrote:
> From: Mirela Rabulea 
> 
> Add jpeg decoder/encoder nodes, for now on imx8qxp only.
> The same should work on imx8qm, but it was not tested.

FYI: I've posted a pull request for this driver, and once it is merged
in our media tree this patch can be merged for 5.13 by whoever handles
these dts patches.

Thank you for all your work on this!

Regards,

Hans

> 
> Signed-off-by: Mirela Rabulea 
> ---
>  arch/arm64/boot/dts/freescale/imx8qxp.dtsi | 35 ++
>  1 file changed, 35 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi 
> b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> index 1d522de7b017..4f2b3edd7850 100644
> --- a/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> +++ b/arch/arm64/boot/dts/freescale/imx8qxp.dtsi
> @@ -629,4 +629,39 @@
>   };
>   };
>   };
> +
> + img_subsys: bus@5800 {
> + compatible = "simple-bus";
> + #address-cells = <1>;
> + #size-cells = <1>;
> + ranges = <0x5800 0x0 0x5800 0x100>;
> +
> + jpegdec: jpegdec@5840 {
> + compatible = "nxp,imx8qxp-jpgdec";
> + reg = <0x5840 0x0005 >;
> + interrupts = ,
> +  ,
> +  ,
> +  ;
> + power-domains = < IMX_SC_R_MJPEG_DEC_MP>,
> + < IMX_SC_R_MJPEG_DEC_S0>,
> + < IMX_SC_R_MJPEG_DEC_S1>,
> + < IMX_SC_R_MJPEG_DEC_S2>,
> + < IMX_SC_R_MJPEG_DEC_S3>;
> + };
> +
> + jpegenc: jpegenc@5845 {
> + compatible = "nxp,imx8qxp-jpgenc";
> + reg = <0x5845 0x0005 >;
> + interrupts = ,
> +  ,
> +  ,
> +  ;
> + power-domains = < IMX_SC_R_MJPEG_ENC_MP>,
> + < IMX_SC_R_MJPEG_ENC_S0>,
> + < IMX_SC_R_MJPEG_ENC_S1>,
> + < IMX_SC_R_MJPEG_ENC_S2>,
> + < IMX_SC_R_MJPEG_ENC_S3>;
> + };
> + };
>  };
>