RE: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-03 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > to simplify the code. > > On 09/03/2014 05:37 AM, li.xi...@freescale.com wrote: > >> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > ... > &

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-03 Thread Jyri Sarha
On 09/03/2014 05:37 AM, li.xi...@freescale.com wrote: Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() ... This won't work. The logic for cpu node needs to be negated for codec node. Yes, actually it should be. As my previous patches about this: Since

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-03 Thread Jyri Sarha
On 09/03/2014 05:37 AM, li.xi...@freescale.com wrote: Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() ... This won't work. The logic for cpu node needs to be negated for codec node. Yes, actually it should be. As my previous patches about this: Since

RE: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-03 Thread li.xi...@freescale.com
Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code. On 09/03/2014 05:37 AM, li.xi...@freescale.com wrote: Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() ... This won't work. The logic for cpu node

RE: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
> Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add > asoc_simple_card_fmt_master() > to simplify the code. > > On 09/02/2014 12:26 PM, Xiubo Li wrote: > > Signed-off-by: Xiubo Li > > --- > > sound/soc/generic/simple-card.c | 61

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Jyri Sarha
On 09/02/2014 02:09 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 16:12:40 +0530 Varka Bhadram wrote: + switch (((np == bitclkmaster) << 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10: + return

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Jyri Sarha
On 09/02/2014 12:26 PM, Xiubo Li wrote: Signed-off-by: Xiubo Li --- sound/soc/generic/simple-card.c | 61 - 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Jean-Francois Moine
On Tue, 02 Sep 2014 16:12:40 +0530 Varka Bhadram wrote: > >>> + switch (((np == bitclkmaster) << 4) | (np == framemaster)) { > >>> + case 0x11: > >>> + return SND_SOC_DAIFMT_CBS_CFS; > >>> + case 0x10: > >>> + return SND_SOC_DAIFMT_CBS_CFM; > >>> + case 0x01: > >>> +

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Takashi Iwai
At Tue, 02 Sep 2014 16:12:40 +0530, Varka Bhadram wrote: > > On 09/02/2014 04:08 PM, Jean-Francois Moine wrote: > > On Tue, 02 Sep 2014 15:51:41 +0530 > > Varka Bhadram wrote: > > > >>> + switch (((np == bitclkmaster) << 4) | (np == framemaster)) { > >>> + case 0x11: > >>> + return

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
On 09/02/2014 04:08 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram wrote: + switch (((np == bitclkmaster) << 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10: + return

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Jean-Francois Moine
On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram wrote: > > + switch (((np == bitclkmaster) << 4) | (np == framemaster)) { > > + case 0x11: > > + return SND_SOC_DAIFMT_CBS_CFS; > > + case 0x10: > > + return SND_SOC_DAIFMT_CBS_CFM; > > + case 0x01: > > +

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
On 09/02/2014 02:56 PM, Xiubo Li wrote: Signed-off-by: Xiubo Li --- sound/soc/generic/simple-card.c | 61 - 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/sound/soc/generic/simple-card.c b/sound/soc/generic/simple-card.c index

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
On 09/02/2014 02:56 PM, Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com --- sound/soc/generic/simple-card.c | 61 - 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/sound/soc/generic/simple-card.c

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Jean-Francois Moine
On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram varkabhad...@gmail.com wrote: + switch (((np == bitclkmaster) 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10: + return SND_SOC_DAIFMT_CBS_CFM; + case 0x01: +

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Varka Bhadram
On 09/02/2014 04:08 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram varkabhad...@gmail.com wrote: + switch (((np == bitclkmaster) 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10: +

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Takashi Iwai
At Tue, 02 Sep 2014 16:12:40 +0530, Varka Bhadram wrote: On 09/02/2014 04:08 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 15:51:41 +0530 Varka Bhadram varkabhad...@gmail.com wrote: + switch (((np == bitclkmaster) 4) | (np == framemaster)) { + case 0x11: + return

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Jean-Francois Moine
On Tue, 02 Sep 2014 16:12:40 +0530 Varka Bhadram varkabhad...@gmail.com wrote: + switch (((np == bitclkmaster) 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10: + return SND_SOC_DAIFMT_CBS_CFM; + case 0x01: + return

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Jyri Sarha
On 09/02/2014 12:26 PM, Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com --- sound/soc/generic/simple-card.c | 61 - 1 file changed, 29 insertions(+), 32 deletions(-) diff --git a/sound/soc/generic/simple-card.c

Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread Jyri Sarha
On 09/02/2014 02:09 PM, Jean-Francois Moine wrote: On Tue, 02 Sep 2014 16:12:40 +0530 Varka Bhadram varkabhad...@gmail.com wrote: + switch (((np == bitclkmaster) 4) | (np == framemaster)) { + case 0x11: + return SND_SOC_DAIFMT_CBS_CFS; + case 0x10: +

RE: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code.

2014-09-02 Thread li.xi...@freescale.com
Subject: Re: [PATCHv2 1/4] ASoC: simple-card: add asoc_simple_card_fmt_master() to simplify the code. On 09/02/2014 12:26 PM, Xiubo Li wrote: Signed-off-by: Xiubo Li li.xi...@freescale.com --- sound/soc/generic/simple-card.c | 61 - 1