RE: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Elliott, Robert (Persistent Memory)]

> -Original Message-
> From: linux-block-ow...@vger.kernel.org [mailto:linux-block-
> ow...@vger.kernel.org] On Behalf Of Jon Derrick
> Sent: Thursday, February 16, 2017 10:15 AM
> To: Michael Ellerman <m...@ellerman.id.au>
> Cc: Jens Axboe <ax...@kernel.dk>; Rafael Antognolli
> <rafael.antogno...@intel.com>; Greg Kroah-Hartman
> <gre...@linuxfoundation.org>; linux-kernel@vger.kernel.org; linux-
> bl...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Christoph Hellwig
> <h...@lst.de>; Scott Bauer <scott.ba...@intel.com>
> Subject: Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match
> 
> Thanks everyone. Sorry about the mess :)
> 
> On 02/15/2017 10:23 PM, Michael Ellerman wrote:
> > Jon Derrick <jonathan.derr...@intel.com> writes:
> >
> >> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
> >> like the 'arch/powerpc' file pattern should be enough to match powerpc
> >> opal code by itself. Remove the opal regex pattern from powerpc.
> >
> > We thought of it first.
> >
> > Can't you just rename your driver, Opal Storage Specification, so "oss",
> > that should be pretty unique?
> >
> > ... :)

The library could easily be used for devices supporting the Opalite and Pyrite 
SSCs, not just the Opal SSC. With some effort, I suspect that Enterprise SSC
could also be supported.  So, a broader name might indeed be useful.

The full names of the specifications are:
TCG Storage Security Subsystem Class: Opal
TCG Storage Security Subsystem Class: Opalite
TCG Storage Security Subsystem Class: Pyrite
TCG Storage Security Subsystem Class: Enterprise

---
Robert Elliott, HPE Persistent Memory

RE: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Elliott, Robert (Persistent Memory)]

> -Original Message-
> From: linux-block-ow...@vger.kernel.org [mailto:linux-block-
> ow...@vger.kernel.org] On Behalf Of Jon Derrick
> Sent: Thursday, February 16, 2017 10:15 AM
> To: Michael Ellerman 
> Cc: Jens Axboe ; Rafael Antognolli
> ; Greg Kroah-Hartman
> ; linux-kernel@vger.kernel.org; linux-
> bl...@vger.kernel.org; linuxppc-...@lists.ozlabs.org; Christoph Hellwig
> ; Scott Bauer 
> Subject: Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match
> 
> Thanks everyone. Sorry about the mess :)
> 
> On 02/15/2017 10:23 PM, Michael Ellerman wrote:
> > Jon Derrick  writes:
> >
> >> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
> >> like the 'arch/powerpc' file pattern should be enough to match powerpc
> >> opal code by itself. Remove the opal regex pattern from powerpc.
> >
> > We thought of it first.
> >
> > Can't you just rename your driver, Opal Storage Specification, so "oss",
> > that should be pretty unique?
> >
> > ... :)

The library could easily be used for devices supporting the Opalite and Pyrite 
SSCs, not just the Opal SSC. With some effort, I suspect that Enterprise SSC
could also be supported.  So, a broader name might indeed be useful.

The full names of the specifications are:
TCG Storage Security Subsystem Class: Opal
TCG Storage Security Subsystem Class: Opalite
TCG Storage Security Subsystem Class: Pyrite
TCG Storage Security Subsystem Class: Enterprise

---
Robert Elliott, HPE Persistent Memory

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Jon Derrick]

Thanks everyone. Sorry about the mess :)

On 02/15/2017 10:23 PM, Michael Ellerman wrote:
> Jon Derrick  writes:
> 
>> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
>> like the 'arch/powerpc' file pattern should be enough to match powerpc
>> opal code by itself. Remove the opal regex pattern from powerpc.
> 
> We thought of it first.
> 
> Can't you just rename your driver, Opal Storage Specification, so "oss",
> that should be pretty unique?
> 
> ... :)
> 
> I don't like this version, but I'll merge the one from Stewart which
> drops the pattern and adds the paths for the existing drivers.
> 
> cheers
> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b983b25..430dd02 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -7404,7 +7404,6 @@ F: drivers/pci/hotplug/pnv_php.c
>>  F:  drivers/pci/hotplug/rpa*
>>  F:  drivers/scsi/ibmvscsi/
>>  F:  tools/testing/selftests/powerpc
>> -N:  opal
>>  N:  /pmac
>>  N:  powermac
>>  N:  powernv
>> -- 
>> 1.8.3.1

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Jon Derrick]

Thanks everyone. Sorry about the mess :)

On 02/15/2017 10:23 PM, Michael Ellerman wrote:
> Jon Derrick  writes:
> 
>> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
>> like the 'arch/powerpc' file pattern should be enough to match powerpc
>> opal code by itself. Remove the opal regex pattern from powerpc.
> 
> We thought of it first.
> 
> Can't you just rename your driver, Opal Storage Specification, so "oss",
> that should be pretty unique?
> 
> ... :)
> 
> I don't like this version, but I'll merge the one from Stewart which
> drops the pattern and adds the paths for the existing drivers.
> 
> cheers
> 
>> diff --git a/MAINTAINERS b/MAINTAINERS
>> index b983b25..430dd02 100644
>> --- a/MAINTAINERS
>> +++ b/MAINTAINERS
>> @@ -7404,7 +7404,6 @@ F: drivers/pci/hotplug/pnv_php.c
>>  F:  drivers/pci/hotplug/rpa*
>>  F:  drivers/scsi/ibmvscsi/
>>  F:  tools/testing/selftests/powerpc
>> -N:  opal
>>  N:  /pmac
>>  N:  powermac
>>  N:  powernv
>> -- 
>> 1.8.3.1

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Michael Ellerman]

Jon Derrick  writes:

> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
> like the 'arch/powerpc' file pattern should be enough to match powerpc
> opal code by itself. Remove the opal regex pattern from powerpc.

We thought of it first.

Can't you just rename your driver, Opal Storage Specification, so "oss",
that should be pretty unique?

... :)

I don't like this version, but I'll merge the one from Stewart which
drops the pattern and adds the paths for the existing drivers.

cheers

> diff --git a/MAINTAINERS b/MAINTAINERS
> index b983b25..430dd02 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7404,7 +7404,6 @@ F:  drivers/pci/hotplug/pnv_php.c
>  F:   drivers/pci/hotplug/rpa*
>  F:   drivers/scsi/ibmvscsi/
>  F:   tools/testing/selftests/powerpc
> -N:   opal
>  N:   /pmac
>  N:   powermac
>  N:   powernv
> -- 
> 1.8.3.1

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Michael Ellerman]

Jon Derrick  writes:

> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
> like the 'arch/powerpc' file pattern should be enough to match powerpc
> opal code by itself. Remove the opal regex pattern from powerpc.

We thought of it first.

Can't you just rename your driver, Opal Storage Specification, so "oss",
that should be pretty unique?

... :)

I don't like this version, but I'll merge the one from Stewart which
drops the pattern and adds the paths for the existing drivers.

cheers

> diff --git a/MAINTAINERS b/MAINTAINERS
> index b983b25..430dd02 100644
> --- a/MAINTAINERS
> +++ b/MAINTAINERS
> @@ -7404,7 +7404,6 @@ F:  drivers/pci/hotplug/pnv_php.c
>  F:   drivers/pci/hotplug/rpa*
>  F:   drivers/scsi/ibmvscsi/
>  F:   tools/testing/selftests/powerpc
> -N:   opal
>  N:   /pmac
>  N:   powermac
>  N:   powernv
> -- 
> 1.8.3.1

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Andrew Donnellan]

On 16/02/17 11:37, Stewart Smith wrote:

Jon Derrick  writes:

PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
like the 'arch/powerpc' file pattern should be enough to match powerpc
opal code by itself. Remove the opal regex pattern from powerpc.


This patch will end up missing some code, what about this instead:


Remove OPAL regex in powerpc to avoid false match

Signed-off-by: Stewart Smith 


Per my reply to v4 of this series, your list matches mine. With the one 
typo correction below:


Reviewed-by: Andrew Donnellan 



---
 MAINTAINERS |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3960e7f..25ed25a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7393,18 +7393,24 @@ L:  linuxppc-...@lists.ozlabs.org
 Q: http://patchwork.ozlabs.org/project/linuxppc-dev/list/
 T: git git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
 S: Supported
+F: Documentation/ABI/stable/sysfs-firmware-opal-*
+F: Documentation/devicetree/bindings/powerpc/opal/
+F: Documentation/devicetree/bindings/rtc/rtc-opal.txt
+F: Documentation/devicetree/bindings/i2c/i2c-opal.txt
 F: Documentation/powerpc/
 F: arch/powerpc/
 F: drivers/char/tpm/tpm_ibmvtpm*
 F: drivers/crypto/nx/
 F: drivers/crypto/vmx/
+F: drivers/i2c/busses/ic2-opal.c


i2c-opal


 F: drivers/net/ethernet/ibm/ibmveth.*
 F: drivers/net/ethernet/ibm/ibmvnic.*
 F: drivers/pci/hotplug/pnv_php.c
 F: drivers/pci/hotplug/rpa*
+F: drivers/rtc/rtc-opal.c
 F: drivers/scsi/ibmvscsi/
+F: drivers/tty/hvc/hvc_opal.c
 F: tools/testing/selftests/powerpc
-N: opal
 N: /pmac
 N: powermac
 N: powernv




--
Andrew Donnellan  OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com  IBM Australia Limited

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Andrew Donnellan]

On 16/02/17 11:37, Stewart Smith wrote:

Jon Derrick  writes:

PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
like the 'arch/powerpc' file pattern should be enough to match powerpc
opal code by itself. Remove the opal regex pattern from powerpc.


This patch will end up missing some code, what about this instead:


Remove OPAL regex in powerpc to avoid false match

Signed-off-by: Stewart Smith 


Per my reply to v4 of this series, your list matches mine. With the one 
typo correction below:


Reviewed-by: Andrew Donnellan 



---
 MAINTAINERS |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3960e7f..25ed25a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7393,18 +7393,24 @@ L:  linuxppc-...@lists.ozlabs.org
 Q: http://patchwork.ozlabs.org/project/linuxppc-dev/list/
 T: git git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
 S: Supported
+F: Documentation/ABI/stable/sysfs-firmware-opal-*
+F: Documentation/devicetree/bindings/powerpc/opal/
+F: Documentation/devicetree/bindings/rtc/rtc-opal.txt
+F: Documentation/devicetree/bindings/i2c/i2c-opal.txt
 F: Documentation/powerpc/
 F: arch/powerpc/
 F: drivers/char/tpm/tpm_ibmvtpm*
 F: drivers/crypto/nx/
 F: drivers/crypto/vmx/
+F: drivers/i2c/busses/ic2-opal.c


i2c-opal


 F: drivers/net/ethernet/ibm/ibmveth.*
 F: drivers/net/ethernet/ibm/ibmvnic.*
 F: drivers/pci/hotplug/pnv_php.c
 F: drivers/pci/hotplug/rpa*
+F: drivers/rtc/rtc-opal.c
 F: drivers/scsi/ibmvscsi/
+F: drivers/tty/hvc/hvc_opal.c
 F: tools/testing/selftests/powerpc
-N: opal
 N: /pmac
 N: powermac
 N: powernv




--
Andrew Donnellan  OzLabs, ADL Canberra
andrew.donnel...@au1.ibm.com  IBM Australia Limited

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Stewart Smith]

Jon Derrick  writes:
> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
> like the 'arch/powerpc' file pattern should be enough to match powerpc
> opal code by itself. Remove the opal regex pattern from powerpc.

This patch will end up missing some code, what about this instead:


Remove OPAL regex in powerpc to avoid false match

Signed-off-by: Stewart Smith 

---
 MAINTAINERS |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3960e7f..25ed25a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7393,18 +7393,24 @@ L:  linuxppc-...@lists.ozlabs.org
 Q: http://patchwork.ozlabs.org/project/linuxppc-dev/list/
 T: git git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
 S: Supported
+F: Documentation/ABI/stable/sysfs-firmware-opal-*
+F: Documentation/devicetree/bindings/powerpc/opal/
+F: Documentation/devicetree/bindings/rtc/rtc-opal.txt
+F: Documentation/devicetree/bindings/i2c/i2c-opal.txt
 F: Documentation/powerpc/
 F: arch/powerpc/
 F: drivers/char/tpm/tpm_ibmvtpm*
 F: drivers/crypto/nx/
 F: drivers/crypto/vmx/
+F: drivers/i2c/busses/ic2-opal.c
 F: drivers/net/ethernet/ibm/ibmveth.*
 F: drivers/net/ethernet/ibm/ibmvnic.*
 F: drivers/pci/hotplug/pnv_php.c
 F: drivers/pci/hotplug/rpa*
+F: drivers/rtc/rtc-opal.c
 F: drivers/scsi/ibmvscsi/
+F: drivers/tty/hvc/hvc_opal.c
 F: tools/testing/selftests/powerpc
-N: opal
 N: /pmac
 N: powermac
 N: powernv


-- 
Stewart Smith
OPAL Architect, IBM.

Re: [PATCHv3 4/4] MAINTAINERS: Remove powerpc's opal match

[Stewart Smith]

Jon Derrick  writes:
> PPC's 'opal' match pattern also matches block/sed-opal.c, where it looks
> like the 'arch/powerpc' file pattern should be enough to match powerpc
> opal code by itself. Remove the opal regex pattern from powerpc.

This patch will end up missing some code, what about this instead:


Remove OPAL regex in powerpc to avoid false match

Signed-off-by: Stewart Smith 

---
 MAINTAINERS |8 +++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/MAINTAINERS b/MAINTAINERS
index 3960e7f..25ed25a 100644
--- a/MAINTAINERS
+++ b/MAINTAINERS
@@ -7393,18 +7393,24 @@ L:  linuxppc-...@lists.ozlabs.org
 Q: http://patchwork.ozlabs.org/project/linuxppc-dev/list/
 T: git git://git.kernel.org/pub/scm/linux/kernel/git/powerpc/linux.git
 S: Supported
+F: Documentation/ABI/stable/sysfs-firmware-opal-*
+F: Documentation/devicetree/bindings/powerpc/opal/
+F: Documentation/devicetree/bindings/rtc/rtc-opal.txt
+F: Documentation/devicetree/bindings/i2c/i2c-opal.txt
 F: Documentation/powerpc/
 F: arch/powerpc/
 F: drivers/char/tpm/tpm_ibmvtpm*
 F: drivers/crypto/nx/
 F: drivers/crypto/vmx/
+F: drivers/i2c/busses/ic2-opal.c
 F: drivers/net/ethernet/ibm/ibmveth.*
 F: drivers/net/ethernet/ibm/ibmvnic.*
 F: drivers/pci/hotplug/pnv_php.c
 F: drivers/pci/hotplug/rpa*
+F: drivers/rtc/rtc-opal.c
 F: drivers/scsi/ibmvscsi/
+F: drivers/tty/hvc/hvc_opal.c
 F: tools/testing/selftests/powerpc
-N: opal
 N: /pmac
 N: powermac
 N: powernv


-- 
Stewart Smith
OPAL Architect, IBM.