RE: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction

2014-10-28 Thread Wang, Yalin 
> From: Rob Herring [mailto:robherri...@gmail.com]
> >> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index
> >> 9532f8d..263c28c 100644
> >> --- a/arch/arm64/Kconfig
> >> +++ b/arch/arm64/Kconfig
> >> @@ -36,6 +36,7 @@ config ARM64
> >>   select HARDIRQS_SW_RESEND
> >>   select HAVE_ARCH_AUDITSYSCALL
> >>   select HAVE_ARCH_JUMP_LABEL
> >> + select HAVE_ARCH_BITREVERSE
> >>   select HAVE_ARCH_KGDB
> >>   select HAVE_ARCH_TRACEHOOK
> >>   select HAVE_BPF_JIT
> 
> The kconfig lists should be sorted.
> 
> Rob

Got it ,
Thanks for your remind.

Re: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction

2014-10-28 Thread Rob Herring 
On Mon, Oct 27, 2014 at 2:46 PM, Joe Perches  wrote:
> On Mon, 2014-10-27 at 14:37 +0800, Wang, Yalin wrote:
>> this change add CONFIG_HAVE_ARCH_BITREVERSE config option,
>> so that we can use arm/arm64 rbit instruction to do bitrev operation
>> by hardware.

I don't see the original patch in my inbox, so replying here.

>>
>> Signed-off-by: Yalin Wang 
>> ---
>>  arch/arm/Kconfig|  1 +
>>  arch/arm/include/asm/bitrev.h   | 21 +
>>  arch/arm64/Kconfig  |  1 +
>>  arch/arm64/include/asm/bitrev.h | 21 +
>>  include/linux/bitrev.h  |  9 +
>>  lib/Kconfig |  9 +
>>  lib/bitrev.c|  2 ++
>>  7 files changed, 64 insertions(+)
>>  create mode 100644 arch/arm/include/asm/bitrev.h
>>  create mode 100644 arch/arm64/include/asm/bitrev.h
>>
>> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
>> index 89c4b5c..426cbcc 100644
>> --- a/arch/arm/Kconfig
>> +++ b/arch/arm/Kconfig
>> @@ -16,6 +16,7 @@ config ARM
>>   select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS
>>   select GENERIC_ALLOCATOR
>>   select GENERIC_ATOMIC64 if (CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI)
>> + select HAVE_ARCH_BITREVERSE if (CPU_V7M || CPU_V7)
>>   select GENERIC_CLOCKEVENTS_BROADCAST if SMP
>>   select GENERIC_IDLE_POLL_SETUP
>>   select GENERIC_IRQ_PROBE

[...]

>> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
>> index 9532f8d..263c28c 100644
>> --- a/arch/arm64/Kconfig
>> +++ b/arch/arm64/Kconfig
>> @@ -36,6 +36,7 @@ config ARM64
>>   select HARDIRQS_SW_RESEND
>>   select HAVE_ARCH_AUDITSYSCALL
>>   select HAVE_ARCH_JUMP_LABEL
>> + select HAVE_ARCH_BITREVERSE
>>   select HAVE_ARCH_KGDB
>>   select HAVE_ARCH_TRACEHOOK
>>   select HAVE_BPF_JIT

The kconfig lists should be sorted.

Rob
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction

2014-10-28 Thread Rob Herring 
On Mon, Oct 27, 2014 at 2:46 PM, Joe Perches j...@perches.com wrote:
 On Mon, 2014-10-27 at 14:37 +0800, Wang, Yalin wrote:
 this change add CONFIG_HAVE_ARCH_BITREVERSE config option,
 so that we can use arm/arm64 rbit instruction to do bitrev operation
 by hardware.

I don't see the original patch in my inbox, so replying here.


 Signed-off-by: Yalin Wang yalin.w...@sonymobile.com
 ---
  arch/arm/Kconfig|  1 +
  arch/arm/include/asm/bitrev.h   | 21 +
  arch/arm64/Kconfig  |  1 +
  arch/arm64/include/asm/bitrev.h | 21 +
  include/linux/bitrev.h  |  9 +
  lib/Kconfig |  9 +
  lib/bitrev.c|  2 ++
  7 files changed, 64 insertions(+)
  create mode 100644 arch/arm/include/asm/bitrev.h
  create mode 100644 arch/arm64/include/asm/bitrev.h

 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
 index 89c4b5c..426cbcc 100644
 --- a/arch/arm/Kconfig
 +++ b/arch/arm/Kconfig
 @@ -16,6 +16,7 @@ config ARM
   select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS
   select GENERIC_ALLOCATOR
   select GENERIC_ATOMIC64 if (CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI)
 + select HAVE_ARCH_BITREVERSE if (CPU_V7M || CPU_V7)
   select GENERIC_CLOCKEVENTS_BROADCAST if SMP
   select GENERIC_IDLE_POLL_SETUP
   select GENERIC_IRQ_PROBE

[...]

 diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
 index 9532f8d..263c28c 100644
 --- a/arch/arm64/Kconfig
 +++ b/arch/arm64/Kconfig
 @@ -36,6 +36,7 @@ config ARM64
   select HARDIRQS_SW_RESEND
   select HAVE_ARCH_AUDITSYSCALL
   select HAVE_ARCH_JUMP_LABEL
 + select HAVE_ARCH_BITREVERSE
   select HAVE_ARCH_KGDB
   select HAVE_ARCH_TRACEHOOK
   select HAVE_BPF_JIT

The kconfig lists should be sorted.

Rob
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction

2014-10-28 Thread Wang, Yalin 
 From: Rob Herring [mailto:robherri...@gmail.com]
  diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig index
  9532f8d..263c28c 100644
  --- a/arch/arm64/Kconfig
  +++ b/arch/arm64/Kconfig
  @@ -36,6 +36,7 @@ config ARM64
select HARDIRQS_SW_RESEND
select HAVE_ARCH_AUDITSYSCALL
select HAVE_ARCH_JUMP_LABEL
  + select HAVE_ARCH_BITREVERSE
select HAVE_ARCH_KGDB
select HAVE_ARCH_TRACEHOOK
select HAVE_BPF_JIT
 
 The kconfig lists should be sorted.
 
 Rob

Got it ,
Thanks for your remind.

RE: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction

2014-10-27 Thread Wang, Yalin 


> 
> If this is done, the direct uses of byte_rev_table in
> drivers/net/wireless/ath/carl9170/phy.c and sound/usb/6fire/firmware.c
> should be converted too?
> 

I think use bitrev8()  is safer than to use byte_rev_table[]  directly.

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction

2014-10-27 Thread Joe Perches 
On Mon, 2014-10-27 at 14:37 +0800, Wang, Yalin wrote:
> this change add CONFIG_HAVE_ARCH_BITREVERSE config option,
> so that we can use arm/arm64 rbit instruction to do bitrev operation
> by hardware.
> 
> Signed-off-by: Yalin Wang 
> ---
>  arch/arm/Kconfig|  1 +
>  arch/arm/include/asm/bitrev.h   | 21 +
>  arch/arm64/Kconfig  |  1 +
>  arch/arm64/include/asm/bitrev.h | 21 +
>  include/linux/bitrev.h  |  9 +
>  lib/Kconfig |  9 +
>  lib/bitrev.c|  2 ++
>  7 files changed, 64 insertions(+)
>  create mode 100644 arch/arm/include/asm/bitrev.h
>  create mode 100644 arch/arm64/include/asm/bitrev.h
> 
> diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
> index 89c4b5c..426cbcc 100644
> --- a/arch/arm/Kconfig
> +++ b/arch/arm/Kconfig
> @@ -16,6 +16,7 @@ config ARM
>   select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS
>   select GENERIC_ALLOCATOR
>   select GENERIC_ATOMIC64 if (CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI)
> + select HAVE_ARCH_BITREVERSE if (CPU_V7M || CPU_V7)
>   select GENERIC_CLOCKEVENTS_BROADCAST if SMP
>   select GENERIC_IDLE_POLL_SETUP
>   select GENERIC_IRQ_PROBE
> diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h
> new file mode 100644
> index 000..0df5866
> --- /dev/null
> +++ b/arch/arm/include/asm/bitrev.h
> @@ -0,0 +1,21 @@
> +#ifndef __ASM_ARM_BITREV_H
> +#define __ASM_ARM_BITREV_H
> +
> +static inline __attribute_const__ u32 __arch_bitrev32(u32 x)
> +{
> + __asm__ ("rbit %0, %1" : "=r" (x) : "r" (x));
> + return x;
> +}
> +
> +static inline __attribute_const__ u16 __arch_bitrev16(u16 x)
> +{
> + return __arch_bitrev32((u32)x) >> 16;
> +}
> +
> +static inline __attribute_const__ u8 __arch_bitrev8(u8 x)
> +{
> + return __arch_bitrev32((u32)x) >> 24;
> +}
> +
> +#endif
> +
> diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
> index 9532f8d..263c28c 100644
> --- a/arch/arm64/Kconfig
> +++ b/arch/arm64/Kconfig
> @@ -36,6 +36,7 @@ config ARM64
>   select HARDIRQS_SW_RESEND
>   select HAVE_ARCH_AUDITSYSCALL
>   select HAVE_ARCH_JUMP_LABEL
> + select HAVE_ARCH_BITREVERSE
>   select HAVE_ARCH_KGDB
>   select HAVE_ARCH_TRACEHOOK
>   select HAVE_BPF_JIT
> diff --git a/arch/arm64/include/asm/bitrev.h b/arch/arm64/include/asm/bitrev.h
> new file mode 100644
> index 000..5d24c11
> --- /dev/null
> +++ b/arch/arm64/include/asm/bitrev.h
> @@ -0,0 +1,21 @@
> +#ifndef __ASM_ARM_BITREV_H
> +#define __ASM_ARM_BITREV_H
> +
> +static inline __attribute_const__ u32 __arch_bitrev32(u32 x)
> +{
> + __asm__ ("rbit %w0, %w1" : "=r" (x) : "r" (x));
> + return x;
> +}
> +
> +static inline __attribute_const__ u16 __arch_bitrev16(u16 x)
> +{
> + return __arch_bitrev32((u32)x) >> 16;
> +}
> +
> +static inline __attribute_const__ u8 __arch_bitrev8(u8 x)
> +{
> + return __arch_bitrev32((u32)x) >> 24;
> +}
> +
> +#endif
> +
> diff --git a/include/linux/bitrev.h b/include/linux/bitrev.h
> index 7ffe03f..ef5b2bb 100644
> --- a/include/linux/bitrev.h
> +++ b/include/linux/bitrev.h
> @@ -3,6 +3,14 @@
>  
>  #include 
>  
> +#ifdef CONFIG_HAVE_ARCH_BITREVERSE
> +#include 
> +
> +#define bitrev32 __arch_bitrev32
> +#define bitrev16 __arch_bitrev16
> +#define bitrev8 __arch_bitrev8
> +
> +#else
>  extern u8 const byte_rev_table[256];

If this is done, the direct uses of byte_rev_table in
drivers/net/wireless/ath/carl9170/phy.c and
sound/usb/6fire/firmware.c should be converted too?


--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

Re: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction

2014-10-27 Thread Joe Perches 
On Mon, 2014-10-27 at 14:37 +0800, Wang, Yalin wrote:
 this change add CONFIG_HAVE_ARCH_BITREVERSE config option,
 so that we can use arm/arm64 rbit instruction to do bitrev operation
 by hardware.
 
 Signed-off-by: Yalin Wang yalin.w...@sonymobile.com
 ---
  arch/arm/Kconfig|  1 +
  arch/arm/include/asm/bitrev.h   | 21 +
  arch/arm64/Kconfig  |  1 +
  arch/arm64/include/asm/bitrev.h | 21 +
  include/linux/bitrev.h  |  9 +
  lib/Kconfig |  9 +
  lib/bitrev.c|  2 ++
  7 files changed, 64 insertions(+)
  create mode 100644 arch/arm/include/asm/bitrev.h
  create mode 100644 arch/arm64/include/asm/bitrev.h
 
 diff --git a/arch/arm/Kconfig b/arch/arm/Kconfig
 index 89c4b5c..426cbcc 100644
 --- a/arch/arm/Kconfig
 +++ b/arch/arm/Kconfig
 @@ -16,6 +16,7 @@ config ARM
   select DCACHE_WORD_ACCESS if HAVE_EFFICIENT_UNALIGNED_ACCESS
   select GENERIC_ALLOCATOR
   select GENERIC_ATOMIC64 if (CPU_V7M || CPU_V6 || !CPU_32v6K || !AEABI)
 + select HAVE_ARCH_BITREVERSE if (CPU_V7M || CPU_V7)
   select GENERIC_CLOCKEVENTS_BROADCAST if SMP
   select GENERIC_IDLE_POLL_SETUP
   select GENERIC_IRQ_PROBE
 diff --git a/arch/arm/include/asm/bitrev.h b/arch/arm/include/asm/bitrev.h
 new file mode 100644
 index 000..0df5866
 --- /dev/null
 +++ b/arch/arm/include/asm/bitrev.h
 @@ -0,0 +1,21 @@
 +#ifndef __ASM_ARM_BITREV_H
 +#define __ASM_ARM_BITREV_H
 +
 +static inline __attribute_const__ u32 __arch_bitrev32(u32 x)
 +{
 + __asm__ (rbit %0, %1 : =r (x) : r (x));
 + return x;
 +}
 +
 +static inline __attribute_const__ u16 __arch_bitrev16(u16 x)
 +{
 + return __arch_bitrev32((u32)x)  16;
 +}
 +
 +static inline __attribute_const__ u8 __arch_bitrev8(u8 x)
 +{
 + return __arch_bitrev32((u32)x)  24;
 +}
 +
 +#endif
 +
 diff --git a/arch/arm64/Kconfig b/arch/arm64/Kconfig
 index 9532f8d..263c28c 100644
 --- a/arch/arm64/Kconfig
 +++ b/arch/arm64/Kconfig
 @@ -36,6 +36,7 @@ config ARM64
   select HARDIRQS_SW_RESEND
   select HAVE_ARCH_AUDITSYSCALL
   select HAVE_ARCH_JUMP_LABEL
 + select HAVE_ARCH_BITREVERSE
   select HAVE_ARCH_KGDB
   select HAVE_ARCH_TRACEHOOK
   select HAVE_BPF_JIT
 diff --git a/arch/arm64/include/asm/bitrev.h b/arch/arm64/include/asm/bitrev.h
 new file mode 100644
 index 000..5d24c11
 --- /dev/null
 +++ b/arch/arm64/include/asm/bitrev.h
 @@ -0,0 +1,21 @@
 +#ifndef __ASM_ARM_BITREV_H
 +#define __ASM_ARM_BITREV_H
 +
 +static inline __attribute_const__ u32 __arch_bitrev32(u32 x)
 +{
 + __asm__ (rbit %w0, %w1 : =r (x) : r (x));
 + return x;
 +}
 +
 +static inline __attribute_const__ u16 __arch_bitrev16(u16 x)
 +{
 + return __arch_bitrev32((u32)x)  16;
 +}
 +
 +static inline __attribute_const__ u8 __arch_bitrev8(u8 x)
 +{
 + return __arch_bitrev32((u32)x)  24;
 +}
 +
 +#endif
 +
 diff --git a/include/linux/bitrev.h b/include/linux/bitrev.h
 index 7ffe03f..ef5b2bb 100644
 --- a/include/linux/bitrev.h
 +++ b/include/linux/bitrev.h
 @@ -3,6 +3,14 @@
  
  #include linux/types.h
  
 +#ifdef CONFIG_HAVE_ARCH_BITREVERSE
 +#include asm/bitrev.h
 +
 +#define bitrev32 __arch_bitrev32
 +#define bitrev16 __arch_bitrev16
 +#define bitrev8 __arch_bitrev8
 +
 +#else
  extern u8 const byte_rev_table[256];

If this is done, the direct uses of byte_rev_table in
drivers/net/wireless/ath/carl9170/phy.c and
sound/usb/6fire/firmware.c should be converted too?


--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/

RE: [RFC V2] arm/arm64:add CONFIG_HAVE_ARCH_BITREVERSE to support rbit instruction

2014-10-27 Thread Wang, Yalin 


 
 If this is done, the direct uses of byte_rev_table in
 drivers/net/wireless/ath/carl9170/phy.c and sound/usb/6fire/firmware.c
 should be converted too?
 

I think use bitrev8()  is safer than to use byte_rev_table[]  directly.

--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/