RE: [f2fs-dev] [PATCH] f2fs: remove unneeded code in punch_hole

2013-11-26 Thread Chao Yu
.com > Subject: Re: [f2fs-dev] [PATCH] f2fs: remove unneeded code in punch_hole > > Got it. > > But, with this patch, we can also remove the parameter, int mode, in > punch_hole(). > If no objection, I'll fix that in your patch. > Thanks, Right, we should remove it.

Re: [f2fs-dev] [PATCH] f2fs: remove unneeded code in punch_hole

2013-11-26 Thread Jaegeuk Kim
Got it. But, with this patch, we can also remove the parameter, int mode, in punch_hole(). If no objection, I'll fix that in your patch. Thanks, 2013-11-22 (금), 16:52 +0800, Chao Yu: > Because FALLOC_FL_PUNCH_HOLE flag must be ORed with FALLOC_FL_KEEP_SIZE > in fallocate, so we could remove the