RE: [linux-keystone] Re: [PATCH 01/13] clk: davinci - add Main PLL clock driver
>> -Original Message-
>> From: Linus Walleij [mailto:linus.wall...@linaro.org]
>> Sent: Thursday, September 27, 2012 9:20 AM
>> To: Karicheri, Muralidharan
>> Cc: mturque...@linaro.org; a...@arndb.de; a...@linux-foundation.org;
>> shawn@linaro.org; rob.herr...@calxeda.com; viresh.li...@gmail.com; linux-
>> ker...@vger.kernel.org; Nori, Sekhar; Hilman, Kevin; li...@arm.linux.org.uk;
>> davinci-
>> linux-open-sou...@linux.davincidsp.com;
>> linux-arm-ker...@lists.infradead.org; linux-
>> keyst...@list.ti.com - Linux developers for Keystone family of devices (May
>> contain non-
>> TIers); linux-c6x-...@linux-c6x.org; Chemparathy, Cyril
>> Subject: [linux-keystone] Re: [PATCH 01/13] clk: davinci - add Main PLL
>> clock driver
>>
>> On Wed, Sep 26, 2012 at 8:07 PM, Murali Karicheri
>> wrote:
>>
>> > +struct clk_davinci_pll_data {
>> > + /* physical addresses set by platform code */
>> > + u32 phy_pllm;
>> > + /* if PLL has a prediv register this should be non zero */
>> > + u32 phy_prediv;
>> > + /* if PLL has a postdiv register this should be non zero */
>> > + u32 phy_postdiv;
>> > + /* mapped addresses. should be initialized by */
>> > + void __iomem *pllm;
>> > + void __iomem *prediv;
>> > + void __iomem *postdiv;
>> > + u32 pllm_mask;
>> > + u32 prediv_mask;
>> > + u32 postdiv_mask;
>> > + u32 num;
>> > + /* framework flags */
>> > + u32 flags;
>> > + /* pll flags */
>> > + u32 pll_flags;
>> > + /* use this value for prediv */
>> > + u32 fixed_prediv;
>> > + /* multiply PLLM by this factor. By default most SOC set this to
>> > zero
>> > +* that translates to a multiplier of 1 and incrementer of 1.
>> > +* To override default, set this factor
>> > +*/
>> > + u32 pllm_multiplier;
>> > +};
>> > +
>>
>> No, that's not what I meant.
>>
>> I meant like this:
>>
>> /**
>> * struct clk_davinci_pll_data - struct holding the PLL data
>> * phy_pllm: physical addresses set by platform code
>> * phy_prediv: ...
>> (...)
>> */
>> struct clk_davinci_pll_data {
>> u32 phy_pllm;
>> u32 phy_prediv;
>> (...)
>> };
>>
Ok. Will do in the next revision.
Murali Karicheri
Software Design Engineer
>> Yours,
>> Linus Walleij
--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
RE: [linux-keystone] Re: [PATCH 01/13] clk: davinci - add Main PLL clock driver
-Original Message-
From: Linus Walleij [mailto:linus.wall...@linaro.org]
Sent: Thursday, September 27, 2012 9:20 AM
To: Karicheri, Muralidharan
Cc: mturque...@linaro.org; a...@arndb.de; a...@linux-foundation.org;
shawn@linaro.org; rob.herr...@calxeda.com; viresh.li...@gmail.com; linux-
ker...@vger.kernel.org; Nori, Sekhar; Hilman, Kevin; li...@arm.linux.org.uk;
davinci-
linux-open-sou...@linux.davincidsp.com;
linux-arm-ker...@lists.infradead.org; linux-
keyst...@list.ti.com - Linux developers for Keystone family of devices (May
contain non-
TIers); linux-c6x-...@linux-c6x.org; Chemparathy, Cyril
Subject: [linux-keystone] Re: [PATCH 01/13] clk: davinci - add Main PLL
clock driver
On Wed, Sep 26, 2012 at 8:07 PM, Murali Karicheri m-kariche...@ti.com
wrote:
+struct clk_davinci_pll_data {
+ /* physical addresses set by platform code */
+ u32 phy_pllm;
+ /* if PLL has a prediv register this should be non zero */
+ u32 phy_prediv;
+ /* if PLL has a postdiv register this should be non zero */
+ u32 phy_postdiv;
+ /* mapped addresses. should be initialized by */
+ void __iomem *pllm;
+ void __iomem *prediv;
+ void __iomem *postdiv;
+ u32 pllm_mask;
+ u32 prediv_mask;
+ u32 postdiv_mask;
+ u32 num;
+ /* framework flags */
+ u32 flags;
+ /* pll flags */
+ u32 pll_flags;
+ /* use this value for prediv */
+ u32 fixed_prediv;
+ /* multiply PLLM by this factor. By default most SOC set this to
zero
+* that translates to a multiplier of 1 and incrementer of 1.
+* To override default, set this factor
+*/
+ u32 pllm_multiplier;
+};
+
No, that's not what I meant.
I meant like this:
/**
* struct clk_davinci_pll_data - struct holding the PLL data
* phy_pllm: physical addresses set by platform code
* phy_prediv: ...
(...)
*/
struct clk_davinci_pll_data {
u32 phy_pllm;
u32 phy_prediv;
(...)
};
Ok. Will do in the next revision.
Murali Karicheri
Software Design Engineer
Yours,
Linus Walleij
--
To unsubscribe from this list: send the line unsubscribe linux-kernel in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
