RE: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-03-04 Thread Peter.Huewe
>> Yes, no problem. >> I'll create a patch without it - >> I'll make it this way that you can apply the conversion patch first >> and then the change. >Thanks! >Kent The new version of my patch was just sent - please apply this one first. Thanks, Peter

RE: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-03-04 Thread Peter.Huewe
Yes, no problem. I'll create a patch without it - I'll make it this way that you can apply the conversion patch first and then the change. Thanks! Kent The new version of my patch was just sent - please apply this one first. Thanks, Peter

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Peter Hüwe
> > I'd suggest not to. Mixing actual changes with cleanups is generally > > discouraged. > > Yes, please don't do this. Also because it makes it really > confusing for me to figure out whether something has been applied or > not and if I have the right people on the sign off. > > Peter,

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Kent Yoder
On Thu, Feb 28, 2013 at 4:32 PM, Jean Delvare wrote: > On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote: >> thanks for resending. > > You're welcome. > >> Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: >> > From: Shubhrajyoti Datta >> > >> > Convert the struct i2c_msg

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Jean Delvare
On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote: > thanks for resending. You're welcome. > Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: > > From: Shubhrajyoti Datta > > > > Convert the struct i2c_msg initialization to C99 format. This makes > > maintaining and editing

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Peter Hüwe
Hi, thanks for resending. Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: > From: Shubhrajyoti Datta > > Convert the struct i2c_msg initialization to C99 format. This makes > maintaining and editing the code simpler. Also helps once other fields > like transferred are added in

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Peter Hüwe
Hi, thanks for resending. Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: From: Shubhrajyoti Datta omaplinuxker...@gmail.com Convert the struct i2c_msg initialization to C99 format. This makes maintaining and editing the code simpler. Also helps once other fields like

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Jean Delvare
On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote: thanks for resending. You're welcome. Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: From: Shubhrajyoti Datta omaplinuxker...@gmail.com Convert the struct i2c_msg initialization to C99 format. This makes

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Kent Yoder
On Thu, Feb 28, 2013 at 4:32 PM, Jean Delvare kh...@linux-fr.org wrote: On Thu, 28 Feb 2013 23:12:51 +0100, Peter Hüwe wrote: thanks for resending. You're welcome. Am Donnerstag, 28. Februar 2013, 11:06:11 schrieb Jean Delvare: From: Shubhrajyoti Datta omaplinuxker...@gmail.com Convert

Re: [tpmdd-devel] [PATCH RESEND] char/tpm: Convert struct i2c_msg initialization to C99 format

2013-02-28 Thread Peter Hüwe
I'd suggest not to. Mixing actual changes with cleanups is generally discouraged. Yes, please don't do this. Also because it makes it really confusing for me to figure out whether something has been applied or not and if I have the right people on the sign off. Peter, can you