Re: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch
On Fri, Dec 21, 2018 at 10:43:09PM +, Greensky, James J wrote:
This commit does not apply cleanly due to other changes. Is there something I
can do to make it easier.
This line:
If (data->is_pipe) {
Must be changed to:
If (file->is_pipe) {
Indeed, I've resolved it the same.
Let me know if there is a more standard way of communicating cherry-picked
changes for inclusion.
Sending a mail to sta...@vger.kernel.org is pretty much the standard
way.
--
Thanks,
Sasha
Re: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch
On Fri, Dec 21, 2018 at 11:57:53AM +0100, Jinpu Wang wrote:
+cc Greg, stable
Greensky, James J 于2018年12月21日周五 上午11:48写道：
Commit d38d272592737ea88a20 ("perf tools: Synthesize GROUP_DESC feature in pipe
mode") broke the LT 4.14 branch when using event groups in pipe-mode.
# perf record -e '{cycles,instructions,branches}' -- sleep 4 | perf report
# To display the perf.data header info, please use --header/--header-only
options
#
Oxd7c [0x60]: failed to process type: 80
Error:
Failed to process sample
Commit a2015516c5c0be932a69 ("perf record: Synthesize features before events in pipe
mode") is the fix. Can we get this cherry-picked and applied?
I've queued d38d272592737ea88a20 for 4.14, thank you.
--
Thanks,
Sasha
RE: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch
This commit does not apply cleanly due to other changes. Is there something I
can do to make it easier.
This line:
If (data->is_pipe) {
Must be changed to:
If (file->is_pipe) {
Let me know if there is a more standard way of communicating cherry-picked
changes for inclusion.
-Original Message-
From: Jinpu Wang [mailto:jinpuw...@gmail.com]
Sent: Friday, December 21, 2018 2:58 AM
To: Greensky, James J ; Greg Kroah-Hartman
Cc: linux-kernel@vger.kernel.org; v3.14+, only the raid10 part
Subject: Re: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in
the LT 4.14 branch
+cc Greg, stable
Greensky, James J 于2018年12月21日周五 上午11:48写道：
>
> Commit d38d272592737ea88a20 ("perf tools: Synthesize GROUP_DESC feature in
> pipe mode") broke the LT 4.14 branch when using event groups in pipe-mode.
>
> # perf record -e '{cycles,instructions,branches}' -- sleep 4 | perf report
> # To display the perf.data header info, please use --header/--header-only
> options
> #
> Oxd7c [0x60]: failed to process type: 80
> Error:
> Failed to process sample
>
> Commit a2015516c5c0be932a69 ("perf record: Synthesize features before events
> in pipe mode") is the fix. Can we get this cherry-picked and applied?
>
Re: Fix "perf tools: Synthesize GROUP_DESC feature in pipe mode" in the LT 4.14 branch
+cc Greg, stable
Greensky, James J 于2018年12月21日周五 上午11:48写道：
>
> Commit d38d272592737ea88a20 ("perf tools: Synthesize GROUP_DESC feature in
> pipe mode") broke the LT 4.14 branch when using event groups in pipe-mode.
>
> # perf record -e '{cycles,instructions,branches}' -- sleep 4 | perf report
> # To display the perf.data header info, please use --header/--header-only
> options
> #
> Oxd7c [0x60]: failed to process type: 80
> Error:
> Failed to process sample
>
> Commit a2015516c5c0be932a69 ("perf record: Synthesize features before events
> in pipe mode") is the fix. Can we get this cherry-picked and applied?
>
