Re: RE: RE: [EXT] [PATCH] scsi: ufs-bsg: Fix runtime PM imbalance on error

2020-05-23 Thread dinghao . liu
> Hi, Dinghao > > > Thank you for your advice! Moving original pm_runtime_put_sync() to after > > "out" label will influence an error path branched from > > ups_bsg_verify_query_size(). So I think changing "goto out" to "break" is a > > good > > idea. But in this case we may execute an extra > >

RE: RE: [EXT] [PATCH] scsi: ufs-bsg: Fix runtime PM imbalance on error

2020-05-22 Thread Bean Huo (beanhuo)
Hi, Dinghao > Thank you for your advice! Moving original pm_runtime_put_sync() to after > "out" label will influence an error path branched from > ups_bsg_verify_query_size(). So I think changing "goto out" to "break" is a > good > idea. But in this case we may execute an extra >

Re: RE: [EXT] [PATCH] scsi: ufs-bsg: Fix runtime PM imbalance on error

2020-05-22 Thread dinghao . liu
Hi, Bean Thank you for your advice! Moving original pm_runtime_put_sync() to after "out" label will influence an error path branched from ups_bsg_verify_query_size(). So I think changing "goto out" to "break" is a good idea. But in this case we may execute an extra sg_copy_from_buffer() and an