RE: linux-next: build failure after merge of the rpmsg tree
Hi, Changes in remoteproc have been introduced to associate dedicated dma coherent memory pool to each virtio device. It is needed when we have several virtio devices for which buffers can't be allocated from the same memory region. Patch introduces support in both ways: - memory region declared thanks to reserved memory and associated thanks to of_reserved_mem_device_init_by_idx(): mainly used for regions located in DDR. - memory region specified in rproc driver itself and defined as dma coherent thanks to dma_declare_coherent_memory(): These regions are generally located in coprocessor/SoC internal memories and declared in different ways by the different rproc drivers (regs in DT, hard coded values in drivers...). For me, dma_declare_coherent_memory based solution is there to allow a smooth transition from current rproc drivers implementations to a cleaner and unified one based on reserved memory declaration. Regards, Loic > -Original Message- > From: Christoph Hellwig > Sent: vendredi 22 février 2019 13:51 > To: Stephen Rothwell > Cc: Bjorn Andersson ; Christoph Hellwig > ; Linux Next Mailing List ; Linux > Kernel Mailing List ; Loic PALLARDY > > Subject: Re: linux-next: build failure after merge of the rpmsg tree > > FYI, can I please get an explanation for the remoteproc changes? > > We really should avoid adding new callers of > dma_declare_coherent_memory, > which is a rather badly designed interface.
Re: linux-next: build failure after merge of the rpmsg tree
FYI, can I please get an explanation for the remoteproc changes? We really should avoid adding new callers of dma_declare_coherent_memory, which is a rather badly designed interface.
Re: linux-next: build failure after merge of the rpmsg tree
On Wed 25 Apr 20:33 PDT 2018, Stephen Rothwell wrote:
> Hi Bjorn,
>
> After merging the rpmsg tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/remoteproc/remoteproc_core.c: In function 'rproc_handle_devmem':
> drivers/remoteproc/remoteproc_core.c:557:8: error: implicit declaration of
> function 'iommu_map_sync'; did you mean 'iommu_map_sg'?
> [-Werror=implicit-function-declaration]
> ret = iommu_map_sync(rproc->domain, rsc->da,
> ^~
> iommu_map_sg
> drivers/remoteproc/remoteproc_core.c: In function 'rproc_resource_cleanup':
> drivers/remoteproc/remoteproc_core.c:845:14: error: implicit declaration of
> function 'iommu_unmap_sync'; did you mean 'iommu_unmap_fast'?
> [-Werror=implicit-function-declaration]
>unmapped = iommu_unmap_sync(rproc->domain, entry->da,
> ^~~~
> iommu_unmap_fast
>
> Caused by commit
>
> aace25b18cbd ("remoteproc: Use sychronized interface of the IOMMU-API")
>
> I suspect that part of the commit is missing ...
>
Sorry about that, now I've actually pushed the branch with this commit
removed again.
> I have use the rpmsg tree from next-20180424 for today.
>
Thanks, should be good tomorrow again!
Regards,
Bjorn
Re: linux-next: build failure after merge of the rpmsg tree
On Wed 25 Apr 20:33 PDT 2018, Stephen Rothwell wrote:
> Hi Bjorn,
>
> After merging the rpmsg tree, today's linux-next build (arm
> multi_v7_defconfig) failed like this:
>
> drivers/remoteproc/remoteproc_core.c: In function 'rproc_handle_devmem':
> drivers/remoteproc/remoteproc_core.c:557:8: error: implicit declaration of
> function 'iommu_map_sync'; did you mean 'iommu_map_sg'?
> [-Werror=implicit-function-declaration]
> ret = iommu_map_sync(rproc->domain, rsc->da,
> ^~
> iommu_map_sg
> drivers/remoteproc/remoteproc_core.c: In function 'rproc_resource_cleanup':
> drivers/remoteproc/remoteproc_core.c:845:14: error: implicit declaration of
> function 'iommu_unmap_sync'; did you mean 'iommu_unmap_fast'?
> [-Werror=implicit-function-declaration]
>unmapped = iommu_unmap_sync(rproc->domain, entry->da,
> ^~~~
> iommu_unmap_fast
>
> Caused by commit
>
> aace25b18cbd ("remoteproc: Use sychronized interface of the IOMMU-API")
>
> I suspect that part of the commit is missing ...
>
Sorry about that, now I've actually pushed the branch with this commit
removed again.
> I have use the rpmsg tree from next-20180424 for today.
>
Thanks, should be good tomorrow again!
Regards,
Bjorn
Re: linux-next: build failure after merge of the rpmsg tree
On Wed 30 Aug 23:54 PDT 2017, Stephen Rothwell wrote:
> Hi Bjorn,
>
> After merging the rpmsg tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "qcom_glink_native_probe" [drivers/rpmsg/qcom_glink_rpm.ko] undefined!
> ERROR: "qcom_glink_native_remove" [drivers/rpmsg/qcom_glink_rpm.ko] undefined!
>
> Maybe caused by commit
>
> 6799c434c27b ("rpmsg: glink: Split rpm_probe to reuse the common code")
>
Thanks for letting me know Stephen, those functions should have been
exported and I've corrected it.
> I have used the rpmsg tree from next-20170829 for today.
>
Thanks,
Bjorn
Re: linux-next: build failure after merge of the rpmsg tree
On Wed 30 Aug 23:54 PDT 2017, Stephen Rothwell wrote:
> Hi Bjorn,
>
> After merging the rpmsg tree, today's linux-next build (x86_64
> allmodconfig) failed like this:
>
> ERROR: "qcom_glink_native_probe" [drivers/rpmsg/qcom_glink_rpm.ko] undefined!
> ERROR: "qcom_glink_native_remove" [drivers/rpmsg/qcom_glink_rpm.ko] undefined!
>
> Maybe caused by commit
>
> 6799c434c27b ("rpmsg: glink: Split rpm_probe to reuse the common code")
>
Thanks for letting me know Stephen, those functions should have been
exported and I've corrected it.
> I have used the rpmsg tree from next-20170829 for today.
>
Thanks,
Bjorn
