Re: RFC: callchain showing same entry as hist_entry

2016-08-18 Thread Namhyung Kim
Hi Arnaldo, On Tue, Aug 16, 2016 at 04:21:31PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 16, 2016 at 12:46:57PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Aug 17, 2016 at 12:41:18AM +0900, Namhyung Kim escreveu: > > > Hmm.. if so, wouldn't it be better skipping the first call

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 16, 2016 at 12:46:57PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 17, 2016 at 12:41:18AM +0900, Namhyung Kim escreveu: > > Hmm.. if so, wouldn't it be better skipping the first callchain entry > > when the user-given sort key contains "sym" too (not only when it > > starts

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Namhyung Kim
On Tue, Aug 16, 2016 at 12:32:44PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu: > > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu: > > > Did you run 'perf report -s sym --stdio'? It seems that current code >

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 17, 2016 at 12:41:18AM +0900, Namhyung Kim escreveu: > On Tue, Aug 16, 2016 at 12:32:44PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu: > > > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu: > > >

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 16, 2016 at 12:31:43PM -0300, Arnaldo Carvalho de Melo escreveu: > Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu: > > Did you run 'perf report -s sym --stdio'? It seems that current code > > already works as sane.. Do you want to make it work for the default sort > >

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Arnaldo Carvalho de Melo
Em Wed, Aug 17, 2016 at 12:23:55AM +0900, Namhyung Kim escreveu: > On Tue, Aug 16, 2016 at 12:08:03PM -0300, Arnaldo Carvalho de Melo wrote: > > Em Tue, Aug 16, 2016 at 11:55:11PM +0900, Namhyung Kim escreveu: > > > > > > On Tue, Aug 16, 2016 at 11:36:28AM -0300, Arnaldo Carvalho de Melo wrote: >

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Namhyung Kim
On Tue, Aug 16, 2016 at 12:08:03PM -0300, Arnaldo Carvalho de Melo wrote: > Em Tue, Aug 16, 2016 at 11:55:11PM +0900, Namhyung Kim escreveu: > > Hi Arnaldo, > > > > On Tue, Aug 16, 2016 at 11:36:28AM -0300, Arnaldo Carvalho de Melo wrote: > > > Hi Namhyung, Jiri, > > > > > > please take a look

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Arnaldo Carvalho de Melo
Em Tue, Aug 16, 2016 at 11:55:11PM +0900, Namhyung Kim escreveu: > Hi Arnaldo, > > On Tue, Aug 16, 2016 at 11:36:28AM -0300, Arnaldo Carvalho de Melo wrote: > > Hi Namhyung, Jiri, > > > > please take a look at the patch below, and Ack if possible, it > > is a problem introduced in: > > > >

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Namhyung Kim
Hi Arnaldo, On Tue, Aug 16, 2016 at 11:36:28AM -0300, Arnaldo Carvalho de Melo wrote: > Hi Namhyung, Jiri, > > please take a look at the patch below, and Ack if possible, it > is a problem introduced in: > > cfaa154b2335 ("perf tools: Get rid of obsolete hist_entry__sort_list") > > That

Re: RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Jiri Olsa
On Tue, Aug 16, 2016 at 11:36:28AM -0300, Arnaldo Carvalho de Melo wrote: > Hi Namhyung, Jiri, > > please take a look at the patch below, and Ack if possible, it > is a problem introduced in: > > cfaa154b2335 ("perf tools: Get rid of obsolete hist_entry__sort_list") > > That is not equiv

RFC: callchain showing same entry as hist_entry

2016-08-16 Thread Arnaldo Carvalho de Melo
Hi Namhyung, Jiri, please take a look at the patch below, and Ack if possible, it is a problem introduced in: cfaa154b2335 ("perf tools: Get rid of obsolete hist_entry__sort_list") That is not equivalent to the code that was there and results in having the same entry as the first entry