Re: Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-06-20 Thread dinghao . liu
> >> > >> Why noidle? > >> > > > > _noidle is enough for fixing this bug. _sync may suspend > > the device beyond expectation. > > In that case, then the other instance you are fixing with this patch is > not correct. > Fine. I will fix this soon. Regards, Dinghao

Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-06-20 Thread Jon Hunter
On 19/06/2020 02:59, dinghao@zju.edu.cn wrote: >> >> Why noidle? >> > > _noidle is enough for fixing this bug. _sync may suspend > the device beyond expectation. In that case, then the other instance you are fixing with this patch is not correct. Jon -- nvpublic

Re: Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-06-18 Thread dinghao . liu
> > Why noidle? > _noidle is enough for fixing this bug. _sync may suspend the device beyond expectation. Regards, Dinghao

Re: [PATCH] [v3] dmaengine: tegra210-adma: Fix runtime PM imbalance on error

2020-06-18 Thread Jon Hunter
On 18/06/2020 11:57, Dinghao Liu wrote: > pm_runtime_get_sync() increments the runtime PM usage counter even > when it returns an error code. Thus a pairing decrement is needed on > the error handling path to keep the counter balanced. > > Signed-off-by: Dinghao Liu > --- > > Changelog: > >