Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-22 Thread Simon Horman
On Wed, Aug 21, 2013 at 06:02:45PM +0800, liujunliang_ljl wrote: > Dear Ben : > > 1, please give me email address of David Miller, and Thanks a > lot. You can find him in the MAINTAINERS file. He should also show up if you use scripts/get_maintainer.pl -- To unsubscribe from this

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-22 Thread Simon Horman
On Wed, Aug 21, 2013 at 06:02:45PM +0800, liujunliang_ljl wrote: Dear Ben : 1, please give me email address of David Miller, and Thanks a lot. You can find him in the MAINTAINERS file. He should also show up if you use scripts/get_maintainer.pl -- To unsubscribe from this

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread Francois Romieu
sr_skb->len = len; > + sr_skb->data = skb->data + 3; > + sr_skb->tail = skb->data + len; > + sr_skb->truesize = len + sizeof(struct sk_buff); > + usbnet_skb_return(dev, sr_skb)

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 06:06:02PM +0800, liujunliang_ljl wrote: > Dear Francois Romieu : > > 1, all the format problems have been fixed > > 2, sr9700.h registers definition is re-written > > 3, Thanks for your detail checking and I have beed > scripts/checkpatch.pl the

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread Joe Perches
On Wed, 2013-08-21 at 18:07 +0800, liujunliang_ljl wrote: > Thanks a lot and I have been fixed all the problems mentioned > above. please check the following patch and thanks again. Just trivial comments below: > diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c []

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
lt; 6) +#defineTXC_USBS_RXFAULT(1 << 7) +/* USB Control register */ +#define USBC 0xF4 +#define USBC_EP3NAK (1 << 4) +#define USBC_EP3ACK (1 << 5) + +/* Register access commands and

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
TXC_USBS_EP1RDY (1 << 5) +#defineTXC_USBS_SUSFLAG(1 << 6) +#defineTXC_USBS_RXFAULT(1 << 7) +/* USB Control register */ +#define USBC 0xF4 +#define USBC_EP3NAK (1 <<

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
TXC_USBS_TXC2 (1 << 2) +#defineTXC_USBS_EP1RDY (1 << 5) +#defineTXC_USBS_SUSFLAG(1 << 6) +#defineTXC_USBS_RXFAULT(1 << 7) +/* USB Control register */ +#define USBC 0xF4 +#define

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
7 /* 3bytes header + 4crc tail */ + +#endif /* _SR9700_H */ 2013-08-21 liujunliang_ljl 发件人: Ben Hutchings 发送时间: 2013-08-20 21:36:50 收件人: liujunliang_ljl 抄送: gregkh; linux-usb; netdev; linux-kernel; sunhecheng 主题: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
*/ + +#endif /* _SR9700_H */ 2013-08-21 liujunliang_ljl 发件人: Francois Romieu 发送时间: 2013-08-21 04:46:12 收件人: liujunliang_ljl 抄送: gregkh; sunhecheng; linux-usb; netdev; linux-kernel 主题: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread liujunliang_ljl
04:58:27 收件人: Francois Romieu 抄送: liujunliang_ljl; gregkh; sunhecheng; linux-usb; netdev; linux-kernel 主题: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel On Tue, 2013-08-20 at 22:46 +0200, Francois Romieu wrote: liujunliang_ljl liujunliang_

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread Joe Perches
On Wed, 2013-08-21 at 18:07 +0800, liujunliang_ljl wrote: Thanks a lot and I have been fixed all the problems mentioned above. please check the following patch and thanks again. Just trivial comments below: diff --git a/drivers/net/usb/sr9700.c b/drivers/net/usb/sr9700.c []

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread Greg KH
On Wed, Aug 21, 2013 at 06:06:02PM +0800, liujunliang_ljl wrote: Dear Francois Romieu : 1, all the format problems have been fixed 2, sr9700.h registers definition is re-written 3, Thanks for your detail checking and I have beed scripts/checkpatch.pl the patch

Re: Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700 DeviceDriver into the Linux Kernel

2013-08-21 Thread Francois Romieu
, + .disable_hub_initiated_lpm = 1, +}; Please line things up (see my first review). [...] Francois Romieu ?? 2013-08-21 04:46:12 liujunliang_ljl ?? gregkh; sunhecheng; linux-usb; netdev; linux-kernel ?? Re: [PATCH-SR9700] Merge USB 1.1 Ethernet Adapter SR9700