Re: Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Satyam Sharma
On 4/24/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: On Tue, 24 Apr 2007, Satyam Sharma wrote: > If I remember right, a very similar patchset was recently submitted > that Andrew merged in -mm(?). It also renamed memclear_highpage_flush > to something like zero_user_page (though I wonder how

Re: Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Christoph Lameter
On Tue, 24 Apr 2007, Satyam Sharma wrote: > On 4/24/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: > > There are a series of open coded reimplementation of memclear_highpage_flush > > all over the page cache code. Call memclear_highpage_flush in those > > locations. > > Consolidates code and

Re: Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Andrew Morton
On Tue, 24 Apr 2007 07:49:45 +0530 "Satyam Sharma" <[EMAIL PROTECTED]> wrote: > On 4/24/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: > > There are a series of open coded reimplementation of memclear_highpage_flush > > all over the page cache code. Call memclear_highpage_flush in those > >

Re: Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Satyam Sharma
On 4/24/07, Christoph Lameter <[EMAIL PROTECTED]> wrote: There are a series of open coded reimplementation of memclear_highpage_flush all over the page cache code. Call memclear_highpage_flush in those locations. Consolidates code and eases maintenance. If I remember right, a very similar

Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Christoph Lameter
There are a series of open coded reimplementation of memclear_highpage_flush all over the page cache code. Call memclear_highpage_flush in those locations. Consolidates code and eases maintenance. Signed-off-by: Christoph Lameter <[EMAIL PROTECTED]> --- fs/buffer.c | 77

Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Christoph Lameter
There are a series of open coded reimplementation of memclear_highpage_flush all over the page cache code. Call memclear_highpage_flush in those locations. Consolidates code and eases maintenance. Signed-off-by: Christoph Lameter [EMAIL PROTECTED] --- fs/buffer.c | 77

Re: Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Satyam Sharma
On 4/24/07, Christoph Lameter [EMAIL PROTECTED] wrote: There are a series of open coded reimplementation of memclear_highpage_flush all over the page cache code. Call memclear_highpage_flush in those locations. Consolidates code and eases maintenance. If I remember right, a very similar

Re: Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Andrew Morton
On Tue, 24 Apr 2007 07:49:45 +0530 Satyam Sharma [EMAIL PROTECTED] wrote: On 4/24/07, Christoph Lameter [EMAIL PROTECTED] wrote: There are a series of open coded reimplementation of memclear_highpage_flush all over the page cache code. Call memclear_highpage_flush in those locations.

Re: Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Christoph Lameter
On Tue, 24 Apr 2007, Satyam Sharma wrote: On 4/24/07, Christoph Lameter [EMAIL PROTECTED] wrote: There are a series of open coded reimplementation of memclear_highpage_flush all over the page cache code. Call memclear_highpage_flush in those locations. Consolidates code and eases

Re: Remove open coded implementations of memclear_highpage flush

2007-04-23 Thread Satyam Sharma
On 4/24/07, Christoph Lameter [EMAIL PROTECTED] wrote: On Tue, 24 Apr 2007, Satyam Sharma wrote: If I remember right, a very similar patchset was recently submitted that Andrew merged in -mm(?). It also renamed memclear_highpage_flush to something like zero_user_page (though I wonder how good