Re: SLUB + UML : WARNING: at mm/page_alloc.c:2386

2013-03-15 Thread Toralf Förster
On 03/15/2013 12:10 AM, richard -rw- weinberger wrote: > Time to look at UML's __get_user(). Just FWIW the "memdup_user:" debug-patch-line is not only triggered by trinity. It happens even if I regularly boot a UML guest (stable Gentoo x86): $ /usr/local/bin/linux-v3.9-rc2-292-ga2362d2 earlypr

Re: SLUB + UML : WARNING: at mm/page_alloc.c:2386

2013-03-14 Thread richard -rw- weinberger
On Thu, Mar 14, 2013 at 10:24 PM, Toralf Förster wrote: > On 03/14/2013 10:21 PM, Dave Jones wrote: >> hah, strndup_user taking a signed long instead of a size_t as it's length >> arg. >> >> either it needs to change, or it needs an explicit check for < 1 >> >> I wonder how many other paths make

Re: SLUB + UML : WARNING: at mm/page_alloc.c:2386

2013-03-14 Thread Toralf Förster
On 03/14/2013 10:21 PM, Dave Jones wrote: > hah, strndup_user taking a signed long instead of a size_t as it's length arg. > > either it needs to change, or it needs an explicit check for < 1 > > I wonder how many other paths make it possible to pass negative numbers here. just for the statistic

Re: SLUB + UML : WARNING: at mm/page_alloc.c:2386

2013-03-14 Thread Dave Jones
On Thu, Mar 14, 2013 at 09:58:31PM +0100, Toralf Förster wrote: > On 03/14/2013 09:51 PM, richard -rw- weinberger wrote: > > Can you please re-run with the attached patch. > > I'm wondering how much memory is requested. > >>From reading the source I'd say it must be less than PAGE_SIZE. > > Bu

Re: SLUB + UML : WARNING: at mm/page_alloc.c:2386

2013-03-14 Thread Toralf Förster
On 03/14/2013 09:51 PM, richard -rw- weinberger wrote: > Can you please re-run with the attached patch. > I'm wondering how much memory is requested. >>From reading the source I'd say it must be less than PAGE_SIZE. > But such a small allocation would not trigger the WARN_ON()... 2013-03-14T21:56