Select on now-gone Kconfig option STOP_MACHINE

2016-01-25 Thread Andreas Ziegler 
Hi Chris,

your commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with
access through GGTT on Braswell") added a select to STOP_MACHINE to the
DRM_I915 Kconfig option.

In 4.5-rc1, your commit 86fffe4a61dd ("kernel: remove stop_machine()
Kconfig dependency") then removed STOP_MACHINE entirely, but didn't
delete the select from drivers/gpu/drm/i915/Kconfig.

Should I prepare a simple patch which removes the select?

Best regards,

Andreas

Re: Select on now-gone Kconfig option STOP_MACHINE

2016-01-25 Thread Chris Wilson 
On Mon, Jan 25, 2016 at 11:52:04AM +0100, Andreas Ziegler wrote:
> Hi Chris,
> 
> your commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with
> access through GGTT on Braswell") added a select to STOP_MACHINE to the
> DRM_I915 Kconfig option.
> 
> In 4.5-rc1, your commit 86fffe4a61dd ("kernel: remove stop_machine()
> Kconfig dependency") then removed STOP_MACHINE entirely, but didn't
> delete the select from drivers/gpu/drm/i915/Kconfig.
> 
> Should I prepare a simple patch which removes the select?

Yes, it was intended to be removed on merging.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Re: Select on now-gone Kconfig option STOP_MACHINE

2016-01-25 Thread Chris Wilson 
On Mon, Jan 25, 2016 at 11:52:04AM +0100, Andreas Ziegler wrote:
> Hi Chris,
> 
> your commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with
> access through GGTT on Braswell") added a select to STOP_MACHINE to the
> DRM_I915 Kconfig option.
> 
> In 4.5-rc1, your commit 86fffe4a61dd ("kernel: remove stop_machine()
> Kconfig dependency") then removed STOP_MACHINE entirely, but didn't
> delete the select from drivers/gpu/drm/i915/Kconfig.
> 
> Should I prepare a simple patch which removes the select?

Yes, it was intended to be removed on merging.
-Chris

-- 
Chris Wilson, Intel Open Source Technology Centre

Select on now-gone Kconfig option STOP_MACHINE

2016-01-25 Thread Andreas Ziegler 
Hi Chris,

your commit 5bab6f60cb4d ("drm/i915: Serialise updates to GGTT with
access through GGTT on Braswell") added a select to STOP_MACHINE to the
DRM_I915 Kconfig option.

In 4.5-rc1, your commit 86fffe4a61dd ("kernel: remove stop_machine()
Kconfig dependency") then removed STOP_MACHINE entirely, but didn't
delete the select from drivers/gpu/drm/i915/Kconfig.

Should I prepare a simple patch which removes the select?

Best regards,

Andreas