On Thu, 8 Sep 2005, Linus Torvalds wrote:
>
> (You might even remove the #ifdef inside the function by then, since "ch"
> being a constant zero will make 90% of it go away anyway).
Sadly, the remaining part checks "port->sysrq", which doesn't even exist
unless CONFIG_SERIAL_CORE_CONSOLE is
On Thu, Sep 08, 2005 at 02:22:37PM -0700, Linus Torvalds wrote:
> On Thu, 8 Sep 2005, David S. Miller wrote:
> > Ok, I'll revert the patch and fix the sunsab.c driver as
> > Russell indicated. So much for type checking...
>
> Actually, I think there's a simpler fix. Instead of reverting, how
From: Linus Torvalds <[EMAIL PROTECTED]>
Date: Thu, 8 Sep 2005 14:22:37 -0700 (PDT)
> On Thu, 8 Sep 2005, David S. Miller wrote:
> >
> > Ok, I'll revert the patch and fix the sunsab.c driver as
> > Russell indicated. So much for type checking...
>
> Actually, I think there's a simpler fix.
On Thu, 8 Sep 2005, David S. Miller wrote:
>
> Ok, I'll revert the patch and fix the sunsab.c driver as
> Russell indicated. So much for type checking...
Actually, I think there's a simpler fix. Instead of reverting, how about
something like this?
(You might even remove the #ifdef inside
From: Linus Torvalds <[EMAIL PROTECTED]>
Date: Thu, 8 Sep 2005 13:39:35 -0700 (PDT)
> So it's certainly a valid optimization to know that the arguments aren't
> even evaluated, and thus it's sometimes really wrong to change a macro
> into an inline function.
Ok, I'll revert the patch and fix the
On Thu, 8 Sep 2005, David S. Miller wrote:
>
> > the "regs" argument may not exist in the parent context in the
> > !SUPPORT_SYSRQ case.
>
> Then pass in a NULL in the ARM serial drivers instead of this ugly
> dependency upon the macro not using the argument.
No, the ARM driver -does- want to
On Thu, Sep 08, 2005 at 01:13:58PM -0700, David S. Miller wrote:
> From: Linus Torvalds <[EMAIL PROTECTED]>
> Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT)
>
> > Mistakes happen, and the way you fix them is not to pull a tantrum, but
> > tell people that they are idiots and they broke something,
From: Russell King <[EMAIL PROTECTED]>
Date: Thu, 8 Sep 2005 21:22:36 +0100
> the "regs" argument may not exist in the parent context in the
> !SUPPORT_SYSRQ case.
Then pass in a NULL in the ARM serial drivers instead of this ugly
dependency upon the macro not using the argument.
-
To
On Thu, Sep 08, 2005 at 01:13:58PM -0700, David S. Miller wrote:
> From: Linus Torvalds <[EMAIL PROTECTED]>
> Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT)
>
> > Mistakes happen, and the way you fix them is not to pull a tantrum, but
> > tell people that they are idiots and they broke something,
From: Linus Torvalds <[EMAIL PROTECTED]>
Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT)
> Mistakes happen, and the way you fix them is not to pull a tantrum, but
> tell people that they are idiots and they broke something, and get them to
> fix it instead.
In all this noise I still haven't seen
Russell King <[EMAIL PROTECTED]> wrote:
>
> On Thu, Sep 08, 2005 at 05:38:43PM +0100, Alan Cox wrote:
> > On Iau, 2005-09-08 at 16:52 +0100, Russell King wrote:
> > > I notice DaveM's taken over serial maintainership. Please arrange for
> > > serial patches t
On Thu, Sep 08, 2005 at 05:38:43PM +0100, Alan Cox wrote:
> On Iau, 2005-09-08 at 16:52 +0100, Russell King wrote:
> > I notice DaveM's taken over serial maintainership. Please arrange for
> > serial patches to be sent to davem in future, thanks. (All ARM serial
> &g
On Thu, 8 Sep 2005, Alan Cox wrote:
>
> On Iau, 2005-09-08 at 16:52 +0100, Russell King wrote:
> > I notice DaveM's taken over serial maintainership. Please arrange for
> > serial patches to be sent to davem in future, thanks. (All ARM serial
> > drivers are broken as
On Iau, 2005-09-08 at 16:52 +0100, Russell King wrote:
> I notice DaveM's taken over serial maintainership. Please arrange for
> serial patches to be sent to davem in future, thanks. (All ARM serial
> drivers are broken as of Tuesday.)
>
> I might take a different view if
I notice DaveM's taken over serial maintainership. Please arrange for
serial patches to be sent to davem in future, thanks. (All ARM serial
drivers are broken as of Tuesday.)
I might take a different view if I at least had a curtious CC: of the
patch, which I had already asked akpm to reject
I notice DaveM's taken over serial maintainership. Please arrange for
serial patches to be sent to davem in future, thanks. (All ARM serial
drivers are broken as of Tuesday.)
I might take a different view if I at least had a curtious CC: of the
patch, which I had already asked akpm to reject
On Iau, 2005-09-08 at 16:52 +0100, Russell King wrote:
I notice DaveM's taken over serial maintainership. Please arrange for
serial patches to be sent to davem in future, thanks. (All ARM serial
drivers are broken as of Tuesday.)
I might take a different view if I at least had a curtious
On Thu, 8 Sep 2005, Alan Cox wrote:
On Iau, 2005-09-08 at 16:52 +0100, Russell King wrote:
I notice DaveM's taken over serial maintainership. Please arrange for
serial patches to be sent to davem in future, thanks. (All ARM serial
drivers are broken as of Tuesday.)
I might take
On Thu, Sep 08, 2005 at 05:38:43PM +0100, Alan Cox wrote:
On Iau, 2005-09-08 at 16:52 +0100, Russell King wrote:
I notice DaveM's taken over serial maintainership. Please arrange for
serial patches to be sent to davem in future, thanks. (All ARM serial
drivers are broken as of Tuesday
Russell King [EMAIL PROTECTED] wrote:
On Thu, Sep 08, 2005 at 05:38:43PM +0100, Alan Cox wrote:
On Iau, 2005-09-08 at 16:52 +0100, Russell King wrote:
I notice DaveM's taken over serial maintainership. Please arrange for
serial patches to be sent to davem in future, thanks. (All ARM
From: Linus Torvalds [EMAIL PROTECTED]
Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT)
Mistakes happen, and the way you fix them is not to pull a tantrum, but
tell people that they are idiots and they broke something, and get them to
fix it instead.
In all this noise I still haven't seen what is
On Thu, Sep 08, 2005 at 01:13:58PM -0700, David S. Miller wrote:
From: Linus Torvalds [EMAIL PROTECTED]
Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT)
Mistakes happen, and the way you fix them is not to pull a tantrum, but
tell people that they are idiots and they broke something, and get
From: Russell King [EMAIL PROTECTED]
Date: Thu, 8 Sep 2005 21:22:36 +0100
the regs argument may not exist in the parent context in the
!SUPPORT_SYSRQ case.
Then pass in a NULL in the ARM serial drivers instead of this ugly
dependency upon the macro not using the argument.
-
To unsubscribe from
On Thu, Sep 08, 2005 at 01:13:58PM -0700, David S. Miller wrote:
From: Linus Torvalds [EMAIL PROTECTED]
Date: Thu, 8 Sep 2005 09:27:56 -0700 (PDT)
Mistakes happen, and the way you fix them is not to pull a tantrum, but
tell people that they are idiots and they broke something, and get
On Thu, 8 Sep 2005, David S. Miller wrote:
the regs argument may not exist in the parent context in the
!SUPPORT_SYSRQ case.
Then pass in a NULL in the ARM serial drivers instead of this ugly
dependency upon the macro not using the argument.
No, the ARM driver -does- want to pass in
From: Linus Torvalds [EMAIL PROTECTED]
Date: Thu, 8 Sep 2005 13:39:35 -0700 (PDT)
So it's certainly a valid optimization to know that the arguments aren't
even evaluated, and thus it's sometimes really wrong to change a macro
into an inline function.
Ok, I'll revert the patch and fix the
On Thu, 8 Sep 2005, David S. Miller wrote:
Ok, I'll revert the patch and fix the sunsab.c driver as
Russell indicated. So much for type checking...
Actually, I think there's a simpler fix. Instead of reverting, how about
something like this?
(You might even remove the #ifdef inside the
From: Linus Torvalds [EMAIL PROTECTED]
Date: Thu, 8 Sep 2005 14:22:37 -0700 (PDT)
On Thu, 8 Sep 2005, David S. Miller wrote:
Ok, I'll revert the patch and fix the sunsab.c driver as
Russell indicated. So much for type checking...
Actually, I think there's a simpler fix. Instead of
On Thu, Sep 08, 2005 at 02:22:37PM -0700, Linus Torvalds wrote:
On Thu, 8 Sep 2005, David S. Miller wrote:
Ok, I'll revert the patch and fix the sunsab.c driver as
Russell indicated. So much for type checking...
Actually, I think there's a simpler fix. Instead of reverting, how about
On Thu, 8 Sep 2005, Linus Torvalds wrote:
(You might even remove the #ifdef inside the function by then, since ch
being a constant zero will make 90% of it go away anyway).
Sadly, the remaining part checks port-sysrq, which doesn't even exist
unless CONFIG_SERIAL_CORE_CONSOLE is set, so
30 matches
Mail list logo
