Re: Should this_cpu_read() be volatile?

2018-12-11 Thread Nadav Amit
> On Dec 10, 2018, at 12:55 AM, Peter Zijlstra wrote: > > On Sun, Dec 09, 2018 at 04:57:43PM -0800, Nadav Amit wrote: >>> On Dec 8, 2018, at 2:52 AM, Peter Zijlstra wrote: > >>> My patch proposed here: >>> >>> https://marc.info/?l=linux-mm=154409548410209 >>> >>> would actually fix that one

Re: Should this_cpu_read() be volatile?

2018-12-10 Thread Peter Zijlstra
On Sun, Dec 09, 2018 at 04:57:43PM -0800, Nadav Amit wrote: > > On Dec 8, 2018, at 2:52 AM, Peter Zijlstra wrote: > > My patch proposed here: > > > > https://marc.info/?l=linux-mm=154409548410209 > > > > would actually fix that one I think, preempt_count() uses > > raw_cpu_read_4() which will

Re: Should this_cpu_read() be volatile?

2018-12-09 Thread Nadav Amit
> On Dec 8, 2018, at 2:52 AM, Peter Zijlstra wrote: > > On Fri, Dec 07, 2018 at 04:40:52PM -0800, Nadav Amit wrote: > >>> I'm actually having difficulty finding the this_cpu_read() in any of the >>> functions you mention, so I cannot make any concrete suggestions other >>> than pointing at the

Re: Should this_cpu_read() be volatile?

2018-12-08 Thread Peter Zijlstra
On Fri, Dec 07, 2018 at 04:40:52PM -0800, Nadav Amit wrote: > > I'm actually having difficulty finding the this_cpu_read() in any of the > > functions you mention, so I cannot make any concrete suggestions other > > than pointing at the alternative functions available. > > > So I got deeper

Re: Should this_cpu_read() be volatile?

2018-12-08 Thread Peter Zijlstra
On Fri, Dec 07, 2018 at 04:40:52PM -0800, Nadav Amit wrote: > > I'm actually having difficulty finding the this_cpu_read() in any of the > > functions you mention, so I cannot make any concrete suggestions other > > than pointing at the alternative functions available. > > > So I got deeper

Should this_cpu_read() be volatile?

2018-12-07 Thread Nadav Amit
[Resend, changing title & adding lkml and some others ] On Dec 7, 2018, at 3:12 PM, Nadav Amit wrote: [ We can start a new thread, since I have the tendency to hijack threads. ] > On Dec 7, 2018, at 12:45 AM, Peter Zijlstra wrote: > > On Thu, Dec 06, 2018 at 09:26:24AM -0800, Nadav Amit

Should this_cpu_read() be volatile?

2018-12-07 Thread Nadav Amit
[Resend, changing title & adding lkml and some others ] On Dec 7, 2018, at 3:12 PM, Nadav Amit wrote: [ We can start a new thread, since I have the tendency to hijack threads. ] > On Dec 7, 2018, at 12:45 AM, Peter Zijlstra wrote: > > On Thu, Dec 06, 2018 at 09:26:24AM -0800, Nadav Amit