Re: Shrink the held_lock struct by using bitfields.

2007-01-14 Thread Ingo Molnar
On Tue, 2007-01-02 at 18:38 -0500, Dave Jones wrote: > + unsigned char irq_context:1; > + unsigned char trylock:1; > + unsigned char read:2; > + unsigned char check:1; > + unsigned char hardirqs_off:1; cool! I totally missed those. I'd even do this for 2.6.20, but

Re: Shrink the held_lock struct by using bitfields.

2007-01-14 Thread Ingo Molnar
On Tue, 2007-01-02 at 18:38 -0500, Dave Jones wrote: + unsigned char irq_context:1; + unsigned char trylock:1; + unsigned char read:2; + unsigned char check:1; + unsigned char hardirqs_off:1; cool! I totally missed those. I'd even do this for 2.6.20, but it's

Re: Shrink the held_lock struct by using bitfields.

2007-01-02 Thread Dave Jones
On Wed, Jan 03, 2007 at 01:47:36AM +0100, Bodo Eggert wrote: > Dave Jones <[EMAIL PROTECTED]> wrote: > > > Shrink the held_lock struct by using bitfields. > > This shrinks task_struct on lockdep enabled kernels by 480 bytes. > > > * The following fiel

Re: Shrink the held_lock struct by using bitfields.

2007-01-02 Thread Bodo Eggert
Dave Jones <[EMAIL PROTECTED]> wrote: > Shrink the held_lock struct by using bitfields. > This shrinks task_struct on lockdep enabled kernels by 480 bytes. > * The following field is used to detect when we cross into an > * interrupt context:

Re: Shrink the held_lock struct by using bitfields.

2007-01-02 Thread Dave Jones
On Tue, Jan 02, 2007 at 06:35:58PM -0500, Dave Jones wrote: Sent the wrong diff. Here's the fixed version... Shrink the held_lock struct by using bitfields. This shrinks task_struct on lockdep enabled kernels by 480 bytes. Signed-off-by: Dave Jones <[EMAIL PROTECTED]> diff --git a/i

Shrink the held_lock struct by using bitfields.

2007-01-02 Thread Dave Jones
Shrink the held_lock struct by using bitfields. This shrinks task_struct on lockdep enabled kernels by 480 bytes. Signed-off-by: Dave Jones <[EMAIL PROTECTED]> diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h index ea097dd..ba81cce 100644 --- a/include/linux/lockdep.h +++ b/i

Shrink the held_lock struct by using bitfields.

2007-01-02 Thread Dave Jones
Shrink the held_lock struct by using bitfields. This shrinks task_struct on lockdep enabled kernels by 480 bytes. Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/include/linux/lockdep.h b/include/linux/lockdep.h index ea097dd..ba81cce 100644 --- a/include/linux/lockdep.h +++ b/include

Re: Shrink the held_lock struct by using bitfields.

2007-01-02 Thread Dave Jones
On Tue, Jan 02, 2007 at 06:35:58PM -0500, Dave Jones wrote: Sent the wrong diff. Here's the fixed version... Shrink the held_lock struct by using bitfields. This shrinks task_struct on lockdep enabled kernels by 480 bytes. Signed-off-by: Dave Jones [EMAIL PROTECTED] diff --git a/include

Re: Shrink the held_lock struct by using bitfields.

2007-01-02 Thread Bodo Eggert
Dave Jones [EMAIL PROTECTED] wrote: Shrink the held_lock struct by using bitfields. This shrinks task_struct on lockdep enabled kernels by 480 bytes. * The following field is used to detect when we cross into an * interrupt context: */ - int irq_context

Re: Shrink the held_lock struct by using bitfields.

2007-01-02 Thread Dave Jones
On Wed, Jan 03, 2007 at 01:47:36AM +0100, Bodo Eggert wrote: Dave Jones [EMAIL PROTECTED] wrote: Shrink the held_lock struct by using bitfields. This shrinks task_struct on lockdep enabled kernels by 480 bytes. * The following field is used to detect when we cross