Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Joe Perches
On Sat, 2017-02-04 at 20:24 +0100, Julia Lawall wrote: > > On Sat, 4 Feb 2017, Joe Perches wrote: > > > On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote: > > > > > > On Fri, 3 Feb 2017, Joe Perches wrote: > > > > > > > (adding Julia Lawall) > > > > > > > > On Fri, 2017-02-03 at 20:44 -080

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Joe Perches wrote: > On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote: > > > > On Fri, 3 Feb 2017, Joe Perches wrote: > > > > > (adding Julia Lawall) > > > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Der

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Joe Perches
On Sat, 2017-02-04 at 19:10 +0100, Julia Lawall wrote: > > On Fri, 3 Feb 2017, Joe Perches wrote: > > > (adding Julia Lawall) > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > > > A style fix across whole drive

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Fri, 3 Feb 2017, Joe Perches wrote: > (adding Julia Lawall) > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > > A style fix across whole driver. > > > changed permissions to octal style, found using checkpatch > >

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Guenter Roeck wrote: > On 02/04/2017 06:29 AM, Julia Lawall wrote: > > > > > > On Sat, 4 Feb 2017, Guenter Roeck wrote: > > > > > On 02/03/2017 11:27 PM, Joe Perches wrote: > > > > (adding Julia Lawall) > > > > > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: >

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Guenter Roeck
On 02/04/2017 06:29 AM, Julia Lawall wrote: On Sat, 4 Feb 2017, Guenter Roeck wrote: On 02/03/2017 11:27 PM, Joe Perches wrote: (adding Julia Lawall) On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: A style fix across wh

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Julia Lawall
On Sat, 4 Feb 2017, Guenter Roeck wrote: > On 02/03/2017 11:27 PM, Joe Perches wrote: > > (adding Julia Lawall) > > > > On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > > > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > > > A style fix across whole driver. > > > > cha

Re: Staging: speakup - syle fix permissions to octal

2017-02-04 Thread Guenter Roeck
On 02/03/2017 11:27 PM, Joe Perches wrote: (adding Julia Lawall) On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: A style fix across whole driver. changed permissions to octal style, found using checkpatch Signed-off-by: Der

Re: Staging: speakup - syle fix permissions to octal

2017-02-03 Thread Joe Perches
(adding Julia Lawall) On Fri, 2017-02-03 at 20:44 -0800, Guenter Roeck wrote: > On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > > A style fix across whole driver. > > changed permissions to octal style, found using checkpatch > > > > Signed-off-by: Derek Robson > > FWIW, I think

Re: Staging: speakup - syle fix permissions to octal

2017-02-03 Thread Guenter Roeck
On Sat, Jan 28, 2017 at 07:05:09PM +1300, Derek Robson wrote: > A style fix across whole driver. > changed permissions to octal style, found using checkpatch > > Signed-off-by: Derek Robson FWIW, I think changes like this are best done using coccinelle. That ensures that the results can be repro

[PATCH v2] Staging: speakup - syle fix permissions to octal

2017-01-27 Thread Derek Robson
A style fix across whole driver. changed permissions to octal style, found using checkpatch Signed-off-by: Derek Robson --- First version had spaces before praenthesis, now fixed in this version. drivers/staging/speakup/main.c | 4 ++-- drivers/staging/speakup/speakup.h| 4

Re: [PATCH] Staging: speakup - syle fix permissions to octal

2017-01-27 Thread Joe Perches
On Sat, 2017-01-28 at 19:05 +1300, Derek Robson wrote: > A style fix across whole driver. > changed permissions to octal style, found using checkpatch [] > diff --git a/drivers/staging/speakup/main.c b/drivers/staging/speakup/main.c [] > @@ -58,8 +58,8 @@ MODULE_LICENSE("GPL"); > MODULE_VERSION(SP

[PATCH] Staging: speakup - syle fix permissions to octal

2017-01-27 Thread Derek Robson
A style fix across whole driver. changed permissions to octal style, found using checkpatch Signed-off-by: Derek Robson --- drivers/staging/speakup/main.c | 4 ++-- drivers/staging/speakup/speakup.h| 4 ++-- drivers/staging/speakup/speakup_acntpc.c | 26 +-