Support sample context in perf report

2019-03-11 Thread Andi Kleen
[Changes: v6: Rebase. Drop already merged patches. Address review comments: free samples and refactor perf script checking ] We currently have two ways to look at sample data in perf: either use perf report to aggregate everything, or use perf script to look at all individual samples. Both

Support sample context in perf report

2019-03-08 Thread Andi Kleen
[Changes: v5: Address review comments. Fix perf script --cpu filtering Use _NSEC defines. Fix DEBUG=0 build again Make sample context size configurable. Some minor improvements. ] We currently have two ways to look at sample data in perf: either use perf report to aggregate everything, or use

Re: Support sample context in perf report

2019-03-07 Thread Andi Kleen
On Thu, Mar 07, 2019 at 11:57:43AM +0100, Jiri Olsa wrote: > On Tue, Mar 05, 2019 at 06:47:43AM -0800, Andi Kleen wrote: > > [Changes: > > v4: > > Address review comments. > > Fix --cpu filtering. > > Fix a sampling bug. > > Add support for configuring custom script menu entries in perfconfig. >

Re: Support sample context in perf report

2019-03-07 Thread Jiri Olsa
On Tue, Mar 05, 2019 at 06:47:43AM -0800, Andi Kleen wrote: > [Changes: > v4: > Address review comments. > Fix --cpu filtering. > Fix a sampling bug. > Add support for configuring custom script menu entries in perfconfig. > Fix display of more samples than fit on screen. > Fix some buffer

Support sample context in perf report

2019-03-05 Thread Andi Kleen
[Changes: v4: Address review comments. Fix --cpu filtering. Fix a sampling bug. Add support for configuring custom script menu entries in perfconfig. Fix display of more samples than fit on screen. Fix some buffer overruns in legacy code. Add more tips ] We currently have two ways to look at

Support sample context in perf report

2019-02-28 Thread Andi Kleen
[Changes: v3: Fix compile problem on Fedora. Rebase on latest tip. Now hopefully no missing patches.] We currently have two ways to look at sample data in perf: either use perf report to aggregate everything, or use perf script to look at all individual samples. Both ways are useful. Of course

Re: Support sample context in perf report

2019-02-27 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 02:41:20PM -0300, Arnaldo Carvalho de Melo wrote: > Em Wed, Feb 27, 2019 at 09:29:54AM -0800, Andi Kleen escreveu: > > On Wed, Feb 27, 2019 at 05:16:59PM +0100, Jiri Olsa wrote: > > > On Wed, Feb 27, 2019 at 08:01:35AM -0800, Andi Kleen wrote: > > > > > > Also available in

Re: Support sample context in perf report

2019-02-27 Thread Arnaldo Carvalho de Melo
Em Wed, Feb 27, 2019 at 09:29:54AM -0800, Andi Kleen escreveu: > On Wed, Feb 27, 2019 at 05:16:59PM +0100, Jiri Olsa wrote: > > On Wed, Feb 27, 2019 at 08:01:35AM -0800, Andi Kleen wrote: > > > > > Also available in > > > > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git > > > >

Re: Support sample context in perf report

2019-02-27 Thread Andi Kleen
On Wed, Feb 27, 2019 at 05:16:59PM +0100, Jiri Olsa wrote: > On Wed, Feb 27, 2019 at 08:01:35AM -0800, Andi Kleen wrote: > > > > Also available in > > > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git > > > > perf/streams-2 > > > > > > your post is missing this patch, it's only

Re: Support sample context in perf report

2019-02-27 Thread Jiri Olsa
On Wed, Feb 27, 2019 at 08:01:35AM -0800, Andi Kleen wrote: > > > Also available in > > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git > > > perf/streams-2 > > > > your post is missing this patch, it's only in the branch: > > perf tools: Add utility function to fetch

Re: Support sample context in perf report

2019-02-27 Thread Andi Kleen
> > Also available in > > git://git.kernel.org/pub/scm/linux/kernel/git/ak/linux-misc.git > > perf/streams-2 > > your post is missing this patch, it's only in the branch: > perf tools: Add utility function to fetch executable Because Arnaldo already merged it. But the branch is still based on

Re: Support sample context in perf report

2019-02-27 Thread Jiri Olsa
On Mon, Feb 25, 2019 at 07:04:01PM -0800, Andi Kleen wrote: > [Changes: > Removed already merged patches. > Address review feedback, see individual patches. > Now compiles with gcc 8. > Some minor bug fixes and improvements.] > > We currently have two ways to look at sample data in perf: >

Re: Support sample context in perf report

2019-02-26 Thread Andi Kleen
Jiri Olsa writes: > > im still getting compile error the new branch: > > CC ui/browsers/hists.o > ui/browsers/hists.c: In function ‘perf_evsel__hists_browse’: > ui/browsers/hists.c:2567:8: error: ‘%s’ directive output may be truncated > writing up to 63 bytes into a region of size

Re: Support sample context in perf report

2019-02-26 Thread Jiri Olsa
On Mon, Feb 25, 2019 at 07:04:01PM -0800, Andi Kleen wrote: > [Changes: > Removed already merged patches. > Address review feedback, see individual patches. > Now compiles with gcc 8. > Some minor bug fixes and improvements.] > > We currently have two ways to look at sample data in perf: >

Support sample context in perf report

2019-02-25 Thread Andi Kleen
[Changes: Removed already merged patches. Address review feedback, see individual patches. Now compiles with gcc 8. Some minor bug fixes and improvements.] We currently have two ways to look at sample data in perf: either use perf report to aggregate everything, or use perf script to look at all

Support sample context in perf report

2019-02-24 Thread Andi Kleen
We currently have two ways to look at sample data in perf: either use perf report to aggregate everything, or use perf script to look at all individual samples. Both ways are useful. Of course aggregation is useful to quickly find the most expensive part of the code. But sometimes a single