Re: Unfortunate infinite make recursion

2007-09-23 Thread Oleg Verych
On Sun, Sep 23, 2007 at 08:03:35AM +0200, Sam Ravnborg wrote: > > > Please Oleg. > > > You know very well that most people will not have their kernel src RO. > > > > Sure, if it will be not comfortable. > > > > But if kbuild deals with this transparently, it must be OK. Brokenness > > due to binu

Re: Unfortunate infinite make recursion

2007-09-22 Thread Jan Engelhardt
On Sep 22 2007 22:52, Sam Ravnborg wrote: > >Does the following patch fix it at your end? >Seems to work for me. Yes. >- >+# Check the OUTPUT directory is not the same as where we have kernel src >+$(if $(filter-out $(KBUILD_OUTPUT),$(shell /bin/pwd)),, \ >+ $(error Output directory (O=...)

Re: Unfortunate infinite make recursion

2007-09-22 Thread Sam Ravnborg
> > Please Oleg. > > You know very well that most people will not have their kernel src RO. > > Sure, if it will be not comfortable. > > But if kbuild deals with this transparently, it must be OK. Brokenness > due to binutils, kbuild, root user bugs won't garbage source. Only thing > to ask from

Re: Unfortunate infinite make recursion

2007-09-22 Thread Oleg Verych
On Sat, Sep 22, 2007 at 10:40:02PM +0200, Sam Ravnborg wrote: > On Sat, Sep 22, 2007 at 05:42:52PM +0200, Oleg Verych wrote: > > * Sat, 22 Sep 2007 13:24:32 +0200 (CEST) > > [] > > > The make O=$PWD truncates the Makefile, making it necessary to run `git > > > checkout Makefile` - should you have

Re: Unfortunate infinite make recursion

2007-09-22 Thread Bodo Eggert
Jan Engelhardt <[EMAIL PROTECTED]> wrote: > You can cause a recursion in kbuild/make with the following: > > make O=$PWD kernel/time.o > make mrproper > > Of course no one would use O=$PWD (that's just the testcase), > but this happened too often: > > /ws/linux/linux-2.6.23$ make O=/ws/linux/li

Re: Unfortunate infinite make recursion

2007-09-22 Thread Sam Ravnborg
On Sat, Sep 22, 2007 at 01:24:32PM +0200, Jan Engelhardt wrote: > Hi, > > > You can cause a recursion in kbuild/make with the following: > > make O=$PWD kernel/time.o > make mrproper > > Of course no one would use O=$PWD (that's just the testcase), > but this happened too often: > > /ws/linux/

Re: Unfortunate infinite make recursion

2007-09-22 Thread Sam Ravnborg
On Sat, Sep 22, 2007 at 05:42:52PM +0200, Oleg Verych wrote: > * Sat, 22 Sep 2007 13:24:32 +0200 (CEST) > [] > > The make O=$PWD truncates the Makefile, making it necessary to run `git > > checkout Makefile` - should you have git; or reextract the tarball > > (should you /still/ have it). Well, c

Re: Unfortunate infinite make recursion

2007-09-22 Thread Oleg Verych
* Sat, 22 Sep 2007 13:24:32 +0200 (CEST) [] > The make O=$PWD truncates the Makefile, making it necessary to run `git > checkout Makefile` - should you have git; or reextract the tarball > (should you /still/ have it). Well, can we catch this case somehow? Read-only source-tree for kbuild user,

Unfortunate infinite make recursion

2007-09-22 Thread Jan Engelhardt
Hi, You can cause a recursion in kbuild/make with the following: make O=$PWD kernel/time.o make mrproper Of course no one would use O=$PWD (that's just the testcase), but this happened too often: /ws/linux/linux-2.6.23$ make O=/ws/linux/linux-2.6.23 kernel/time.o (Oops - should have been O=/ws