Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Jens Axboe
On 8/14/18 10:51 AM, Linus Torvalds wrote: > On Tue, Aug 14, 2018 at 9:26 AM Jens Axboe wrote: >> >>> >>> We probably just want to special case a flush for this check. In other >>> situations, like resource allocation and issue, we'd want to consider >>> it a write. >> >> Ala: > > Ack, looks

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Jens Axboe
On 8/14/18 10:51 AM, Linus Torvalds wrote: > On Tue, Aug 14, 2018 at 9:26 AM Jens Axboe wrote: >> >>> >>> We probably just want to special case a flush for this check. In other >>> situations, like resource allocation and issue, we'd want to consider >>> it a write. >> >> Ala: > > Ack, looks

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Linus Torvalds
On Tue, Aug 14, 2018 at 9:26 AM Jens Axboe wrote: > > > > > We probably just want to special case a flush for this check. In other > > situations, like resource allocation and issue, we'd want to consider > > it a write. > > Ala: Ack, looks sane to me. Linus

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Linus Torvalds
On Tue, Aug 14, 2018 at 9:26 AM Jens Axboe wrote: > > > > > We probably just want to special case a flush for this check. In other > > situations, like resource allocation and issue, we'd want to consider > > it a write. > > Ala: Ack, looks sane to me. Linus

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Jens Axboe
On 8/14/18 10:24 AM, Jens Axboe wrote: > On 8/14/18 10:22 AM, Linus Torvalds wrote: >> On Tue, Aug 14, 2018 at 8:24 AM Ilya Dryomov wrote: >>> >>> Looks like it's coming from that fsync(): >>> >>> sys_fsync >>> do_fsync >>> vfs_fsync_range >>> blkdev_fsync >>>

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Jens Axboe
On 8/14/18 10:24 AM, Jens Axboe wrote: > On 8/14/18 10:22 AM, Linus Torvalds wrote: >> On Tue, Aug 14, 2018 at 8:24 AM Ilya Dryomov wrote: >>> >>> Looks like it's coming from that fsync(): >>> >>> sys_fsync >>> do_fsync >>> vfs_fsync_range >>> blkdev_fsync >>>

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Jens Axboe
On 8/14/18 10:22 AM, Linus Torvalds wrote: > On Tue, Aug 14, 2018 at 8:24 AM Ilya Dryomov wrote: >> >> Looks like it's coming from that fsync(): >> >> sys_fsync >> do_fsync >> vfs_fsync_range >> blkdev_fsync >> blkdev_issue_flush >> >> I think we need to teach

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Jens Axboe
On 8/14/18 10:22 AM, Linus Torvalds wrote: > On Tue, Aug 14, 2018 at 8:24 AM Ilya Dryomov wrote: >> >> Looks like it's coming from that fsync(): >> >> sys_fsync >> do_fsync >> vfs_fsync_range >> blkdev_fsync >> blkdev_issue_flush >> >> I think we need to teach

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Linus Torvalds
On Tue, Aug 14, 2018 at 8:24 AM Ilya Dryomov wrote: > > Looks like it's coming from that fsync(): > > sys_fsync > do_fsync > vfs_fsync_range > blkdev_fsync > blkdev_issue_flush > > I think we need to teach blkdev_issue_flush() to bail out if the bdev > is read-only,

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Linus Torvalds
On Tue, Aug 14, 2018 at 8:24 AM Ilya Dryomov wrote: > > Looks like it's coming from that fsync(): > > sys_fsync > do_fsync > vfs_fsync_range > blkdev_fsync > blkdev_issue_flush > > I think we need to teach blkdev_issue_flush() to bail out if the bdev > is read-only,

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Ilya Dryomov
On Tue, Aug 14, 2018 at 4:41 PM Stefan Agner wrote: > > Hi, > > Using Linux 4.18 on a i.MX 6Q I see the following warning during > boot-up: > > [ 23.928916] [ cut here ] > [ 23.933795] WARNING: CPU: 1 PID: 527 at block/blk-core.c:2161 >

Re: Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Ilya Dryomov
On Tue, Aug 14, 2018 at 4:41 PM Stefan Agner wrote: > > Hi, > > Using Linux 4.18 on a i.MX 6Q I see the following warning during > boot-up: > > [ 23.928916] [ cut here ] > [ 23.933795] WARNING: CPU: 1 PID: 527 at block/blk-core.c:2161 >

Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Stefan Agner
Hi, Using Linux 4.18 on a i.MX 6Q I see the following warning during boot-up: [ 23.928916] [ cut here ] [ 23.933795] WARNING: CPU: 1 PID: 527 at block/blk-core.c:2161 generic_make_request_checks+0x868/0xa18 [ 23.943306] generic_make_request: Trying to write to

Warning when using eMMC and partprobe: generic_make_request: Trying to write to read-only block-device

2018-08-14 Thread Stefan Agner
Hi, Using Linux 4.18 on a i.MX 6Q I see the following warning during boot-up: [ 23.928916] [ cut here ] [ 23.933795] WARNING: CPU: 1 PID: 527 at block/blk-core.c:2161 generic_make_request_checks+0x868/0xa18 [ 23.943306] generic_make_request: Trying to write to