Re: Writing watchdog_thresh triggers BUG: sleeping function called from invalid context

2014-06-17 Thread Michal Hocko
On Mon 16-06-14 16:52:45, Don Zickus wrote: [...] > Michal, do you remember why we needed preempt here? I wouldn't think it > mattered as we are not doing anything per-cpu specific. Yes, you are right. Preempt can be enabled because we are always accessing watchdog_ev on a specific cpu so

Re: Writing watchdog_thresh triggers BUG: sleeping function called from invalid context

2014-06-17 Thread Michal Hocko
On Mon 16-06-14 16:52:45, Don Zickus wrote: [...] Michal, do you remember why we needed preempt here? I wouldn't think it mattered as we are not doing anything per-cpu specific. Yes, you are right. Preempt can be enabled because we are always accessing watchdog_ev on a specific cpu so

Re: Writing watchdog_thresh triggers BUG: sleeping function called from invalid context

2014-06-16 Thread Peter Wu
On Monday 16 June 2014 16:52:45 Don Zickus wrote: > On Mon, Jun 16, 2014 at 04:12:44PM +0200, Peter Wu wrote: > > Hi, > > > > Writing to /proc/sys/kernel/watchdog_thresh causes the following BUG in > > at least v3.13-rc2-625-g06151db, v3.15 and v3.16-rc1. Kernel config is > > attached. > > > >

Re: Writing watchdog_thresh triggers BUG: sleeping function called from invalid context

2014-06-16 Thread Don Zickus
On Mon, Jun 16, 2014 at 04:12:44PM +0200, Peter Wu wrote: > Hi, > > Writing to /proc/sys/kernel/watchdog_thresh causes the following BUG in > at least v3.13-rc2-625-g06151db, v3.15 and v3.16-rc1. Kernel config is > attached. > > It was originally found on bare metal, since then reproduced in

Re: Writing watchdog_thresh triggers BUG: sleeping function called from invalid context

2014-06-16 Thread Don Zickus
On Mon, Jun 16, 2014 at 04:12:44PM +0200, Peter Wu wrote: Hi, Writing to /proc/sys/kernel/watchdog_thresh causes the following BUG in at least v3.13-rc2-625-g06151db, v3.15 and v3.16-rc1. Kernel config is attached. It was originally found on bare metal, since then reproduced in QEMU in

Re: Writing watchdog_thresh triggers BUG: sleeping function called from invalid context

2014-06-16 Thread Peter Wu
On Monday 16 June 2014 16:52:45 Don Zickus wrote: On Mon, Jun 16, 2014 at 04:12:44PM +0200, Peter Wu wrote: Hi, Writing to /proc/sys/kernel/watchdog_thresh causes the following BUG in at least v3.13-rc2-625-g06151db, v3.15 and v3.16-rc1. Kernel config is attached. It was