Re: __local_bh_enable_ip() vs lockdep

2020-12-18 Thread Peter Zijlstra
On Fri, Dec 18, 2020 at 04:37:16PM +0100, Peter Zijlstra wrote: > On Fri, Dec 18, 2020 at 04:33:56PM +0100, Heiko Carstens wrote: > > > Peter, will you make proper patch out of this? > > Yes, let me go do that now, and stick it in the quilt series before I go > off and don't think for 2 weeks.

Re: __local_bh_enable_ip() vs lockdep

2020-12-18 Thread Peter Zijlstra
On Fri, Dec 18, 2020 at 04:33:56PM +0100, Heiko Carstens wrote: > Peter, will you make proper patch out of this? Yes, let me go do that now, and stick it in the quilt series before I go off and don't think for 2 weeks.

Re: __local_bh_enable_ip() vs lockdep

2020-12-18 Thread Heiko Carstens
On Wed, Dec 16, 2020 at 06:52:59PM +0100, Peter Zijlstra wrote: > On Tue, Dec 15, 2020 at 02:47:24PM -0500, Steven Rostedt wrote: > > On Tue, 15 Dec 2020 20:01:52 +0100 > > Heiko Carstens wrote: > > > > > Hello, > > > > > > the ftrace stack tracer kernel selftest is able to trigger the warning

Re: __local_bh_enable_ip() vs lockdep

2020-12-16 Thread Heiko Carstens
On Wed, Dec 16, 2020 at 06:52:59PM +0100, Peter Zijlstra wrote: > On Tue, Dec 15, 2020 at 02:47:24PM -0500, Steven Rostedt wrote: > > On Tue, 15 Dec 2020 20:01:52 +0100 > > Heiko Carstens wrote: > > > > > Hello, > > > > > > the ftrace stack tracer kernel selftest is able to trigger the warning

Re: __local_bh_enable_ip() vs lockdep

2020-12-16 Thread Peter Zijlstra
On Tue, Dec 15, 2020 at 02:47:24PM -0500, Steven Rostedt wrote: > On Tue, 15 Dec 2020 20:01:52 +0100 > Heiko Carstens wrote: > > > Hello, > > > > the ftrace stack tracer kernel selftest is able to trigger the warning > > below from time to time. This looks like there is an ordering problem > >

Re: __local_bh_enable_ip() vs lockdep

2020-12-15 Thread Steven Rostedt
On Tue, 15 Dec 2020 20:01:52 +0100 Heiko Carstens wrote: > Hello, > > the ftrace stack tracer kernel selftest is able to trigger the warning > below from time to time. This looks like there is an ordering problem > in __local_bh_enable_ip(): > first there is a call to lockdep_softirqs_on() and

__local_bh_enable_ip() vs lockdep

2020-12-15 Thread Heiko Carstens
Hello, the ftrace stack tracer kernel selftest is able to trigger the warning below from time to time. This looks like there is an ordering problem in __local_bh_enable_ip(): first there is a call to lockdep_softirqs_on() and afterwards preempt_count_sub() is ftraced before it was able to modify