Re: [Lksctp-developers] __unsafe() usage

2007-07-25 Thread Vlad Yasevich
Rusty Russell wrote: > On Tue, 2007-07-24 at 09:05 -0400, Vlad Yasevich wrote: >> Please don't remove module_exit point for SCTP. Simply removing the >> __unsafe() call will >> be sufficient. >> >> The code has recently been cleaned up to allow safe unloading and I working >> on final >> cleanup

Re: [Lksctp-developers] __unsafe() usage

2007-07-24 Thread Rusty Russell
On Tue, 2007-07-24 at 09:05 -0400, Vlad Yasevich wrote: > > Please don't remove module_exit point for SCTP. Simply removing the > __unsafe() call will > be sufficient. > > The code has recently been cleaned up to allow safe unloading and I working > on final > cleanups. It currently works cor

Re: [Lksctp-developers] __unsafe() usage

2007-07-24 Thread Vlad Yasevich
Rusty Russell wrote: > [... snip ...] > diff -r d7af727512fd net/sctp/protocol.c > --- a/net/sctp/protocol.c Tue Jul 24 08:30:05 2007 +1000 > +++ b/net/sctp/protocol.c Tue Jul 24 09:12:43 2007 +1000 > @@ -1176,7 +1176,6 @@ SCTP_STATIC __init int sctp_init(void) > if (status) >

Re: __unsafe() usage

2007-07-23 Thread Dan Williams
On 7/23/07, Rusty Russell <[EMAIL PROTECTED]> wrote: On Mon, 2007-07-23 at 19:59 +0200, Adrian Bunk wrote: > On Mon, Jul 23, 2007 at 09:05:54AM -0700, Nelson, Shannon wrote: > > Gabriel C [mailto:[EMAIL PROTECTED] > > > > > >Hi, > > > > > >I got this warning on current git using gcc 4.2.1 : > > >

RE: __unsafe() usage

2007-07-23 Thread Nelson, Shannon
Rusty Russell [mailto:[EMAIL PROTECTED] >> If this is true, and since the MOD_INC_USE_COUNT compat code is long >> gone, shouldn't we be able to completely remove __unsafe() and the >> struct member "unsafe"? > >Yes, indeed, something like this: >== >Remove "unsafe" from module struct > >Adrian

Re: __unsafe() usage

2007-07-23 Thread Rusty Russell
On Mon, 2007-07-23 at 19:59 +0200, Adrian Bunk wrote: > On Mon, Jul 23, 2007 at 09:05:54AM -0700, Nelson, Shannon wrote: > > Gabriel C [mailto:[EMAIL PROTECTED] > > > > > >Hi, > > > > > >I got this warning on current git using gcc 4.2.1 : > > > > > >... > > > > > >drivers/dma/ioatdma.c: In functio

__unsafe() usage

2007-07-23 Thread Adrian Bunk
On Mon, Jul 23, 2007 at 09:05:54AM -0700, Nelson, Shannon wrote: > Gabriel C [mailto:[EMAIL PROTECTED] > > > >Hi, > > > >I got this warning on current git using gcc 4.2.1 : > > > >... > > > >drivers/dma/ioatdma.c: In function 'ioat_init_module': > >drivers/dma/ioatdma.c:816: warning: the address o