Re: ahci_softreset prevents acpi_power_off
Jeff Garzik wrote: > Tejun Heo wrote: >> Arjan van de Ven wrote: >>> I'd be interested in finding out how to best test this; if the bios is >>> really broken I'd love to add a test to the Linux-ready Firmware >>> Developer Kit for this, so that BIOS developers can make sure future >>> bioses do not suffer from this bug... >> >> As reported, this is almost a butterfly effect. ->softreset method is >> only used during initialization and error recovery of ATA devices which >> has almost nothing to do with the rest of the system. This is almost >> like 'changing my mixer input to line-in makes power off fail'. (it's >> more related due to ATA ACPI stuff and maybe that's why this happens but >> I'm trying to make a point here.) > > It's quite possible that the BIOS in question wants AHCI in some > specific state at poweroff. I would be surprised if this weren't an accident. We reset the controller during initialization, so whether softreset or hardreset is used, the end status cannot be much different. And, I really don't wanna change ahci and/or libata for this. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
Tejun Heo wrote: Arjan van de Ven wrote: I'd be interested in finding out how to best test this; if the bios is really broken I'd love to add a test to the Linux-ready Firmware Developer Kit for this, so that BIOS developers can make sure future bioses do not suffer from this bug... As reported, this is almost a butterfly effect. ->softreset method is only used during initialization and error recovery of ATA devices which has almost nothing to do with the rest of the system. This is almost like 'changing my mixer input to line-in makes power off fail'. (it's more related due to ATA ACPI stuff and maybe that's why this happens but I'm trying to make a point here.) It's quite possible that the BIOS in question wants AHCI in some specific state at poweroff. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
Arjan van de Ven wrote: > I'd be interested in finding out how to best test this; if the bios is > really broken I'd love to add a test to the Linux-ready Firmware > Developer Kit for this, so that BIOS developers can make sure future > bioses do not suffer from this bug... As reported, this is almost a butterfly effect. ->softreset method is only used during initialization and error recovery of ATA devices which has almost nothing to do with the rest of the system. This is almost like 'changing my mixer input to line-in makes power off fail'. (it's more related due to ATA ACPI stuff and maybe that's why this happens but I'm trying to make a point here.) I'm not sure the test can be generalized and included in the firmware devel kit. This is a really really special obscure corner case bug which, I believe, none will be able to recreate in the future unless the same code is reused. So, I think the right course of action is to bug the manufacturer. Eh Does that work with sony these days? -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
14 Oca 2007 Paz 20:06 tarihinde, Arjan van de Ven şunları yazmıştı: > Hi, Hi, > I'd be interested in finding out how to best test this; if the bios is > really broken I'd love to add a test to the Linux-ready Firmware > Developer Kit for this, so that BIOS developers can make sure future > bioses do not suffer from this bug... I would be glad to help finding out for this. > Greetings, >Arjan van de Ven Regards, - Faik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
On Sun, 2007-01-14 at 19:59 +0200, Faik Uygur wrote: > 14 Oca 2007 Paz 03:23 tarihinde, Robert Hancock şunları yazmıştı: > >> [...] > >> > Since you're getting to this point I think this has to be some kind of > > BIOS interaction causing this. The only thing that happens after the > > "Entering sleep state" is that the kernel writes to some ACPI registers > > to tell the hardware to power down. I think some laptop BIOSes do things > > on ACPI power down like try to park the drive heads, etc. and maybe this > > change that you found from git bisecting is somehow interfering with it > > doing this? > > > > Might want to check for a BIOS update first of all.. > > Checked from the Sony support page for the laptop model and seems the BIOS > version is the latest. > > So it is nothing interesting but a broken BIOS. Hi, I'd be interested in finding out how to best test this; if the bios is really broken I'd love to add a test to the Linux-ready Firmware Developer Kit for this, so that BIOS developers can make sure future bioses do not suffer from this bug... Greetings, Arjan van de Ven -- if you want to mail me at work (you don't), use arjan (at) linux.intel.com Test the interaction between Linux and your BIOS via http://www.linuxfirmwarekit.org - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
14 Oca 2007 Paz 03:23 tarihinde, Robert Hancock şunları yazmıştı: >> [...] >> > Since you're getting to this point I think this has to be some kind of > BIOS interaction causing this. The only thing that happens after the > "Entering sleep state" is that the kernel writes to some ACPI registers > to tell the hardware to power down. I think some laptop BIOSes do things > on ACPI power down like try to park the drive heads, etc. and maybe this > change that you found from git bisecting is somehow interfering with it > doing this? > > Might want to check for a BIOS update first of all.. Checked from the Sony support page for the laptop model and seems the BIOS version is the latest. So it is nothing interesting but a broken BIOS. Regards, - Faik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
14 Oca 2007 Paz 05:18 tarihinde şunları yazmıştınız: >> [...] > > Since you're getting to this point I think this has to be some kind of > > BIOS interaction causing this. The only thing that happens after the > > "Entering sleep state" is that the kernel writes to some ACPI registers > > to tell the hardware to power down. I think some laptop BIOSes do things > > on ACPI power down like try to park the drive heads, etc. and maybe this > > change that you found from git bisecting is somehow interfering with it > > doing this? > > > > Might want to check for a BIOS update first of all.. > > It would be interesting to try -mm, which includes ACPI support for ATA... With the same .config used and with CONFIG_SATA_ACPI defined as default in 2.6.20-rc4-mm1 the machine did not poweroff again. > Jeff Regards, - Faik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
Robert Hancock wrote: Faik Uygur wrote: What happens when you try to shutdown? Does not shutdown and freezes. Hand copied last messages seen on console: Synchronizing SCSI cache for disk sda: ACPI: PCI Interrupt for device :06:08.0 disabled Power down. acpi_power_off called hwsleep-0285 [01] enter_sleep_state: Entering sleep state [S5] Since you're getting to this point I think this has to be some kind of BIOS interaction causing this. The only thing that happens after the "Entering sleep state" is that the kernel writes to some ACPI registers to tell the hardware to power down. I think some laptop BIOSes do things on ACPI power down like try to park the drive heads, etc. and maybe this change that you found from git bisecting is somehow interfering with it doing this? Might want to check for a BIOS update first of all.. It would be interesting to try -mm, which includes ACPI support for ATA... Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
Faik Uygur wrote: What happens when you try to shutdown? Does not shutdown and freezes. Hand copied last messages seen on console: Synchronizing SCSI cache for disk sda: ACPI: PCI Interrupt for device :06:08.0 disabled Power down. acpi_power_off called hwsleep-0285 [01] enter_sleep_state: Entering sleep state [S5] Since you're getting to this point I think this has to be some kind of BIOS interaction causing this. The only thing that happens after the "Entering sleep state" is that the kernel writes to some ACPI registers to tell the hardware to power down. I think some laptop BIOSes do things on ACPI power down like try to park the drive heads, etc. and maybe this change that you found from git bisecting is somehow interfering with it doing this? Might want to check for a BIOS update first of all.. -- Robert Hancock Saskatoon, SK, Canada To email, remove "nospam" from [EMAIL PROTECTED] Home Page: http://www.roberthancock.com/ - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
Hello Tejun, 13 Oca 2007 Cts 03:12 tarihinde şunları yazmıştınız: > If possible, please post dmesg of shutting down. I have taken more detailed dmesg outputs of three configs with ATA_DEBUG and ATA_VERBOSE_DEBUG defined. You can find them at this address: http://cekirdek.pardus.org.tr/~faik/tmp/ahci/ * ahci file is the output of CONFIG_SCSI_SATA_AHCI compiled config * noahci file is the output of CONFIG_SCSI_SATA_AHCI not compiled config * ahci-nullsoftreset is the output of CONFIG_SCSI_SATA_AHCI compiled config but given NULL to softreset parameters of ata_do_eh in ahci.c Also poweroff-config is the used .config file. Only CONFIG_SCSI_SATA_AHCI is changed between them. I am not familiar with AHCI nor ATA internals. So please ask if you would like to see anything more. Regards, - Faik - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: ahci_softreset prevents acpi_power_off
13 Oca 2007 Cts 03:12 tarihinde, Tejun Heo şunları yazmıştı: > Hello, Hello, Thanks for the response. > [...] > Does everything else work okay? > Can you access devices attached to > ahci? Yes. While the machine is on, there seems to be no problem at all. Everything works great. > What happens when you try to shutdown? Does not shutdown and freezes. Hand copied last messages seen on console: Synchronizing SCSI cache for disk sda: ACPI: PCI Interrupt for device :06:08.0 disabled Power down. acpi_power_off called hwsleep-0285 [01] enter_sleep_state: Entering sleep state [S5] > If possible, please post > dmesg of shutting down. Following is the netcat output. Please ask if you need anything else. Regards, - Faik Linux version 2.6.20-rc4 ([EMAIL PROTECTED]) (gcc version 3.4.6) #58 SMP Sat Jan 13 07:38:22 EET 2007 BIOS-provided physical RAM map: sanitize start sanitize end copy_e820_map() start: size: 0009f800 end: 0009f800 type: 1 copy_e820_map() type is E820_RAM copy_e820_map() start: 0009f800 size: 0800 end: 000a type: 2 copy_e820_map() start: 000d8000 size: 00028000 end: 0010 type: 2 copy_e820_map() start: 0010 size: 1fd9 end: 1fe9 type: 1 copy_e820_map() type is E820_RAM copy_e820_map() start: 1fe9 size: d000 end: 1fe9d000 type: 3 copy_e820_map() start: 1fe9d000 size: 00063000 end: 1ff0 type: 4 copy_e820_map() start: 1ff0 size: 0010 end: 2000 type: 2 copy_e820_map() start: e000 size: 10006000 end: f0006000 type: 2 copy_e820_map() start: f0008000 size: 4000 end: f000c000 type: 2 copy_e820_map() start: fed2 size: 0007 end: fed9 type: 2 copy_e820_map() start: ff00 size: 0100 end: 0001 type: 2 BIOS-e820: - 0009f800 (usable) BIOS-e820: 0009f800 - 000a (reserved) BIOS-e820: 000d8000 - 0010 (reserved) BIOS-e820: 0010 - 1fe9 (usable) BIOS-e820: 1fe9 - 1fe9d000 (ACPI data) BIOS-e820: 1fe9d000 - 1ff0 (ACPI NVS) BIOS-e820: 1ff0 - 2000 (reserved) BIOS-e820: e000 - f0006000 (reserved) BIOS-e820: f0008000 - f000c000 (reserved) BIOS-e820: fed2 - fed9 (reserved) BIOS-e820: ff00 - 0001 (reserved) 0MB HIGHMEM available. 510MB LOWMEM available. Zone PFN ranges: DMA 0 -> 4096 Normal 4096 -> 130704 HighMem130704 -> 130704 early_node_map[1] active PFN ranges 0:0 -> 130704 DMI 2.3 present. ACPI: PM-Timer IO Port: 0x1008 ACPI: LAPIC (acpi_id[0x00] lapic_id[0x00] enabled) Processor #0 6:13 APIC version 20 ACPI: LAPIC (acpi_id[0x01] lapic_id[0x01] disabled) ACPI: LAPIC_NMI (acpi_id[0x00] high edge lint[0x1]) ACPI: LAPIC_NMI (acpi_id[0x01] high edge lint[0x1]) ACPI: IOAPIC (id[0x01] address[0xfec0] gsi_base[0]) IOAPIC[0]: apic_id 1, version 32, address 0xfec0, GSI 0-23 ACPI: INT_SRC_OVR (bus 0 bus_irq 0 global_irq 2 dfl dfl) ACPI: INT_SRC_OVR (bus 0 bus_irq 9 global_irq 9 high level) Enabling APIC mode: Flat. Using 1 I/O APICs Using ACPI (MADT) for SMP configuration information Allocating PCI resources starting at 3000 (gap: 2000:c000) Detected 1729.118 MHz processor. Built 1 zonelists. Total pages: 129045 Kernel command line: root=/dev/sda1 mudur=language:tr init=/bin/bash [EMAIL PROTECTED]/eth0,[EMAIL PROTECTED]/00:13:02:50:5C:2B netconsole: local port netconsole: local IP 192.168.1.8 netconsole: interface eth0 netconsole: remote port 9353 netconsole: remote IP 192.168.1.3 netconsole: remote ethernet address 00:13:02:50:5c:2b Enabling fast FPU save and restore... done. Enabling unmasked SIMD FPU exception support... done. Initializing CPU#0 PID hash table entries: 2048 (order: 11, 8192 bytes) Console: colour VGA+ 80x25 Lock dependency validator: Copyright (c) 2006 Red Hat, Inc., Ingo Molnar ... MAX_LOCKDEP_SUBCLASSES:8 ... MAX_LOCK_DEPTH: 30 ... MAX_LOCKDEP_KEYS:2048 ... CLASSHASH_SIZE: 1024 ... MAX_LOCKDEP_ENTRIES: 8192 ... MAX_LOCKDEP_CHAINS: 16384 ... CHAINHASH_SIZE: 8192 memory used by lock dependency info: 1064 kB per task-struct memory footprint: 1200 bytes | Locking API testsuite: | spin |wlock |rlock |mutex | wsem | rsem | -- A-A deadlock: ok | ok | ok | ok | ok | ok | A-B-B-A deadlock: ok | ok | ok
Re: ahci_softreset prevents acpi_power_off
Hello, Faik Uygur wrote: > We have a Sony PCG-6H1M laptop. It started failing to poweroff with our > switch > from 2.6.16 stable series kernels to 2.6.18 stable series. Rebooting works. > > While searching for the cause, I have found these reported bug reports in the > kernel bugzilla which may be related to this bug: > > http://bugzilla.kernel.org/show_bug.cgi?id=6982 > http://bugzilla.kernel.org/show_bug.cgi?id=7447 Seems mostly unrelated. > According to git bisect, this is the first bad commit: > > 4658f79bec0b51222e769e328c2923f39f3bda77 is first bad commit > commit 4658f79bec0b51222e769e328c2923f39f3bda77 > Author: Tejun Heo <[EMAIL PROTECTED]> > Date: Wed Mar 22 21:07:03 2006 +0900 > > [PATCH] ahci: add softreset > > Now that libata is smart enought to handle both soft and hard resets, > add softreset method. > > Signed-off-by: Tejun Heo <[EMAIL PROTECTED]> > Signed-off-by: Jeff Garzik <[EMAIL PROTECTED]> > > :04 04 ba0a16d0ef82b6577bb61cfb18e6d9df9ee0984e > d0fc78d8f9bbe238f98ac8964562a33e64b30605 M drivers > > With v2.6.20-rc4 from git, it is still failing to poweroff. By not compiling > CONFIG_SCSI_SATA_AHCI, it successfully powers off. > > Also with CONFIG_SCSI_SATA_AHCI, reverting this patch manually by setting > softreset to NULL in ata_do_eh calls in ahci.c makes the machine poweroff. Wow, this is one of the most amazing error report. ahci softreset preventing system halt? > I have attached the dmesg output with defined ATA_DEBUG, ATA_VERBOSE_DEBUG > if it helps. Also you may find lspci output attached. > > Please let me know if anything else is needed. Does everything else work okay? Can you access devices attached to ahci? What happens when you try to shutdown? If possible, please post dmesg of shutting down. You can store it easily using netconsole (Documentation/networking/netconsole.txt). Thanks. -- tejun - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/