Re: another pmem variant V2

2015-04-02 Thread Ingo Molnar
* Christoph Hellwig wrote: > On Thu, Apr 02, 2015 at 03:11:36PM +, Elliott, Robert (Server Storage) > wrote: > > AttrCopyRead IOPS Write IOPS > > = == > > UC memcpy 36 K

Re: another pmem variant V2

2015-04-02 Thread Christoph Hellwig
On Thu, Apr 02, 2015 at 03:11:36PM +, Elliott, Robert (Server Storage) wrote: > Attr CopyRead IOPS Write IOPS > = == > UCmemcpy 36 K22 K > UCNT rd,wr513 K

RE: another pmem variant V2

2015-04-02 Thread Elliott, Robert (Server Storage)
g; x...@kernel.org; > ross.zwis...@linux.intel.com; ax...@kernel.dk; b...@plexistor.com; Kani, > Toshimitsu > Subject: Re: another pmem variant V2 > > On Tue, Mar 31, 2015 at 10:11:29PM +, Elliott, Robert (Server Storage) > wrote: > > I used fio to test 4 KiB random read and wr

Re: another pmem variant V2

2015-04-02 Thread Christoph Hellwig
On Wed, Apr 01, 2015 at 07:33:38PM +, Elliott, Robert (Server Storage) wrote: > I triggered a paging error in the memcpy call for a block read > from system-udevd (actually in a modified memcpy() for the cache > attribute experiments). > > 1. This triggered an illegal schedule() call from

Re: another pmem variant V2

2015-04-02 Thread Christoph Hellwig
On Wed, Apr 01, 2015 at 07:33:38PM +, Elliott, Robert (Server Storage) wrote: I triggered a paging error in the memcpy call for a block read from system-udevd (actually in a modified memcpy() for the cache attribute experiments). 1. This triggered an illegal schedule() call from an

RE: another pmem variant V2

2015-04-02 Thread Elliott, Robert (Server Storage)
...@linux.intel.com; ax...@kernel.dk; b...@plexistor.com; Kani, Toshimitsu Subject: Re: another pmem variant V2 On Tue, Mar 31, 2015 at 10:11:29PM +, Elliott, Robert (Server Storage) wrote: I used fio to test 4 KiB random read and write IOPS on a 2-socket x86 DDR4 system. With various

Re: another pmem variant V2

2015-04-02 Thread Christoph Hellwig
On Thu, Apr 02, 2015 at 03:11:36PM +, Elliott, Robert (Server Storage) wrote: Attr CopyRead IOPS Write IOPS = == UCmemcpy 36 K22 K UCNT rd,wr513 K

Re: another pmem variant V2

2015-04-02 Thread Ingo Molnar
* Christoph Hellwig h...@lst.de wrote: On Thu, Apr 02, 2015 at 03:11:36PM +, Elliott, Robert (Server Storage) wrote: AttrCopyRead IOPS Write IOPS = == UC memcpy 36 K

RE: another pmem variant V2

2015-04-01 Thread Elliott, Robert (Server Storage)
vger.kernel.org; x...@kernel.org > Cc: ross.zwis...@linux.intel.com; ax...@kernel.dk; b...@plexistor.com > Subject: another pmem variant V2 > I triggered a paging error in the memcpy call for a block read from system-udevd (actually in a modified memcpy() for the cache attribute experiments). 1

Re: another pmem variant V2

2015-04-01 Thread Boaz Harrosh
On 03/31/2015 07:16 PM, Christoph Hellwig wrote: > On Tue, Mar 31, 2015 at 06:14:15PM +0300, Boaz Harrosh wrote: >> We can not accept it as is right now. > > Who is we? > >> We have conducted farther tests. And it messes up NUMA. > > Only you if you use the memmap option in weird ways. > No

Re: [Linux-nvdimm] another pmem variant V2

2015-04-01 Thread Boaz Harrosh
On 04/01/2015 10:50 AM, Ingo Molnar wrote: > > * Dan Williams wrote: > >> On Tue, Mar 31, 2015 at 10:24 AM, Christoph Hellwig wrote: >>> On Tue, Mar 31, 2015 at 06:44:56PM +0200, Ingo Molnar wrote: I'd be fine with that too - mind sending an updated series? >>> >>> I will send an updated

Re: [Linux-nvdimm] another pmem variant V2

2015-04-01 Thread Ingo Molnar
* Dan Williams wrote: > On Tue, Mar 31, 2015 at 10:24 AM, Christoph Hellwig wrote: > > On Tue, Mar 31, 2015 at 06:44:56PM +0200, Ingo Molnar wrote: > >> I'd be fine with that too - mind sending an updated series? > > > > I will send an updated one tonight or early tomorrow. > > > > Btw, do you

Re: another pmem variant V2

2015-04-01 Thread Christoph Hellwig
On Tue, Mar 31, 2015 at 10:11:29PM +, Elliott, Robert (Server Storage) wrote: > I used fio to test 4 KiB random read and write IOPS > on a 2-socket x86 DDR4 system. With various cache attributes: > > attr readwrite notes > - -

Re: another pmem variant V2

2015-04-01 Thread Christoph Hellwig
On Tue, Mar 31, 2015 at 10:11:29PM +, Elliott, Robert (Server Storage) wrote: I used fio to test 4 KiB random read and write IOPS on a 2-socket x86 DDR4 system. With various cache attributes: attr readwrite notes - - UC

Re: [Linux-nvdimm] another pmem variant V2

2015-04-01 Thread Boaz Harrosh
On 04/01/2015 10:50 AM, Ingo Molnar wrote: * Dan Williams dan.j.willi...@intel.com wrote: On Tue, Mar 31, 2015 at 10:24 AM, Christoph Hellwig h...@lst.de wrote: On Tue, Mar 31, 2015 at 06:44:56PM +0200, Ingo Molnar wrote: I'd be fine with that too - mind sending an updated series? I will

Re: [Linux-nvdimm] another pmem variant V2

2015-04-01 Thread Ingo Molnar
* Dan Williams dan.j.willi...@intel.com wrote: On Tue, Mar 31, 2015 at 10:24 AM, Christoph Hellwig h...@lst.de wrote: On Tue, Mar 31, 2015 at 06:44:56PM +0200, Ingo Molnar wrote: I'd be fine with that too - mind sending an updated series? I will send an updated one tonight or early

Re: another pmem variant V2

2015-04-01 Thread Boaz Harrosh
On 03/31/2015 07:16 PM, Christoph Hellwig wrote: On Tue, Mar 31, 2015 at 06:14:15PM +0300, Boaz Harrosh wrote: We can not accept it as is right now. Who is we? We have conducted farther tests. And it messes up NUMA. Only you if you use the memmap option in weird ways. No weird ways

RE: another pmem variant V2

2015-04-01 Thread Elliott, Robert (Server Storage)
Cc: ross.zwis...@linux.intel.com; ax...@kernel.dk; b...@plexistor.com Subject: another pmem variant V2 I triggered a paging error in the memcpy call for a block read from system-udevd (actually in a modified memcpy() for the cache attribute experiments). 1. This triggered an illegal schedule

RE: another pmem variant V2

2015-03-31 Thread Elliott, Robert (Server Storage)
vger.kernel.org; x...@kernel.org > Cc: ross.zwis...@linux.intel.com; ax...@kernel.dk; b...@plexistor.com > Subject: another pmem variant V2 > > Here is another version of the same trivial pmem driver, because two > obviously aren't enough. The first patch is the same pmem driver > tha

Re: [Linux-nvdimm] another pmem variant V2

2015-03-31 Thread Dan Williams
On Tue, Mar 31, 2015 at 10:24 AM, Christoph Hellwig wrote: > On Tue, Mar 31, 2015 at 06:44:56PM +0200, Ingo Molnar wrote: >> I'd be fine with that too - mind sending an updated series? > > I will send an updated one tonight or early tomorrow. > > Btw, do you want to keep the E820_PRAM name

Re: another pmem variant V2

2015-03-31 Thread Christoph Hellwig
On Tue, Mar 31, 2015 at 06:44:56PM +0200, Ingo Molnar wrote: > I'd be fine with that too - mind sending an updated series? I will send an updated one tonight or early tomorrow. Btw, do you want to keep the E820_PRAM name instead of E820_PMEM? Seems like most people either don't care or prefer

Re: another pmem variant V2

2015-03-31 Thread Ingo Molnar
* Christoph Hellwig wrote: > On Tue, Mar 31, 2015 at 06:14:15PM +0300, Boaz Harrosh wrote: > > We can not accept it as is right now. > > Who is we? > > > We have conducted farther tests. And it messes up NUMA. > > Only you if you use the memmap option in weird ways. > > Sounds like I should

Re: another pmem variant V2

2015-03-31 Thread Christoph Hellwig
On Tue, Mar 31, 2015 at 06:14:15PM +0300, Boaz Harrosh wrote: > We can not accept it as is right now. Who is we? > We have conducted farther tests. And it messes up NUMA. Only you if you use the memmap option in weird ways. Sounds like I should simply remove the memmap= option so people don't

Re: another pmem variant V2

2015-03-31 Thread Christoph Hellwig
On Tue, Mar 31, 2015 at 01:25:46PM +0300, Boaz Harrosh wrote: > The problem I see is that if I state a memmap=nn!aa that crosses a NUMA > boundary then the machine will not boot. > So BTW for sure I need that "don't merge E820_PMEM ranges" patch because > otherwise I will not be able to boot if I

Re: another pmem variant V2

2015-03-31 Thread Boaz Harrosh
On 03/31/2015 12:25 PM, Christoph Hellwig wrote: > On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: <> > > Any news? I'd really like to resend this ASAP to get it into 4.1.. Hi Christoph I hate to be bearer of bad news but we have a problem with the e820 patch: x86: add

Re: another pmem variant V2

2015-03-31 Thread Boaz Harrosh
On 03/31/2015 01:25 PM, Boaz Harrosh wrote: > On 03/31/2015 12:25 PM, Christoph Hellwig wrote: <> > The problem I see is that if I state a memmap=nn!aa that crosses a NUMA > boundary then the machine will not boot. > So BTW for sure I need that "don't merge E820_PMEM ranges" patch because >

Re: another pmem variant V2

2015-03-31 Thread Boaz Harrosh
On 03/31/2015 12:25 PM, Christoph Hellwig wrote: > On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: >> On 03/26/2015 10:32 AM, Christoph Hellwig wrote: >>> Here is another version of the same trivial pmem driver, because two >>> obviously aren't enough. The first patch is the same

Re: another pmem variant V2

2015-03-31 Thread Christoph Hellwig
On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: > On 03/26/2015 10:32 AM, Christoph Hellwig wrote: > > Here is another version of the same trivial pmem driver, because two > > obviously aren't enough. The first patch is the same pmem driver > > that Ross posted a short time ago,

Re: another pmem variant V2

2015-03-31 Thread Boaz Harrosh
On 03/31/2015 12:25 PM, Christoph Hellwig wrote: On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: On 03/26/2015 10:32 AM, Christoph Hellwig wrote: Here is another version of the same trivial pmem driver, because two obviously aren't enough. The first patch is the same pmem driver

Re: another pmem variant V2

2015-03-31 Thread Boaz Harrosh
On 03/31/2015 01:25 PM, Boaz Harrosh wrote: On 03/31/2015 12:25 PM, Christoph Hellwig wrote: The problem I see is that if I state a memmap=nn!aa that crosses a NUMA boundary then the machine will not boot. So BTW for sure I need that don't merge E820_PMEM ranges patch because otherwise I

Re: another pmem variant V2

2015-03-31 Thread Christoph Hellwig
On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: On 03/26/2015 10:32 AM, Christoph Hellwig wrote: Here is another version of the same trivial pmem driver, because two obviously aren't enough. The first patch is the same pmem driver that Ross posted a short time ago, just

Re: another pmem variant V2

2015-03-31 Thread Boaz Harrosh
On 03/31/2015 12:25 PM, Christoph Hellwig wrote: On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: Any news? I'd really like to resend this ASAP to get it into 4.1.. Hi Christoph I hate to be bearer of bad news but we have a problem with the e820 patch: x86: add

Re: another pmem variant V2

2015-03-31 Thread Ingo Molnar
* Christoph Hellwig h...@lst.de wrote: On Tue, Mar 31, 2015 at 06:14:15PM +0300, Boaz Harrosh wrote: We can not accept it as is right now. Who is we? We have conducted farther tests. And it messes up NUMA. Only you if you use the memmap option in weird ways. Sounds like I should

Re: another pmem variant V2

2015-03-31 Thread Christoph Hellwig
On Tue, Mar 31, 2015 at 01:25:46PM +0300, Boaz Harrosh wrote: The problem I see is that if I state a memmap=nn!aa that crosses a NUMA boundary then the machine will not boot. So BTW for sure I need that don't merge E820_PMEM ranges patch because otherwise I will not be able to boot if I have

Re: another pmem variant V2

2015-03-31 Thread Christoph Hellwig
On Tue, Mar 31, 2015 at 06:14:15PM +0300, Boaz Harrosh wrote: We can not accept it as is right now. Who is we? We have conducted farther tests. And it messes up NUMA. Only you if you use the memmap option in weird ways. Sounds like I should simply remove the memmap= option so people don't

Re: another pmem variant V2

2015-03-31 Thread Christoph Hellwig
On Tue, Mar 31, 2015 at 06:44:56PM +0200, Ingo Molnar wrote: I'd be fine with that too - mind sending an updated series? I will send an updated one tonight or early tomorrow. Btw, do you want to keep the E820_PRAM name instead of E820_PMEM? Seems like most people either don't care or prefer

Re: [Linux-nvdimm] another pmem variant V2

2015-03-31 Thread Dan Williams
On Tue, Mar 31, 2015 at 10:24 AM, Christoph Hellwig h...@lst.de wrote: On Tue, Mar 31, 2015 at 06:44:56PM +0200, Ingo Molnar wrote: I'd be fine with that too - mind sending an updated series? I will send an updated one tonight or early tomorrow. Btw, do you want to keep the E820_PRAM name

RE: another pmem variant V2

2015-03-31 Thread Elliott, Robert (Server Storage)
Cc: ross.zwis...@linux.intel.com; ax...@kernel.dk; b...@plexistor.com Subject: another pmem variant V2 Here is another version of the same trivial pmem driver, because two obviously aren't enough. The first patch is the same pmem driver that Ross posted a short time ago, just modified

Re: another pmem variant V2

2015-03-26 Thread Christoph Hellwig
On Thu, Mar 26, 2015 at 07:31:03PM +0200, Boaz Harrosh wrote: > But I hope you are not ignoring my real problem. any two memmap= ranges > will halt the boot. Specially if they are dis-contiguous. not the case here, verified it in various cofigurations. > Also I need the contiguous variant split

Re: another pmem variant V2

2015-03-26 Thread Christoph Hellwig
And here's the patch, sorry: diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c index 4bd525a..e7bf89e 100644 --- a/arch/x86/kernel/e820.c +++ b/arch/x86/kernel/e820.c @@ -346,7 +346,7 @@ int __init sanitize_e820_map(struct e820entry *biosmap, int max_nr_map, *

Re: another pmem variant V2

2015-03-26 Thread Boaz Harrosh
On 03/26/2015 07:18 PM, Christoph Hellwig wrote: > On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: >> For one this auto discovery of yours is very (very) nice but is a bit >> inconvenience. Before I would reserve a big chuck on each NUMA range >> on Kernel's memmap= And then at pmem

Re: another pmem variant V2

2015-03-26 Thread Christoph Hellwig
On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: > For one this auto discovery of yours is very (very) nice but is a bit > inconvenience. Before I would reserve a big chuck on each NUMA range > on Kernel's memmap= And then at pmem map= would slice and dice it > as I want hot style on

Re: another pmem variant V2

2015-03-26 Thread Boaz Harrosh
On 03/26/2015 10:32 AM, Christoph Hellwig wrote: > Here is another version of the same trivial pmem driver, because two > obviously aren't enough. The first patch is the same pmem driver > that Ross posted a short time ago, just modified to use platform_devices > to find the persistant memory

another pmem variant V2

2015-03-26 Thread Christoph Hellwig
Here is another version of the same trivial pmem driver, because two obviously aren't enough. The first patch is the same pmem driver that Ross posted a short time ago, just modified to use platform_devices to find the persistant memory region instead of hardconding it in the Kconfig. This

another pmem variant V2

2015-03-26 Thread Christoph Hellwig
Here is another version of the same trivial pmem driver, because two obviously aren't enough. The first patch is the same pmem driver that Ross posted a short time ago, just modified to use platform_devices to find the persistant memory region instead of hardconding it in the Kconfig. This

Re: another pmem variant V2

2015-03-26 Thread Boaz Harrosh
On 03/26/2015 07:18 PM, Christoph Hellwig wrote: On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: For one this auto discovery of yours is very (very) nice but is a bit inconvenience. Before I would reserve a big chuck on each NUMA range on Kernel's memmap= And then at pmem map=

Re: another pmem variant V2

2015-03-26 Thread Christoph Hellwig
On Thu, Mar 26, 2015 at 06:57:47PM +0200, Boaz Harrosh wrote: For one this auto discovery of yours is very (very) nice but is a bit inconvenience. Before I would reserve a big chuck on each NUMA range on Kernel's memmap= And then at pmem map= would slice and dice it as I want hot style on

Re: another pmem variant V2

2015-03-26 Thread Christoph Hellwig
And here's the patch, sorry: diff --git a/arch/x86/kernel/e820.c b/arch/x86/kernel/e820.c index 4bd525a..e7bf89e 100644 --- a/arch/x86/kernel/e820.c +++ b/arch/x86/kernel/e820.c @@ -346,7 +346,7 @@ int __init sanitize_e820_map(struct e820entry *biosmap, int max_nr_map, *

Re: another pmem variant V2

2015-03-26 Thread Christoph Hellwig
On Thu, Mar 26, 2015 at 07:31:03PM +0200, Boaz Harrosh wrote: But I hope you are not ignoring my real problem. any two memmap= ranges will halt the boot. Specially if they are dis-contiguous. not the case here, verified it in various cofigurations. Also I need the contiguous variant split

Re: another pmem variant V2

2015-03-26 Thread Boaz Harrosh
On 03/26/2015 10:32 AM, Christoph Hellwig wrote: Here is another version of the same trivial pmem driver, because two obviously aren't enough. The first patch is the same pmem driver that Ross posted a short time ago, just modified to use platform_devices to find the persistant memory region