Re: arch_align_stack() seems useless

2007-08-30 Thread Franck Bui-Huu
Arjan, Franck Bui-Huu wrote: > Arjan van de Ven wrote: >> arch_align_stack aligns, on x86, within a 2 page range (this is for >> cache coloring). > > OK, but for elf case this seems useless since the top of the stack is > already randomized. > > It seems that the randomization stuff (top of the

Re: arch_align_stack() seems useless

2007-08-30 Thread Franck Bui-Huu
Arjan, Franck Bui-Huu wrote: Arjan van de Ven wrote: arch_align_stack aligns, on x86, within a 2 page range (this is for cache coloring). OK, but for elf case this seems useless since the top of the stack is already randomized. It seems that the randomization stuff (top of the stack +

Re: arch_align_stack() seems useless

2007-08-28 Thread Franck Bui-Huu
Hello Arjan, Arjan van de Ven wrote: > arch_align_stack aligns, on x86, within a 2 page range (this is for > cache coloring). OK, but for elf case this seems useless since the top of the stack is already randomized. It seems that the randomization stuff (top of the stack + stack pointer inside

Re: arch_align_stack() seems useless

2007-08-28 Thread Franck Bui-Huu
Hello Arjan, Arjan van de Ven wrote: arch_align_stack aligns, on x86, within a 2 page range (this is for cache coloring). OK, but for elf case this seems useless since the top of the stack is already randomized. It seems that the randomization stuff (top of the stack + stack pointer inside a

Re: arch_align_stack() seems useless

2007-08-27 Thread Arjan van de Ven
On Mon, 27 Aug 2007 16:08:31 +0200 Franck Bui-Huu <[EMAIL PROTECTED]> wrote: > and recently mips do that. Here is the code taken from exec.c which > calls it: > > int setup_arg_pages(struct linux_binprm *bprm, > unsigned long stack_top, >

arch_align_stack() seems useless

2007-08-27 Thread Franck Bui-Huu
Hello folks, I recently pick up the implementation of arch_align_stack() from x86 architectures to make it available for mips. But now I just realised that this function seems useless because of the way it's used. Currently, this function seems to be only used to randomize the stack pointer

arch_align_stack() seems useless

2007-08-27 Thread Franck Bui-Huu
Hello folks, I recently pick up the implementation of arch_align_stack() from x86 architectures to make it available for mips. But now I just realised that this function seems useless because of the way it's used. Currently, this function seems to be only used to randomize the stack pointer

Re: arch_align_stack() seems useless

2007-08-27 Thread Arjan van de Ven
On Mon, 27 Aug 2007 16:08:31 +0200 Franck Bui-Huu [EMAIL PROTECTED] wrote: and recently mips do that. Here is the code taken from exec.c which calls it: int setup_arg_pages(struct linux_binprm *bprm, unsigned long stack_top, int