Re: arm: sunxi: &83t: WARNING: CPU: 2 PID: 57 at drivers/thermal/thermal_core.c:563 thermal_zone_device_update
On Sun, Jan 31, 2021 at 01:33:32PM +0800, Chen-Yu Tsai wrote: > Hi, > > On Sun, Jan 31, 2021 at 12:54 AM Corentin Labbe > wrote: > > > > Hello > > > > When booting next-20210128, I got the following warning on by bpim3 > > 6.148421] [ cut here ] > > [6.153145] WARNING: CPU: 2 PID: 57 at > > drivers/thermal/thermal_core.c:563 thermal_zone_device_update+0x134/0x154 > > [6.163378] 'thermal_zone_device_update' must not be called without > > 'get_temp' ops set > > [6.171300] Modules linked in: sha256_generic libsha256 > > [6.176553] CPU: 2 PID: 57 Comm: kworker/2:1 Not tainted > > 5.11.0-rc1-00042-gf3788af62cfe #399 > > [6.184984] Hardware name: Allwinner A83t board > > [6.189517] Workqueue: events deferred_probe_work_func > > [6.194686] [] (unwind_backtrace) from [] > > (show_stack+0x10/0x14) > > [6.202438] [] (show_stack) from [] > > (dump_stack+0x98/0xac) > > [6.209666] [] (dump_stack) from [] > > (__warn+0xc0/0xd8) > > [6.216545] [] (__warn) from [] > > (warn_slowpath_fmt+0x98/0xc0) > > [6.224030] [] (warn_slowpath_fmt) from [] > > (thermal_zone_device_update+0x134/0x154) > > [6.233426] [] (thermal_zone_device_update) from [] > > (__thermal_cooling_device_register+0x334/0x35c) > > [6.244204] [] (__thermal_cooling_device_register) from > > [] (__cpufreq_cooling_register.constprop.0+0x184/0x294) > > [6.256026] [] (__cpufreq_cooling_register.constprop.0) from > > [] (of_cpufreq_cooling_register+0x40/0x7c) > > [6.267153] [] (of_cpufreq_cooling_register) from [] > > (cpufreq_online+0x2b4/0x8f4) > > [6.276379] [] (cpufreq_online) from [] > > (cpufreq_add_dev+0x6c/0x78) > > [6.284383] [] (cpufreq_add_dev) from [] > > (subsys_interface_register+0xa4/0xf0) > > [6.293344] [] (subsys_interface_register) from [] > > (cpufreq_register_driver+0x144/0x2dc) > > [6.303169] [] (cpufreq_register_driver) from [] > > (dt_cpufreq_probe+0x298/0x3b8) > > [6.312215] [] (dt_cpufreq_probe) from [] > > (platform_probe+0x5c/0xb8) > > [6.320313] [] (platform_probe) from [] > > (really_probe+0x1dc/0x3b8) > > [6.328231] [] (really_probe) from [] > > (driver_probe_device+0x5c/0xb4) > > [6.336406] [] (driver_probe_device) from [] > > (bus_for_each_drv+0x84/0xc8) > > [6.344928] [] (bus_for_each_drv) from [] > > (__device_attach+0xe8/0x154) > > [6.353189] [] (__device_attach) from [] > > (bus_probe_device+0x84/0x8c) > > [6.361365] [] (bus_probe_device) from [] > > (deferred_probe_work_func+0x64/0x90) > > [6.370321] [] (deferred_probe_work_func) from [] > > (process_one_work+0x1dc/0x438) > > [6.379456] [] (process_one_work) from [] > > (worker_thread+0x25c/0x55c) > > [6.387632] [] (worker_thread) from [] > > (kthread+0x124/0x150) > > [6.395032] [] (kthread) from [] > > (ret_from_fork+0x14/0x24) > > [6.402256] Exception stack(0xc12d1fb0 to 0xc12d1ff8) > > [6.407307] 1fa0: > > > > [6.415478] 1fc0: > > > > [6.423648] 1fe0: 0013 > > [6.430301] ---[ end trace bd63a5c976f3611c ]--- > > > > I bisected the problem to > > ARM: dts: sunxi: Remove thermal zones without trip points > > > > Reverting this commit remove the warning. I dropped the commit from our PR, thanks > The thermal subsystem seems to require a thermal zone be present for each > thermal sensor that is registered. > > So maybe a better solution is not to remove the thermal zones without trip > points, but just add the standard passive and critical trip points based > on the SoC's thermal limits. I'm not really fond of having trip points that have never been really tested either. I guess we should start that discussion with the maintainers. Maxime signature.asc Description: PGP signature
Re: arm: sunxi: &83t: WARNING: CPU: 2 PID: 57 at drivers/thermal/thermal_core.c:563 thermal_zone_device_update
Hi, On Sun, Jan 31, 2021 at 12:54 AM Corentin Labbe wrote: > > Hello > > When booting next-20210128, I got the following warning on by bpim3 > 6.148421] [ cut here ] > [6.153145] WARNING: CPU: 2 PID: 57 at drivers/thermal/thermal_core.c:563 > thermal_zone_device_update+0x134/0x154 > [6.163378] 'thermal_zone_device_update' must not be called without > 'get_temp' ops set > [6.171300] Modules linked in: sha256_generic libsha256 > [6.176553] CPU: 2 PID: 57 Comm: kworker/2:1 Not tainted > 5.11.0-rc1-00042-gf3788af62cfe #399 > [6.184984] Hardware name: Allwinner A83t board > [6.189517] Workqueue: events deferred_probe_work_func > [6.194686] [] (unwind_backtrace) from [] > (show_stack+0x10/0x14) > [6.202438] [] (show_stack) from [] > (dump_stack+0x98/0xac) > [6.209666] [] (dump_stack) from [] (__warn+0xc0/0xd8) > [6.216545] [] (__warn) from [] > (warn_slowpath_fmt+0x98/0xc0) > [6.224030] [] (warn_slowpath_fmt) from [] > (thermal_zone_device_update+0x134/0x154) > [6.233426] [] (thermal_zone_device_update) from [] > (__thermal_cooling_device_register+0x334/0x35c) > [6.244204] [] (__thermal_cooling_device_register) from > [] (__cpufreq_cooling_register.constprop.0+0x184/0x294) > [6.256026] [] (__cpufreq_cooling_register.constprop.0) from > [] (of_cpufreq_cooling_register+0x40/0x7c) > [6.267153] [] (of_cpufreq_cooling_register) from [] > (cpufreq_online+0x2b4/0x8f4) > [6.276379] [] (cpufreq_online) from [] > (cpufreq_add_dev+0x6c/0x78) > [6.284383] [] (cpufreq_add_dev) from [] > (subsys_interface_register+0xa4/0xf0) > [6.293344] [] (subsys_interface_register) from [] > (cpufreq_register_driver+0x144/0x2dc) > [6.303169] [] (cpufreq_register_driver) from [] > (dt_cpufreq_probe+0x298/0x3b8) > [6.312215] [] (dt_cpufreq_probe) from [] > (platform_probe+0x5c/0xb8) > [6.320313] [] (platform_probe) from [] > (really_probe+0x1dc/0x3b8) > [6.328231] [] (really_probe) from [] > (driver_probe_device+0x5c/0xb4) > [6.336406] [] (driver_probe_device) from [] > (bus_for_each_drv+0x84/0xc8) > [6.344928] [] (bus_for_each_drv) from [] > (__device_attach+0xe8/0x154) > [6.353189] [] (__device_attach) from [] > (bus_probe_device+0x84/0x8c) > [6.361365] [] (bus_probe_device) from [] > (deferred_probe_work_func+0x64/0x90) > [6.370321] [] (deferred_probe_work_func) from [] > (process_one_work+0x1dc/0x438) > [6.379456] [] (process_one_work) from [] > (worker_thread+0x25c/0x55c) > [6.387632] [] (worker_thread) from [] > (kthread+0x124/0x150) > [6.395032] [] (kthread) from [] > (ret_from_fork+0x14/0x24) > [6.402256] Exception stack(0xc12d1fb0 to 0xc12d1ff8) > [6.407307] 1fa0: > > [6.415478] 1fc0: > > [6.423648] 1fe0: 0013 > [6.430301] ---[ end trace bd63a5c976f3611c ]--- > > I bisected the problem to > ARM: dts: sunxi: Remove thermal zones without trip points > > Reverting this commit remove the warning. The thermal subsystem seems to require a thermal zone be present for each thermal sensor that is registered. So maybe a better solution is not to remove the thermal zones without trip points, but just add the standard passive and critical trip points based on the SoC's thermal limits. ChenYu
arm: sunxi: &83t: WARNING: CPU: 2 PID: 57 at drivers/thermal/thermal_core.c:563 thermal_zone_device_update
Hello When booting next-20210128, I got the following warning on by bpim3 6.148421] [ cut here ] [6.153145] WARNING: CPU: 2 PID: 57 at drivers/thermal/thermal_core.c:563 thermal_zone_device_update+0x134/0x154 [6.163378] 'thermal_zone_device_update' must not be called without 'get_temp' ops set [6.171300] Modules linked in: sha256_generic libsha256 [6.176553] CPU: 2 PID: 57 Comm: kworker/2:1 Not tainted 5.11.0-rc1-00042-gf3788af62cfe #399 [6.184984] Hardware name: Allwinner A83t board [6.189517] Workqueue: events deferred_probe_work_func [6.194686] [] (unwind_backtrace) from [] (show_stack+0x10/0x14) [6.202438] [] (show_stack) from [] (dump_stack+0x98/0xac) [6.209666] [] (dump_stack) from [] (__warn+0xc0/0xd8) [6.216545] [] (__warn) from [] (warn_slowpath_fmt+0x98/0xc0) [6.224030] [] (warn_slowpath_fmt) from [] (thermal_zone_device_update+0x134/0x154) [6.233426] [] (thermal_zone_device_update) from [] (__thermal_cooling_device_register+0x334/0x35c) [6.244204] [] (__thermal_cooling_device_register) from [] (__cpufreq_cooling_register.constprop.0+0x184/0x294) [6.256026] [] (__cpufreq_cooling_register.constprop.0) from [] (of_cpufreq_cooling_register+0x40/0x7c) [6.267153] [] (of_cpufreq_cooling_register) from [] (cpufreq_online+0x2b4/0x8f4) [6.276379] [] (cpufreq_online) from [] (cpufreq_add_dev+0x6c/0x78) [6.284383] [] (cpufreq_add_dev) from [] (subsys_interface_register+0xa4/0xf0) [6.293344] [] (subsys_interface_register) from [] (cpufreq_register_driver+0x144/0x2dc) [6.303169] [] (cpufreq_register_driver) from [] (dt_cpufreq_probe+0x298/0x3b8) [6.312215] [] (dt_cpufreq_probe) from [] (platform_probe+0x5c/0xb8) [6.320313] [] (platform_probe) from [] (really_probe+0x1dc/0x3b8) [6.328231] [] (really_probe) from [] (driver_probe_device+0x5c/0xb4) [6.336406] [] (driver_probe_device) from [] (bus_for_each_drv+0x84/0xc8) [6.344928] [] (bus_for_each_drv) from [] (__device_attach+0xe8/0x154) [6.353189] [] (__device_attach) from [] (bus_probe_device+0x84/0x8c) [6.361365] [] (bus_probe_device) from [] (deferred_probe_work_func+0x64/0x90) [6.370321] [] (deferred_probe_work_func) from [] (process_one_work+0x1dc/0x438) [6.379456] [] (process_one_work) from [] (worker_thread+0x25c/0x55c) [6.387632] [] (worker_thread) from [] (kthread+0x124/0x150) [6.395032] [] (kthread) from [] (ret_from_fork+0x14/0x24) [6.402256] Exception stack(0xc12d1fb0 to 0xc12d1ff8) [6.407307] 1fa0: [6.415478] 1fc0: [6.423648] 1fe0: 0013 [6.430301] ---[ end trace bd63a5c976f3611c ]--- I bisected the problem to ARM: dts: sunxi: Remove thermal zones without trip points Reverting this commit remove the warning. Regards
