Re: ath9k broken [was: Linux 5.7.3]
Viktor Jägersküpper writes: >>> This bug was also reported on the thread where it had been posted >>> originally: >>> https://lore.kernel.org/linux-wireless/20200621020428.6417d6fb@natsu/ >>> >>> I am waiting for Kalle Valo to accept my patch (v2) which reverts the above >>> mentioned commit and which looks correct according to him. He wrote that he >>> would take a closer look at this as soon as he could. >> >> Mark posted a patch which I'm hoping to fix the issue: >> >> [1/1] ath9k: Fix regression with Atheros 9271 >> >> https://patchwork.kernel.org/patch/11657669/ >> >> Can someone confirm this, please? I would rather take Mark's fix than >> the revert. >> > > This fixes the issue for me. Great, thanks for testing. I'll wait at least another day for more comments and then queue it for v5.8. -- https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: ath9k broken [was: Linux 5.7.3]
[CC'ed Roman]
Kalle Valo:
> Viktor Jägersküpper writes:
>
>> Greg Kroah-Hartman wrote:
>>> On Fri, Jun 26, 2020 at 04:40:18PM +0200, Gabriel C wrote:
Am Fr., 26. Juni 2020 um 15:51 Uhr schrieb Gabriel C
:
>
> Am Fr., 26. Juni 2020 um 15:40 Uhr schrieb Greg Kroah-Hartman
> :
>>
>> On Fri, Jun 26, 2020 at 01:48:59PM +0200, Gabriel C wrote:
>>> Am Do., 25. Juni 2020 um 12:52 Uhr schrieb Gabriel C
>>> :
Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
:
>
> Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby
> :
>>
>> On 25. 06. 20, 0:05, Gabriel C wrote:
>>> Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
>>> :
I'm announcing the release of the 5.7.3 kernel.
>>>
>>> Hello Greg,
>>>
Qiujun Huang (5):
ath9k: Fix use-after-free Read in htc_connect_service
ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
>>>
>>> We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi
>>> Dongle,
>>> while working fine on <5.7.3.
>>>
>>> I don't have myself such HW, and the reported doesn't have any
>>> experience
>>> in bisecting the kernel, so we build kernels, each with one of the
>>> above commits reverted,
>>> to find the bad commit.
>>>
>>> The winner is:
>>>
>>> commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
>>> Author: Qiujun Huang
>>> Date: Sat Apr 4 12:18:38 2020 +0800
>>>
>>> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
>>>
>>> commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
>>> ...
>>>
>>> Reverting this one fixed his problem.
>>
>> Obvious question: is 5.8-rc1 (containing the commit) broken too?
>
> Yes, it does, just checked.
>
> git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
> v5.8-rc1
> v5.8-rc2
>
Sorry, I read the wrong, I just woke up.
We didn't test 5.8-rc{1,2} yet but we will today and let you know.
>>>
>>> We tested 5.8-rc2 and it is broken too.
>>>
>>> The exact HW name is:
>>>
>>> TP-link tl-wn722n (Atheros AR9271 chip)
>>
>> Great!
>>
>> Can you work with the developers to fix this in Linus's tree first?
>
> I'm the man in the middle, but sure we will try patches or any suggestions
> from developers to identify and fix the problem.
>
>>
>> I bet they want to see the output of 'lsusb -v' for this device to see
>> if the endpoint calculations are correct...
>>
>
> Working on it. As soon the reporter gives me the output, I will post it
> here.
> I've told him to run it on a broken and one working kernel.
That is from a good kernel with reverted commit
https://gist.github.com/AngryPenguinPL/07c8e2abd3b103eaf8978a39ad8577d1
That is from the broken kernel without the commit reverted
https://gist.github.com/AngryPenguinPL/5cdc0dd16ce5e59ff3c32c048e2f5111
This is from 5.7.5 kernel, I don't have yet a 5.8-rc2 package with the
reverted commit.
>>>
>>> Did this ever get resolved?
>>>
>>> thanks,
>>>
>>> greg k-h
>>>
>>
>> This bug was also reported on the thread where it had been posted originally:
>> https://lore.kernel.org/linux-wireless/20200621020428.6417d6fb@natsu/
>>
>> I am waiting for Kalle Valo to accept my patch (v2) which reverts the above
>> mentioned commit and which looks correct according to him. He wrote that he
>> would take a closer look at this as soon as he could.
>
> Mark posted a patch which I'm hoping to fix the issue:
>
> [1/1] ath9k: Fix regression with Atheros 9271
>
> https://patchwork.kernel.org/patch/11657669/
>
> Can someone confirm this, please? I would rather take Mark's fix than
> the revert.
>
12345678901234567890123456789012345678901234567890123456789012345678901234567890
This fixes the issue for me. Unfortunately the revert landed in 5.7.9 (it was
also queued for the older releases, but I didn't check them) because Hans de
Goede requested it since he didn't know about Mark's patch. So if you want to
fix the stable and longterm kernels properly, we need another patch which
includes a re-revert and Mark's patch. But Mark's patch should definitely land
in the mainline kernel first.
Re: ath9k broken [was: Linux 5.7.3]
Viktor Jägersküpper writes:
> Greg Kroah-Hartman wrote:
>> On Fri, Jun 26, 2020 at 04:40:18PM +0200, Gabriel C wrote:
>>> Am Fr., 26. Juni 2020 um 15:51 Uhr schrieb Gabriel C
>>> :
Am Fr., 26. Juni 2020 um 15:40 Uhr schrieb Greg Kroah-Hartman
:
>
> On Fri, Jun 26, 2020 at 01:48:59PM +0200, Gabriel C wrote:
>> Am Do., 25. Juni 2020 um 12:52 Uhr schrieb Gabriel C
>> :
>>>
>>> Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
>>> :
Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby
:
>
> On 25. 06. 20, 0:05, Gabriel C wrote:
>> Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
>> :
>>>
>>> I'm announcing the release of the 5.7.3 kernel.
>>>
>>
>> Hello Greg,
>>
>>> Qiujun Huang (5):
>>> ath9k: Fix use-after-free Read in htc_connect_service
>>> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
>>> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
>>> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
>>> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
>>>
>>
>> We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi Dongle,
>> while working fine on <5.7.3.
>>
>> I don't have myself such HW, and the reported doesn't have any
>> experience
>> in bisecting the kernel, so we build kernels, each with one of the
>> above commits reverted,
>> to find the bad commit.
>>
>> The winner is:
>>
>> commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
>> Author: Qiujun Huang
>> Date: Sat Apr 4 12:18:38 2020 +0800
>>
>> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
>>
>> commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
>> ...
>>
>> Reverting this one fixed his problem.
>
> Obvious question: is 5.8-rc1 (containing the commit) broken too?
Yes, it does, just checked.
git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
v5.8-rc1
v5.8-rc2
>>>
>>> Sorry, I read the wrong, I just woke up.
>>>
>>> We didn't test 5.8-rc{1,2} yet but we will today and let you know.
>>>
>>
>> We tested 5.8-rc2 and it is broken too.
>>
>> The exact HW name is:
>>
>> TP-link tl-wn722n (Atheros AR9271 chip)
>
> Great!
>
> Can you work with the developers to fix this in Linus's tree first?
I'm the man in the middle, but sure we will try patches or any suggestions
from developers to identify and fix the problem.
>
> I bet they want to see the output of 'lsusb -v' for this device to see
> if the endpoint calculations are correct...
>
Working on it. As soon the reporter gives me the output, I will post it
here.
I've told him to run it on a broken and one working kernel.
>>>
>>> That is from a good kernel with reverted commit
>>> https://gist.github.com/AngryPenguinPL/07c8e2abd3b103eaf8978a39ad8577d1
>>>
>>> That is from the broken kernel without the commit reverted
>>> https://gist.github.com/AngryPenguinPL/5cdc0dd16ce5e59ff3c32c048e2f5111
>>>
>>> This is from 5.7.5 kernel, I don't have yet a 5.8-rc2 package with the
>>> reverted commit.
>>
>> Did this ever get resolved?
>>
>> thanks,
>>
>> greg k-h
>>
>
> This bug was also reported on the thread where it had been posted originally:
> https://lore.kernel.org/linux-wireless/20200621020428.6417d6fb@natsu/
>
> I am waiting for Kalle Valo to accept my patch (v2) which reverts the above
> mentioned commit and which looks correct according to him. He wrote that he
> would take a closer look at this as soon as he could.
Mark posted a patch which I'm hoping to fix the issue:
[1/1] ath9k: Fix regression with Atheros 9271
https://patchwork.kernel.org/patch/11657669/
Can someone confirm this, please? I would rather take Mark's fix than
the revert.
--
https://wireless.wiki.kernel.org/en/developers/documentation/submittingpatches
Re: ath9k broken [was: Linux 5.7.3]
Greg Kroah-Hartman wrote:
> On Fri, Jun 26, 2020 at 04:40:18PM +0200, Gabriel C wrote:
>> Am Fr., 26. Juni 2020 um 15:51 Uhr schrieb Gabriel C
>> :
>>>
>>> Am Fr., 26. Juni 2020 um 15:40 Uhr schrieb Greg Kroah-Hartman
>>> :
On Fri, Jun 26, 2020 at 01:48:59PM +0200, Gabriel C wrote:
> Am Do., 25. Juni 2020 um 12:52 Uhr schrieb Gabriel C
> :
>>
>> Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
>> :
>>>
>>> Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby
>>> :
On 25. 06. 20, 0:05, Gabriel C wrote:
> Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
> :
>>
>> I'm announcing the release of the 5.7.3 kernel.
>>
>
> Hello Greg,
>
>> Qiujun Huang (5):
>> ath9k: Fix use-after-free Read in htc_connect_service
>> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
>> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
>> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
>> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
>>
>
> We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi Dongle,
> while working fine on <5.7.3.
>
> I don't have myself such HW, and the reported doesn't have any
> experience
> in bisecting the kernel, so we build kernels, each with one of the
> above commits reverted,
> to find the bad commit.
>
> The winner is:
>
> commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
> Author: Qiujun Huang
> Date: Sat Apr 4 12:18:38 2020 +0800
>
> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
>
> commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
> ...
>
> Reverting this one fixed his problem.
Obvious question: is 5.8-rc1 (containing the commit) broken too?
>>>
>>> Yes, it does, just checked.
>>>
>>> git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
>>> v5.8-rc1
>>> v5.8-rc2
>>>
>>
>> Sorry, I read the wrong, I just woke up.
>>
>> We didn't test 5.8-rc{1,2} yet but we will today and let you know.
>>
>
> We tested 5.8-rc2 and it is broken too.
>
> The exact HW name is:
>
> TP-link tl-wn722n (Atheros AR9271 chip)
Great!
Can you work with the developers to fix this in Linus's tree first?
>>>
>>> I'm the man in the middle, but sure we will try patches or any suggestions
>>> from developers to identify and fix the problem.
>>>
I bet they want to see the output of 'lsusb -v' for this device to see
if the endpoint calculations are correct...
>>>
>>> Working on it. As soon the reporter gives me the output, I will post it
>>> here.
>>> I've told him to run it on a broken and one working kernel.
>>
>> That is from a good kernel with reverted commit
>> https://gist.github.com/AngryPenguinPL/07c8e2abd3b103eaf8978a39ad8577d1
>>
>> That is from the broken kernel without the commit reverted
>> https://gist.github.com/AngryPenguinPL/5cdc0dd16ce5e59ff3c32c048e2f5111
>>
>> This is from 5.7.5 kernel, I don't have yet a 5.8-rc2 package with the
>> reverted commit.
>
> Did this ever get resolved?
>
> thanks,
>
> greg k-h
>
This bug was also reported on the thread where it had been posted originally:
https://lore.kernel.org/linux-wireless/20200621020428.6417d6fb@natsu/
I am waiting for Kalle Valo to accept my patch (v2) which reverts the above
mentioned commit and which looks correct according to him. He wrote that he
would take a closer look at this as soon as he could.
I don't know how busy Kalle is, especially under the current circumstances.
I will remind him on Thursday (one week after his last e-mail). At the latest
I want this to be fixed with the 5.8 release. I think that the patch has to land
in several networking trees before it reaches the mainline kernel, so if I can
do anything to speed things up, just tell me.
Thanks,
Viktor
Re: ath9k broken [was: Linux 5.7.3]
On Fri, Jun 26, 2020 at 04:40:18PM +0200, Gabriel C wrote:
> Am Fr., 26. Juni 2020 um 15:51 Uhr schrieb Gabriel C
> :
> >
> > Am Fr., 26. Juni 2020 um 15:40 Uhr schrieb Greg Kroah-Hartman
> > :
> > >
> > > On Fri, Jun 26, 2020 at 01:48:59PM +0200, Gabriel C wrote:
> > > > Am Do., 25. Juni 2020 um 12:52 Uhr schrieb Gabriel C
> > > > :
> > > > >
> > > > > Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
> > > > > :
> > > > > >
> > > > > > Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby
> > > > > > :
> > > > > > >
> > > > > > > On 25. 06. 20, 0:05, Gabriel C wrote:
> > > > > > > > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
> > > > > > > > :
> > > > > > > >>
> > > > > > > >> I'm announcing the release of the 5.7.3 kernel.
> > > > > > > >>
> > > > > > > >
> > > > > > > > Hello Greg,
> > > > > > > >
> > > > > > > >> Qiujun Huang (5):
> > > > > > > >> ath9k: Fix use-after-free Read in htc_connect_service
> > > > > > > >> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
> > > > > > > >> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
> > > > > > > >> ath9x: Fix stack-out-of-bounds Write in
> > > > > > > >> ath9k_hif_usb_rx_cb
> > > > > > > >> ath9k: Fix general protection fault in
> > > > > > > >> ath9k_hif_usb_rx_cb
> > > > > > > >>
> > > > > > > >
> > > > > > > > We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi
> > > > > > > > Dongle,
> > > > > > > > while working fine on <5.7.3.
> > > > > > > >
> > > > > > > > I don't have myself such HW, and the reported doesn't have any
> > > > > > > > experience
> > > > > > > > in bisecting the kernel, so we build kernels, each with one of
> > > > > > > > the
> > > > > > > > above commits reverted,
> > > > > > > > to find the bad commit.
> > > > > > > >
> > > > > > > > The winner is:
> > > > > > > >
> > > > > > > > commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
> > > > > > > > Author: Qiujun Huang
> > > > > > > > Date: Sat Apr 4 12:18:38 2020 +0800
> > > > > > > >
> > > > > > > > ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > > > > > >
> > > > > > > > commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
> > > > > > > > ...
> > > > > > > >
> > > > > > > > Reverting this one fixed his problem.
> > > > > > >
> > > > > > > Obvious question: is 5.8-rc1 (containing the commit) broken too?
> > > > > >
> > > > > > Yes, it does, just checked.
> > > > > >
> > > > > > git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
> > > > > > v5.8-rc1
> > > > > > v5.8-rc2
> > > > > >
> > > > >
> > > > > Sorry, I read the wrong, I just woke up.
> > > > >
> > > > > We didn't test 5.8-rc{1,2} yet but we will today and let you know.
> > > > >
> > > >
> > > > We tested 5.8-rc2 and it is broken too.
> > > >
> > > > The exact HW name is:
> > > >
> > > > TP-link tl-wn722n (Atheros AR9271 chip)
> > >
> > > Great!
> > >
> > > Can you work with the developers to fix this in Linus's tree first?
> >
> > I'm the man in the middle, but sure we will try patches or any suggestions
> > from developers to identify and fix the problem.
> >
> > >
> > > I bet they want to see the output of 'lsusb -v' for this device to see
> > > if the endpoint calculations are correct...
> > >
> >
> > Working on it. As soon the reporter gives me the output, I will post it
> > here.
> > I've told him to run it on a broken and one working kernel.
>
> That is from a good kernel with reverted commit
> https://gist.github.com/AngryPenguinPL/07c8e2abd3b103eaf8978a39ad8577d1
>
> That is from the broken kernel without the commit reverted
> https://gist.github.com/AngryPenguinPL/5cdc0dd16ce5e59ff3c32c048e2f5111
>
> This is from 5.7.5 kernel, I don't have yet a 5.8-rc2 package with the
> reverted commit.
Did this ever get resolved?
thanks,
greg k-h
Re: ath9k broken [was: Linux 5.7.3]
On Thu, 25 Jun 2020 06:57:13 +0200 Jiri Slaby wrote: > I fail to see how the commit could cause an issue like this. Is this > really reproducibly broken with the commit and irreproducible without > it? As it looks like a USB/wiring problem: > usb 1-2: USB disconnect, device number 2 > ath: phy0: Reading Magic # failed > ath: phy0: Unable to initialize hardware; initialization status: -5 > ... > usb 1-2: device descriptor read/64, error -110 > usb 1-2: device descriptor read/64, error -71 > > Ccing ath9k maintainers too. Note that this has been previously reported in: https://bugzilla.kernel.org/show_bug.cgi?id=208251 and confirmed by several people on various stable series and the mainline that the referenced commit is indeed causing the problem. I don't get the "device descriptor read" errors though, my dmesg is posted on the bug report, it just says "ath9k_htc: Failed to initialize the device". > > I don't have so much info about the HW, besides a dmesg showing the > > phy breaking. > > I also added the reporter to CC too. > > > > https://gist.github.com/AngryPenguinPL/1e545f0da3c2339e443b9e5044fcccea > > > > If you need more info, please let me know and I'll try my best to get > > it as fast as possible for you. -- With respect, Roman
Re: ath9k broken [was: Linux 5.7.3]
Am Fr., 26. Juni 2020 um 15:51 Uhr schrieb Gabriel C
:
>
> Am Fr., 26. Juni 2020 um 15:40 Uhr schrieb Greg Kroah-Hartman
> :
> >
> > On Fri, Jun 26, 2020 at 01:48:59PM +0200, Gabriel C wrote:
> > > Am Do., 25. Juni 2020 um 12:52 Uhr schrieb Gabriel C
> > > :
> > > >
> > > > Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
> > > > :
> > > > >
> > > > > Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby
> > > > > :
> > > > > >
> > > > > > On 25. 06. 20, 0:05, Gabriel C wrote:
> > > > > > > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
> > > > > > > :
> > > > > > >>
> > > > > > >> I'm announcing the release of the 5.7.3 kernel.
> > > > > > >>
> > > > > > >
> > > > > > > Hello Greg,
> > > > > > >
> > > > > > >> Qiujun Huang (5):
> > > > > > >> ath9k: Fix use-after-free Read in htc_connect_service
> > > > > > >> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
> > > > > > >> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
> > > > > > >> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
> > > > > > >> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > > > > >>
> > > > > > >
> > > > > > > We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi
> > > > > > > Dongle,
> > > > > > > while working fine on <5.7.3.
> > > > > > >
> > > > > > > I don't have myself such HW, and the reported doesn't have any
> > > > > > > experience
> > > > > > > in bisecting the kernel, so we build kernels, each with one of the
> > > > > > > above commits reverted,
> > > > > > > to find the bad commit.
> > > > > > >
> > > > > > > The winner is:
> > > > > > >
> > > > > > > commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
> > > > > > > Author: Qiujun Huang
> > > > > > > Date: Sat Apr 4 12:18:38 2020 +0800
> > > > > > >
> > > > > > > ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > > > > >
> > > > > > > commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
> > > > > > > ...
> > > > > > >
> > > > > > > Reverting this one fixed his problem.
> > > > > >
> > > > > > Obvious question: is 5.8-rc1 (containing the commit) broken too?
> > > > >
> > > > > Yes, it does, just checked.
> > > > >
> > > > > git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
> > > > > v5.8-rc1
> > > > > v5.8-rc2
> > > > >
> > > >
> > > > Sorry, I read the wrong, I just woke up.
> > > >
> > > > We didn't test 5.8-rc{1,2} yet but we will today and let you know.
> > > >
> > >
> > > We tested 5.8-rc2 and it is broken too.
> > >
> > > The exact HW name is:
> > >
> > > TP-link tl-wn722n (Atheros AR9271 chip)
> >
> > Great!
> >
> > Can you work with the developers to fix this in Linus's tree first?
>
> I'm the man in the middle, but sure we will try patches or any suggestions
> from developers to identify and fix the problem.
>
> >
> > I bet they want to see the output of 'lsusb -v' for this device to see
> > if the endpoint calculations are correct...
> >
>
> Working on it. As soon the reporter gives me the output, I will post it here.
> I've told him to run it on a broken and one working kernel.
That is from a good kernel with reverted commit
https://gist.github.com/AngryPenguinPL/07c8e2abd3b103eaf8978a39ad8577d1
That is from the broken kernel without the commit reverted
https://gist.github.com/AngryPenguinPL/5cdc0dd16ce5e59ff3c32c048e2f5111
This is from 5.7.5 kernel, I don't have yet a 5.8-rc2 package with the
reverted commit.
Re: ath9k broken [was: Linux 5.7.3]
Am Fr., 26. Juni 2020 um 15:40 Uhr schrieb Greg Kroah-Hartman
:
>
> On Fri, Jun 26, 2020 at 01:48:59PM +0200, Gabriel C wrote:
> > Am Do., 25. Juni 2020 um 12:52 Uhr schrieb Gabriel C
> > :
> > >
> > > Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
> > > :
> > > >
> > > > Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby
> > > > :
> > > > >
> > > > > On 25. 06. 20, 0:05, Gabriel C wrote:
> > > > > > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
> > > > > > :
> > > > > >>
> > > > > >> I'm announcing the release of the 5.7.3 kernel.
> > > > > >>
> > > > > >
> > > > > > Hello Greg,
> > > > > >
> > > > > >> Qiujun Huang (5):
> > > > > >> ath9k: Fix use-after-free Read in htc_connect_service
> > > > > >> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
> > > > > >> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
> > > > > >> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
> > > > > >> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > > > >>
> > > > > >
> > > > > > We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi
> > > > > > Dongle,
> > > > > > while working fine on <5.7.3.
> > > > > >
> > > > > > I don't have myself such HW, and the reported doesn't have any
> > > > > > experience
> > > > > > in bisecting the kernel, so we build kernels, each with one of the
> > > > > > above commits reverted,
> > > > > > to find the bad commit.
> > > > > >
> > > > > > The winner is:
> > > > > >
> > > > > > commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
> > > > > > Author: Qiujun Huang
> > > > > > Date: Sat Apr 4 12:18:38 2020 +0800
> > > > > >
> > > > > > ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > > > >
> > > > > > commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
> > > > > > ...
> > > > > >
> > > > > > Reverting this one fixed his problem.
> > > > >
> > > > > Obvious question: is 5.8-rc1 (containing the commit) broken too?
> > > >
> > > > Yes, it does, just checked.
> > > >
> > > > git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
> > > > v5.8-rc1
> > > > v5.8-rc2
> > > >
> > >
> > > Sorry, I read the wrong, I just woke up.
> > >
> > > We didn't test 5.8-rc{1,2} yet but we will today and let you know.
> > >
> >
> > We tested 5.8-rc2 and it is broken too.
> >
> > The exact HW name is:
> >
> > TP-link tl-wn722n (Atheros AR9271 chip)
>
> Great!
>
> Can you work with the developers to fix this in Linus's tree first?
I'm the man in the middle, but sure we will try patches or any suggestions
from developers to identify and fix the problem.
>
> I bet they want to see the output of 'lsusb -v' for this device to see
> if the endpoint calculations are correct...
>
Working on it. As soon the reporter gives me the output, I will post it here.
I've told him to run it on a broken and one working kernel.
> thanks,
>
> greg k-h
Best Regards,
Gabriel C
Re: ath9k broken [was: Linux 5.7.3]
On Fri, Jun 26, 2020 at 01:48:59PM +0200, Gabriel C wrote:
> Am Do., 25. Juni 2020 um 12:52 Uhr schrieb Gabriel C
> :
> >
> > Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
> > :
> > >
> > > Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby
> > > :
> > > >
> > > > On 25. 06. 20, 0:05, Gabriel C wrote:
> > > > > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
> > > > > :
> > > > >>
> > > > >> I'm announcing the release of the 5.7.3 kernel.
> > > > >>
> > > > >
> > > > > Hello Greg,
> > > > >
> > > > >> Qiujun Huang (5):
> > > > >> ath9k: Fix use-after-free Read in htc_connect_service
> > > > >> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
> > > > >> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
> > > > >> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
> > > > >> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > > >>
> > > > >
> > > > > We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi Dongle,
> > > > > while working fine on <5.7.3.
> > > > >
> > > > > I don't have myself such HW, and the reported doesn't have any
> > > > > experience
> > > > > in bisecting the kernel, so we build kernels, each with one of the
> > > > > above commits reverted,
> > > > > to find the bad commit.
> > > > >
> > > > > The winner is:
> > > > >
> > > > > commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
> > > > > Author: Qiujun Huang
> > > > > Date: Sat Apr 4 12:18:38 2020 +0800
> > > > >
> > > > > ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > > >
> > > > > commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
> > > > > ...
> > > > >
> > > > > Reverting this one fixed his problem.
> > > >
> > > > Obvious question: is 5.8-rc1 (containing the commit) broken too?
> > >
> > > Yes, it does, just checked.
> > >
> > > git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
> > > v5.8-rc1
> > > v5.8-rc2
> > >
> >
> > Sorry, I read the wrong, I just woke up.
> >
> > We didn't test 5.8-rc{1,2} yet but we will today and let you know.
> >
>
> We tested 5.8-rc2 and it is broken too.
>
> The exact HW name is:
>
> TP-link tl-wn722n (Atheros AR9271 chip)
Great!
Can you work with the developers to fix this in Linus's tree first?
I bet they want to see the output of 'lsusb -v' for this device to see
if the endpoint calculations are correct...
thanks,
greg k-h
Re: ath9k broken [was: Linux 5.7.3]
Am Do., 25. Juni 2020 um 12:52 Uhr schrieb Gabriel C
:
>
> Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
> :
> >
> > Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby
> > :
> > >
> > > On 25. 06. 20, 0:05, Gabriel C wrote:
> > > > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
> > > > :
> > > >>
> > > >> I'm announcing the release of the 5.7.3 kernel.
> > > >>
> > > >
> > > > Hello Greg,
> > > >
> > > >> Qiujun Huang (5):
> > > >> ath9k: Fix use-after-free Read in htc_connect_service
> > > >> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
> > > >> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
> > > >> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
> > > >> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > >>
> > > >
> > > > We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi Dongle,
> > > > while working fine on <5.7.3.
> > > >
> > > > I don't have myself such HW, and the reported doesn't have any
> > > > experience
> > > > in bisecting the kernel, so we build kernels, each with one of the
> > > > above commits reverted,
> > > > to find the bad commit.
> > > >
> > > > The winner is:
> > > >
> > > > commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
> > > > Author: Qiujun Huang
> > > > Date: Sat Apr 4 12:18:38 2020 +0800
> > > >
> > > > ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > > >
> > > > commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
> > > > ...
> > > >
> > > > Reverting this one fixed his problem.
> > >
> > > Obvious question: is 5.8-rc1 (containing the commit) broken too?
> >
> > Yes, it does, just checked.
> >
> > git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
> > v5.8-rc1
> > v5.8-rc2
> >
>
> Sorry, I read the wrong, I just woke up.
>
> We didn't test 5.8-rc{1,2} yet but we will today and let you know.
>
We tested 5.8-rc2 and it is broken too.
The exact HW name is:
TP-link tl-wn722n (Atheros AR9271 chip)
> > >
> > > I fail to see how the commit could cause an issue like this. Is this
> > > really reproducibly broken with the commit and irreproducible without
> > > it?
> >
> > I can't see something obvious wrong either, but yes it's reproducible on
> > his HW.
> > Kernel with this commit breaks the dongle, with the commit reverted it
> > works.
> >
> > >As it looks like a USB/wiring problem:
> > > usb 1-2: USB disconnect, device number 2
> > > ath: phy0: Reading Magic # failed
> > > ath: phy0: Unable to initialize hardware; initialization status: -5
> > > ...
> > > usb 1-2: device descriptor read/64, error -110
> > > usb 1-2: device descriptor read/64, error -71
> > >
> > > Ccing ath9k maintainers too.
> > >
> > > > I don't have so much info about the HW, besides a dmesg showing the
> > > > phy breaking.
> > > > I also added the reporter to CC too.
> > > >
> > > > https://gist.github.com/AngryPenguinPL/1e545f0da3c2339e443b9e5044fcccea
> > > >
> > > > If you need more info, please let me know and I'll try my best to get
> > > > it as fast as possible for you.
> > >
Best Regards,
Gabriel C
Re: ath9k broken [was: Linux 5.7.3]
Am Do., 25. Juni 2020 um 12:48 Uhr schrieb Gabriel C
:
>
> Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby :
> >
> > On 25. 06. 20, 0:05, Gabriel C wrote:
> > > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman
> > > :
> > >>
> > >> I'm announcing the release of the 5.7.3 kernel.
> > >>
> > >
> > > Hello Greg,
> > >
> > >> Qiujun Huang (5):
> > >> ath9k: Fix use-after-free Read in htc_connect_service
> > >> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx
> > >> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg
> > >> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb
> > >> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > >>
> > >
> > > We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi Dongle,
> > > while working fine on <5.7.3.
> > >
> > > I don't have myself such HW, and the reported doesn't have any experience
> > > in bisecting the kernel, so we build kernels, each with one of the
> > > above commits reverted,
> > > to find the bad commit.
> > >
> > > The winner is:
> > >
> > > commit 6602f080cb28745259e2fab1a4cf55eeb5894f93
> > > Author: Qiujun Huang
> > > Date: Sat Apr 4 12:18:38 2020 +0800
> > >
> > > ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb
> > >
> > > commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream.
> > > ...
> > >
> > > Reverting this one fixed his problem.
> >
> > Obvious question: is 5.8-rc1 (containing the commit) broken too?
>
> Yes, it does, just checked.
>
> git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05
> v5.8-rc1
> v5.8-rc2
>
Sorry, I read the wrong, I just woke up.
We didn't test 5.8-rc{1,2} yet but we will today and let you know.
> >
> > I fail to see how the commit could cause an issue like this. Is this
> > really reproducibly broken with the commit and irreproducible without
> > it?
>
> I can't see something obvious wrong either, but yes it's reproducible on his
> HW.
> Kernel with this commit breaks the dongle, with the commit reverted it works.
>
> >As it looks like a USB/wiring problem:
> > usb 1-2: USB disconnect, device number 2
> > ath: phy0: Reading Magic # failed
> > ath: phy0: Unable to initialize hardware; initialization status: -5
> > ...
> > usb 1-2: device descriptor read/64, error -110
> > usb 1-2: device descriptor read/64, error -71
> >
> > Ccing ath9k maintainers too.
> >
> > > I don't have so much info about the HW, besides a dmesg showing the
> > > phy breaking.
> > > I also added the reporter to CC too.
> > >
> > > https://gist.github.com/AngryPenguinPL/1e545f0da3c2339e443b9e5044fcccea
> > >
> > > If you need more info, please let me know and I'll try my best to get
> > > it as fast as possible for you.
> >
>
> Best Regards,
>
> Gabriel C
Re: ath9k broken [was: Linux 5.7.3]
Am Do., 25. Juni 2020 um 06:57 Uhr schrieb Jiri Slaby : > > On 25. 06. 20, 0:05, Gabriel C wrote: > > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman > > : > >> > >> I'm announcing the release of the 5.7.3 kernel. > >> > > > > Hello Greg, > > > >> Qiujun Huang (5): > >> ath9k: Fix use-after-free Read in htc_connect_service > >> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx > >> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg > >> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb > >> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb > >> > > > > We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi Dongle, > > while working fine on <5.7.3. > > > > I don't have myself such HW, and the reported doesn't have any experience > > in bisecting the kernel, so we build kernels, each with one of the > > above commits reverted, > > to find the bad commit. > > > > The winner is: > > > > commit 6602f080cb28745259e2fab1a4cf55eeb5894f93 > > Author: Qiujun Huang > > Date: Sat Apr 4 12:18:38 2020 +0800 > > > > ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb > > > > commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream. > > ... > > > > Reverting this one fixed his problem. > > Obvious question: is 5.8-rc1 (containing the commit) broken too? Yes, it does, just checked. git tag --contains 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 v5.8-rc1 v5.8-rc2 > > I fail to see how the commit could cause an issue like this. Is this > really reproducibly broken with the commit and irreproducible without > it? I can't see something obvious wrong either, but yes it's reproducible on his HW. Kernel with this commit breaks the dongle, with the commit reverted it works. >As it looks like a USB/wiring problem: > usb 1-2: USB disconnect, device number 2 > ath: phy0: Reading Magic # failed > ath: phy0: Unable to initialize hardware; initialization status: -5 > ... > usb 1-2: device descriptor read/64, error -110 > usb 1-2: device descriptor read/64, error -71 > > Ccing ath9k maintainers too. > > > I don't have so much info about the HW, besides a dmesg showing the > > phy breaking. > > I also added the reporter to CC too. > > > > https://gist.github.com/AngryPenguinPL/1e545f0da3c2339e443b9e5044fcccea > > > > If you need more info, please let me know and I'll try my best to get > > it as fast as possible for you. > Best Regards, Gabriel C
ath9k broken [was: Linux 5.7.3]
On 25. 06. 20, 0:05, Gabriel C wrote: > Am Mi., 17. Juni 2020 um 18:13 Uhr schrieb Greg Kroah-Hartman > : >> >> I'm announcing the release of the 5.7.3 kernel. >> > > Hello Greg, > >> Qiujun Huang (5): >> ath9k: Fix use-after-free Read in htc_connect_service >> ath9k: Fix use-after-free Read in ath9k_wmi_ctrl_rx >> ath9k: Fix use-after-free Write in ath9k_htc_rx_msg >> ath9x: Fix stack-out-of-bounds Write in ath9k_hif_usb_rx_cb >> ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb >> > > We got a report on IRC about 5.7.3+ breaking a USB ath9k Wifi Dongle, > while working fine on <5.7.3. > > I don't have myself such HW, and the reported doesn't have any experience > in bisecting the kernel, so we build kernels, each with one of the > above commits reverted, > to find the bad commit. > > The winner is: > > commit 6602f080cb28745259e2fab1a4cf55eeb5894f93 > Author: Qiujun Huang > Date: Sat Apr 4 12:18:38 2020 +0800 > > ath9k: Fix general protection fault in ath9k_hif_usb_rx_cb > > commit 2bbcaaee1fcbd83272e29f31e2bb7e70d8c49e05 upstream. > ... > > Reverting this one fixed his problem. Obvious question: is 5.8-rc1 (containing the commit) broken too? I fail to see how the commit could cause an issue like this. Is this really reproducibly broken with the commit and irreproducible without it? As it looks like a USB/wiring problem: usb 1-2: USB disconnect, device number 2 ath: phy0: Reading Magic # failed ath: phy0: Unable to initialize hardware; initialization status: -5 ... usb 1-2: device descriptor read/64, error -110 usb 1-2: device descriptor read/64, error -71 Ccing ath9k maintainers too. > I don't have so much info about the HW, besides a dmesg showing the > phy breaking. > I also added the reporter to CC too. > > https://gist.github.com/AngryPenguinPL/1e545f0da3c2339e443b9e5044fcccea > > If you need more info, please let me know and I'll try my best to get > it as fast as possible for you. thanks, -- js
