Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! > Thank you very much! I have a wild guess that, when we > have a train of skbs on the error queue starting from a local error, > we will see this issue. > > Ping (without my patch) considers EAGAIN on a normal read as an > indication that there is nothing on the error queue, but that's a >

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! > Thank you very much! I have a wild guess that, when we > have a train of skbs on the error queue starting from a local error, > we will see this issue. > > Ping (without my patch) considers EAGAIN on a normal read as an > indication that there is nothing on the error queue, but that's a >

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

On Thu, Jun 1, 2017 at 11:36 AM, Cyril Hrubis wrote: > It seems to repeatedly produce (until I plug the cable back): > > ee_errno = 113 ee_origin = 2 ee_type = 3 ee_code = 1 ee_info = 0 ee_data = 0 > > So we get EHOSTUNREACH on SO_EE_ORIGIN_ICMP. Thank you very much! I have a

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

On Thu, Jun 1, 2017 at 11:36 AM, Cyril Hrubis wrote: > It seems to repeatedly produce (until I plug the cable back): > > ee_errno = 113 ee_origin = 2 ee_type = 3 ee_code = 1 ee_info = 0 ee_data = 0 > > So we get EHOSTUNREACH on SO_EE_ORIGIN_ICMP. Thank you very much! I have a wild guess that,

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! > >> Thank you for the confirmation. Could you please try the following > >> patch to see if it fixes your issue? > > > > Does not seem to help, I still got the same bussy loop. > > Thank you for trying the patch. Unfortunately, I can't reproduce on my > machines here.Would you humor me with

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! > >> Thank you for the confirmation. Could you please try the following > >> patch to see if it fixes your issue? > > > > Does not seem to help, I still got the same bussy loop. > > Thank you for trying the patch. Unfortunately, I can't reproduce on my > machines here.Would you humor me with

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

On Thu, Jun 1, 2017 at 11:10 AM, Cyril Hrubis wrote: >> Thank you for the confirmation. Could you please try the following >> patch to see if it fixes your issue? > > Does not seem to help, I still got the same bussy loop. Thank you for trying the patch. Unfortunately, I can't

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

On Thu, Jun 1, 2017 at 11:10 AM, Cyril Hrubis wrote: >> Thank you for the confirmation. Could you please try the following >> patch to see if it fixes your issue? > > Does not seem to help, I still got the same bussy loop. Thank you for trying the patch. Unfortunately, I can't reproduce on my

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! > Thank you for the confirmation. Could you please try the following > patch to see if it fixes your issue? Does not seem to help, I still got the same bussy loop. -- Cyril Hrubis chru...@suse.cz

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! > Thank you for the confirmation. Could you please try the following > patch to see if it fixes your issue? Does not seem to help, I still got the same bussy loop. -- Cyril Hrubis chru...@suse.cz

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

On Thu, Jun 1, 2017 at 10:31 AM, Cyril Hrubis wrote: > I've started bisecting on v4.11 and see the problem on v4.10 on another > machine, the patch should be there in both cases and the bug is easily > reproducible. Thank you for the confirmation. Could you please try the

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

On Thu, Jun 1, 2017 at 10:31 AM, Cyril Hrubis wrote: > I've started bisecting on v4.11 and see the problem on v4.10 on another > machine, the patch should be there in both cases and the bug is easily > reproducible. Thank you for the confirmation. Could you please try the following patch to see

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! > > I've bisected the problem to this commit: > > > > commit f5f99309fa7481f59a500f0d08f3379cd6424c1f (HEAD, refs/bisect/bad) > > Author: Soheil Hassas Yeganeh > > Date: Thu Nov 3 18:24:27 2016 -0400 > > > > sock: do not set sk_err in sock_dequeue_err_skb > > Hi

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! > > I've bisected the problem to this commit: > > > > commit f5f99309fa7481f59a500f0d08f3379cd6424c1f (HEAD, refs/bisect/bad) > > Author: Soheil Hassas Yeganeh > > Date: Thu Nov 3 18:24:27 2016 -0400 > > > > sock: do not set sk_err in sock_dequeue_err_skb > > Hi Cyril, > > I'm sorry

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

On Thu, Jun 1, 2017 at 10:00 AM, Cyril Hrubis wrote: > I've bisected the problem to this commit: > > commit f5f99309fa7481f59a500f0d08f3379cd6424c1f (HEAD, refs/bisect/bad) > Author: Soheil Hassas Yeganeh > Date: Thu Nov 3 18:24:27 2016 -0400 > > sock:

Re: commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

On Thu, Jun 1, 2017 at 10:00 AM, Cyril Hrubis wrote: > I've bisected the problem to this commit: > > commit f5f99309fa7481f59a500f0d08f3379cd6424c1f (HEAD, refs/bisect/bad) > Author: Soheil Hassas Yeganeh > Date: Thu Nov 3 18:24:27 2016 -0400 > > sock: do not set sk_err in

commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! I've started to wonder why is ping eating 100% CPU shortly after I've upgraded my machine to 4.10 and here is what I found: The ping main_loop() sleeps in poll() on its socket, the poll() usually times out, at least that's what strace suggets which causes ping to sleep for ~1s in the kernel.

commit f5f99309 (sock: do not set sk_err in sock_dequeue_err_skb) has broken ping

Hi! I've started to wonder why is ping eating 100% CPU shortly after I've upgraded my machine to 4.10 and here is what I found: The ping main_loop() sleeps in poll() on its socket, the poll() usually times out, at least that's what strace suggets which causes ping to sleep for ~1s in the kernel.