Re: diffutils: C labels misdetected as functions

2007-07-22 Thread Junio C Hamano
Simon Arlott <[EMAIL PROTECTED]> writes: > On 22/07/07 19:38, Paul Eggert wrote: >> >> Anyway, to work around your problem without changing "diff", you can >> use "diff -u -F '^[[:alpha:]$_](|.*[^:])$'" instead of "diff -u -p". > > Perhaps git could do this (or similar) as a workaround? (Cc:ed)

Re: diffutils: C labels misdetected as functions

2007-07-22 Thread Simon Arlott
On 22/07/07 19:38, Paul Eggert wrote: > Simon Arlott <[EMAIL PROTECTED]> writes: > >> The patch below stops diffutils treating C labels starting in column 1 as >> function names. > > That patch alone wouldn't suffice, since -p is documented as implying > -F '^[[:alpha:]$_]'. If the behavior

Re: diffutils: C labels misdetected as functions

2007-07-22 Thread Paul Eggert
Simon Arlott <[EMAIL PROTECTED]> writes: > The patch below stops diffutils treating C labels starting in column 1 as > function names. That patch alone wouldn't suffice, since -p is documented as implying -F '^[[:alpha:]$_]'. If the behavior changes, we'd also have to change the documentation

Re: diffutils: C labels misdetected as functions

2007-07-22 Thread Paul Eggert
Simon Arlott [EMAIL PROTECTED] writes: The patch below stops diffutils treating C labels starting in column 1 as function names. That patch alone wouldn't suffice, since -p is documented as implying -F '^[[:alpha:]$_]'. If the behavior changes, we'd also have to change the documentation to

Re: diffutils: C labels misdetected as functions

2007-07-22 Thread Simon Arlott
On 22/07/07 19:38, Paul Eggert wrote: Simon Arlott [EMAIL PROTECTED] writes: The patch below stops diffutils treating C labels starting in column 1 as function names. That patch alone wouldn't suffice, since -p is documented as implying -F '^[[:alpha:]$_]'. If the behavior changes, we'd

Re: diffutils: C labels misdetected as functions

2007-07-22 Thread Junio C Hamano
Simon Arlott [EMAIL PROTECTED] writes: On 22/07/07 19:38, Paul Eggert wrote: Anyway, to work around your problem without changing diff, you can use diff -u -F '^[[:alpha:]$_](|.*[^:])$' instead of diff -u -p. Perhaps git could do this (or similar) as a workaround? (Cc:ed) Or you can put

diffutils: C labels misdetected as functions (Was: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle)

2007-07-21 Thread Simon Arlott
(Bcc: [EMAIL PROTECTED]) The patch below stops diffutils treating C labels starting in column 1 as function names. On 21/07/07 14:52, Matthew Wilcox wrote: > On Sat, Jul 21, 2007 at 07:11:01AM +0100, Simon Arlott wrote: >> Changing the code to fix a utility bug is madness. I think it's been >>

diffutils: C labels misdetected as functions (Was: [PATCH 1/2] run scripts/Lindent on it to match Documentation/CodingStyle)

2007-07-21 Thread Simon Arlott
(Bcc: [EMAIL PROTECTED]) The patch below stops diffutils treating C labels starting in column 1 as function names. On 21/07/07 14:52, Matthew Wilcox wrote: On Sat, Jul 21, 2007 at 07:11:01AM +0100, Simon Arlott wrote: Changing the code to fix a utility bug is madness. I think it's been fixed