Re: drivers/net/iseries_veth.c dubious sysfs usage

2007-12-23 Thread Greg KH
On Mon, Dec 24, 2007 at 01:52:08PM +1100, Stephen Rothwell wrote: > Hi Greg, > > On Wed, 12 Dec 2007 23:08:29 -0800 Greg KH <[EMAIL PROTECTED]> wrote: > > > > Hm, ok, it's odd as you are the only driver in the whole tree doing > > something like this, but it seems semi-resonable, so I can't compla

Re: drivers/net/iseries_veth.c dubious sysfs usage

2007-12-23 Thread Stephen Rothwell
Hi Greg, On Wed, 12 Dec 2007 23:08:29 -0800 Greg KH <[EMAIL PROTECTED]> wrote: > > Hm, ok, it's odd as you are the only driver in the whole tree doing > something like this, but it seems semi-resonable, so I can't complain :) > > I'll fix the core up to allow you to do this, thanks for the > expl

Re: drivers/net/iseries_veth.c dubious sysfs usage

2007-12-12 Thread Greg KH
On Thu, Dec 06, 2007 at 02:48:18PM +1100, Michael Ellerman wrote: > igoeast:~# cd /sys/class/net/eth1/ > igoeast:/sys/class/net/eth1# ls -la > total 0 > drwxr-xr-x 4 root root0 Dec 6 10:22 . > drwxr-xr-x 6 root root0 Dec 6 10:21 .. > -r--r--r-- 1 root root 4096 Dec 6 10:30 addr_len >

Re: drivers/net/iseries_veth.c dubious sysfs usage

2007-12-05 Thread Michael Ellerman
On Wed, 2007-12-05 at 13:41 -0800, Greg KH wrote: > On Wed, Dec 05, 2007 at 10:10:31PM +1100, Michael Ellerman wrote: > > On Wed, 2007-12-05 at 01:30 -0800, Greg KH wrote: > > > In doing a massive kobject cleanup of the kernel tree, I ran across the > > > iseries_veth.c driver. > > > > > > It look

Re: drivers/net/iseries_veth.c dubious sysfs usage

2007-12-05 Thread Greg KH
On Wed, Dec 05, 2007 at 10:10:31PM +1100, Michael Ellerman wrote: > On Wed, 2007-12-05 at 01:30 -0800, Greg KH wrote: > > In doing a massive kobject cleanup of the kernel tree, I ran across the > > iseries_veth.c driver. > > > > It looks like the driver is creating a number of subdirectories under

Re: drivers/net/iseries_veth.c dubious sysfs usage

2007-12-05 Thread Michael Ellerman
On Wed, 2007-12-05 at 01:30 -0800, Greg KH wrote: > In doing a massive kobject cleanup of the kernel tree, I ran across the > iseries_veth.c driver. > > It looks like the driver is creating a number of subdirectories under > the driver sysfs directory. This is odd and probably wrong. You want >

drivers/net/iseries_veth.c dubious sysfs usage

2007-12-05 Thread Greg KH
In doing a massive kobject cleanup of the kernel tree, I ran across the iseries_veth.c driver. It looks like the driver is creating a number of subdirectories under the driver sysfs directory. This is odd and probably wrong. You want these virtual connections to show up in the main sysfs device