Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-11-15 Thread Pavel Machek
Hi! > diff --git a/Documentation/ABI/testing/sysfs-platform-thinkpad-wmi > b/Documentation/ABI/testing/sysfs-platform-thinkpad-wmi > new file mode 100644 > index ..c3673876c5b3 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-platform-thinkpad-wmi > @@ -0,0 +1,50 @@ > +What:

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-11-15 Thread Pavel Machek
Hi! > diff --git a/Documentation/ABI/testing/sysfs-platform-thinkpad-wmi > b/Documentation/ABI/testing/sysfs-platform-thinkpad-wmi > new file mode 100644 > index ..c3673876c5b3 > --- /dev/null > +++ b/Documentation/ABI/testing/sysfs-platform-thinkpad-wmi > @@ -0,0 +1,50 @@ > +What:

Re: drivers/x86: add thinkpad-wmi

2017-11-10 Thread Corentin Chary
On Wed, Nov 8, 2017 at 10:31 PM, Darren Hart wrote: > On Tue, Nov 07, 2017 at 02:46:19PM +0200, Andy Shevchenko wrote: >> On Mon, Nov 6, 2017 at 8:16 PM, wrote: >> >> On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello >> >>

Re: drivers/x86: add thinkpad-wmi

2017-11-10 Thread Corentin Chary
On Wed, Nov 8, 2017 at 10:31 PM, Darren Hart wrote: > On Tue, Nov 07, 2017 at 02:46:19PM +0200, Andy Shevchenko wrote: >> On Mon, Nov 6, 2017 at 8:16 PM, wrote: >> >> On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello >> >> wrote: >> >> Mario, thanks for your comments on the subject. >> >> >>

Re: drivers/x86: add thinkpad-wmi

2017-11-08 Thread Darren Hart
On Tue, Nov 07, 2017 at 02:46:19PM +0200, Andy Shevchenko wrote: > On Mon, Nov 6, 2017 at 8:16 PM, wrote: > >> On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello > >> wrote: > > Mario, thanks for your comments on the subject. > > >> >

Re: drivers/x86: add thinkpad-wmi

2017-11-08 Thread Darren Hart
On Tue, Nov 07, 2017 at 02:46:19PM +0200, Andy Shevchenko wrote: > On Mon, Nov 6, 2017 at 8:16 PM, wrote: > >> On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello > >> wrote: > > Mario, thanks for your comments on the subject. > > >> > The hope is that eventually drivers on the WMI bus don't

Re: drivers/x86: add thinkpad-wmi

2017-11-07 Thread Andy Shevchenko
On Mon, Nov 6, 2017 at 8:16 PM, wrote: >> On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello >> wrote: Mario, thanks for your comments on the subject. >> > The hope is that eventually drivers on the WMI bus don't need to be very >> >

Re: drivers/x86: add thinkpad-wmi

2017-11-07 Thread Andy Shevchenko
On Mon, Nov 6, 2017 at 8:16 PM, wrote: >> On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello >> wrote: Mario, thanks for your comments on the subject. >> > The hope is that eventually drivers on the WMI bus don't need to be very >> > rich in code, but more intelligence comes from the bus.

RE: drivers/x86: add thinkpad-wmi

2017-11-06 Thread Mario.Limonciello
gt; Cc: Darren Hart <dvh...@infradead.org>; Andy Shevchenko > <a...@infradead.org>; platform-driver-...@vger.kernel.org; LKML ker...@vger.kernel.org> > Subject: Re: drivers/x86: add thinkpad-wmi > > On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello > <mario.limoncie...@dell.c

RE: drivers/x86: add thinkpad-wmi

2017-11-06 Thread Mario.Limonciello
gt; ; platform-driver-...@vger.kernel.org; LKML ker...@vger.kernel.org> > Subject: Re: drivers/x86: add thinkpad-wmi > > On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello > wrote: > > Hi Chary, > > > > I think it's interesting to see this submission coming in at this t

Re: drivers/x86: add thinkpad-wmi

2017-11-04 Thread Corentin Chary
On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello wrote: > Hi Chary, > > I think it's interesting to see this submission coming in at this time. > We're working on setting up precedent for how WMI vendor drivers should work > right now and I have another patch series

Re: drivers/x86: add thinkpad-wmi

2017-11-04 Thread Corentin Chary
On Tue, Oct 24, 2017 at 10:59 PM, Mario Limonciello wrote: > Hi Chary, > > I think it's interesting to see this submission coming in at this time. > We're working on setting up precedent for how WMI vendor drivers should work > right now and I have another patch series that sets up some concepts.

Re: drivers/x86: add thinkpad-wmi

2017-10-24 Thread Mario Limonciello
Hi Chary, I think it's interesting to see this submission coming in at this time. We're working on setting up precedent for how WMI vendor drivers should work right now and I have another patch series that sets up some concepts. They do clash a little with what you've done here, so let me

Re: drivers/x86: add thinkpad-wmi

2017-10-24 Thread Mario Limonciello
Hi Chary, I think it's interesting to see this submission coming in at this time. We're working on setting up precedent for how WMI vendor drivers should work right now and I have another patch series that sets up some concepts. They do clash a little with what you've done here, so let me

[PATCH] drivers/x86: add thinkpad-wmi

2017-10-21 Thread Corentin Chary
This driver has been available on https://github.com/iksaif/thinkpad-wmi for a few year and is already deployed on large fleets of thinkpad laptops. The WMI interface is documented here: http://download.lenovo.com/ibmdl/pub/pc/pccbbs/thinkcentre_pdf/hrdeploy_en.pdf It mostly focused on changing

[PATCH] drivers/x86: add thinkpad-wmi

2017-10-21 Thread Corentin Chary
This driver has been available on https://github.com/iksaif/thinkpad-wmi for a few year and is already deployed on large fleets of thinkpad laptops. The WMI interface is documented here: http://download.lenovo.com/ibmdl/pub/pc/pccbbs/thinkcentre_pdf/hrdeploy_en.pdf It mostly focused on changing

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-10-06 Thread Darren Hart
On Fri, Oct 06, 2017 at 09:06:14PM +0200, Corentin Chary wrote: > Yes, I'm just having trouble finding time to write it :) > I'll try to make that happen next week. OK, no problem. Marking the patch as "changes requested" and will keep an eye out. Thanks, -- Darren Hart VMware Open Source

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-10-06 Thread Darren Hart
On Fri, Oct 06, 2017 at 09:06:14PM +0200, Corentin Chary wrote: > Yes, I'm just having trouble finding time to write it :) > I'll try to make that happen next week. OK, no problem. Marking the patch as "changes requested" and will keep an eye out. Thanks, -- Darren Hart VMware Open Source

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-10-06 Thread Corentin Chary
Yes, I'm just having trouble finding time to write it :) I'll try to make that happen next week. On Thu, Oct 5, 2017 at 4:49 AM, Darren Hart wrote: > On Tue, Sep 05, 2017 at 09:07:27AM +0200, Corentin Chary wrote: >> [re-send for the mailing list, I forgot that gmail was

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-10-06 Thread Corentin Chary
Yes, I'm just having trouble finding time to write it :) I'll try to make that happen next week. On Thu, Oct 5, 2017 at 4:49 AM, Darren Hart wrote: > On Tue, Sep 05, 2017 at 09:07:27AM +0200, Corentin Chary wrote: >> [re-send for the mailing list, I forgot that gmail was stupid] >> >> On Tue,

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-10-04 Thread Darren Hart
On Tue, Sep 05, 2017 at 09:07:27AM +0200, Corentin Chary wrote: > [re-send for the mailing list, I forgot that gmail was stupid] > > On Tue, Sep 5, 2017 at 9:05 AM, Corentin Chary > wrote: > >> > >> I didn't read the code, does it use WMI bus which Andy L. introduced >

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-10-04 Thread Darren Hart
On Tue, Sep 05, 2017 at 09:07:27AM +0200, Corentin Chary wrote: > [re-send for the mailing list, I forgot that gmail was stupid] > > On Tue, Sep 5, 2017 at 9:05 AM, Corentin Chary > wrote: > >> > >> I didn't read the code, does it use WMI bus which Andy L. introduced > >> recently? > >> > > > >

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-09-07 Thread kbuild test robot
-x86-add-thinkpad-wmi/20170907-125653 base: git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-next coccinelle warnings: (new ones prefixed by >>) >> drivers/platform/x86/thinkpad-wmi.c:1196:3-8: No need to set .owner here. >> The core will do it. -- >&

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-09-07 Thread kbuild test robot
-x86-add-thinkpad-wmi/20170907-125653 base: git://git.infradead.org/users/dvhart/linux-platform-drivers-x86.git for-next coccinelle warnings: (new ones prefixed by >>) >> drivers/platform/x86/thinkpad-wmi.c:1196:3-8: No need to set .owner here. >> The core will do it. -- >&

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-09-05 Thread Corentin Chary
[re-send for the mailing list, I forgot that gmail was stupid] On Tue, Sep 5, 2017 at 9:05 AM, Corentin Chary wrote: > > > On Mon, Sep 4, 2017 at 7:15 PM, Andy Shevchenko > wrote: >> >> On Mon, Sep 4, 2017 at 11:21 AM, Corentin Chary >>

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-09-05 Thread Corentin Chary
[re-send for the mailing list, I forgot that gmail was stupid] On Tue, Sep 5, 2017 at 9:05 AM, Corentin Chary wrote: > > > On Mon, Sep 4, 2017 at 7:15 PM, Andy Shevchenko > wrote: >> >> On Mon, Sep 4, 2017 at 11:21 AM, Corentin Chary >> wrote: >> > This driver has been available on

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-09-04 Thread Andy Shevchenko
On Mon, Sep 4, 2017 at 11:21 AM, Corentin Chary wrote: > This driver has been available on https://github.com/iksaif/thinkpad-wmi for > a few year and is already deployed on large fleets of thinkpad laptops. > > The WMI interface is documented here: >

Re: [PATCH] drivers/x86: add thinkpad-wmi

2017-09-04 Thread Andy Shevchenko
On Mon, Sep 4, 2017 at 11:21 AM, Corentin Chary wrote: > This driver has been available on https://github.com/iksaif/thinkpad-wmi for > a few year and is already deployed on large fleets of thinkpad laptops. > > The WMI interface is documented here: >

[PATCH] drivers/x86: add thinkpad-wmi

2017-09-04 Thread Corentin Chary
This driver has been available on https://github.com/iksaif/thinkpad-wmi for a few year and is already deployed on large fleets of thinkpad laptops. The WMI interface is documented here: http://download.lenovo.com/ibmdl/pub/pc/pccbbs/thinkcentre_pdf/hrdeploy_en.pdf It mostly focused on changing

[PATCH] drivers/x86: add thinkpad-wmi

2017-09-04 Thread Corentin Chary
This driver has been available on https://github.com/iksaif/thinkpad-wmi for a few year and is already deployed on large fleets of thinkpad laptops. The WMI interface is documented here: http://download.lenovo.com/ibmdl/pub/pc/pccbbs/thinkcentre_pdf/hrdeploy_en.pdf It mostly focused on changing