Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Auke Kok
Andrew Morton wrote: On Thu, 15 Feb 2007 18:10:53 -0800 "Brandeburg, Jesse" <[EMAIL PROTECTED]> wrote: @@ -1431,6 +1427,10 @@ e1000_open(struct net_device *netdev) e1000_update_mng_vlan(adapter); } + err = e1000_request_irq(adapter); + if (err) +

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 18:10:53 -0800 "Brandeburg, Jesse" <[EMAIL PROTECTED]> wrote: > @@ -1431,6 +1427,10 @@ e1000_open(struct net_device *netdev) > e1000_update_mng_vlan(adapter); > } > > + err = e1000_request_irq(adapter); > + if (err) > + goto

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Auke Kok
[Adding Dimitri Mishin to the CC - he proposed the same patch earlier] Len Brown wrote: On Thursday 15 February 2007 21:10, Brandeburg, Jesse wrote: Eric W. Biederman wrote: Len Brown <[EMAIL PROTECTED]> writes: e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Len Brown
On Thursday 15 February 2007 21:10, Brandeburg, Jesse wrote: > Eric W. Biederman wrote: > > Len Brown <[EMAIL PROTECTED]> writes: > > > >> e1000 faults in 2.6.20-git, while 2.6.20 worked fine. > >> > >> System is a D875PBZ with LOM. > >> > >> clues? > > > > I'm guessing this is an old bug

RE: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Brandeburg, Jesse
Eric W. Biederman wrote: > Len Brown <[EMAIL PROTECTED]> writes: > >> e1000 faults in 2.6.20-git, while 2.6.20 worked fine. >> >> System is a D875PBZ with LOM. >> >> clues? > > I'm guessing this is an old bug found by the following bit of > debug coded added into since v2.6.20 > > +#ifdef

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Eric W. Biederman
Len Brown <[EMAIL PROTECTED]> writes: > e1000 faults in 2.6.20-git, while 2.6.20 worked fine. > > System is a D875PBZ with LOM. > > clues? I'm guessing this is an old bug found by the following bit of debug coded added into since v2.6.20 +#ifdef CONFIG_DEBUG_SHIRQ + if (irqflags &

e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Len Brown
e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ with LOM. clues? thanks, -Len Bringing up loopback interface: [ OK ] Bringing up interface eth0: BUG: unable to handle kernel NULL pointer dereference at virtual address printing eip: *pde = 3747c001

e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Len Brown
e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ with LOM. clues? thanks, -Len Bringing up loopback interface: [ OK ] Bringing up interface eth0: BUG: unable to handle kernel NULL pointer dereference at virtual address printing eip: *pde = 3747c001

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Eric W. Biederman
Len Brown [EMAIL PROTECTED] writes: e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ with LOM. clues? I'm guessing this is an old bug found by the following bit of debug coded added into since v2.6.20 +#ifdef CONFIG_DEBUG_SHIRQ + if (irqflags IRQF_SHARED) {

RE: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Brandeburg, Jesse
Eric W. Biederman wrote: Len Brown [EMAIL PROTECTED] writes: e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ with LOM. clues? I'm guessing this is an old bug found by the following bit of debug coded added into since v2.6.20 +#ifdef CONFIG_DEBUG_SHIRQ +

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Len Brown
On Thursday 15 February 2007 21:10, Brandeburg, Jesse wrote: Eric W. Biederman wrote: Len Brown [EMAIL PROTECTED] writes: e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ with LOM. clues? I'm guessing this is an old bug found by the following bit of

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Auke Kok
[Adding Dimitri Mishin to the CC - he proposed the same patch earlier] Len Brown wrote: On Thursday 15 February 2007 21:10, Brandeburg, Jesse wrote: Eric W. Biederman wrote: Len Brown [EMAIL PROTECTED] writes: e1000 faults in 2.6.20-git, while 2.6.20 worked fine. System is a D875PBZ with

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Andrew Morton
On Thu, 15 Feb 2007 18:10:53 -0800 Brandeburg, Jesse [EMAIL PROTECTED] wrote: @@ -1431,6 +1427,10 @@ e1000_open(struct net_device *netdev) e1000_update_mng_vlan(adapter); } + err = e1000_request_irq(adapter); + if (err) + goto

Re: e1000_intr in request_irq faults in 2.6.20-git

2007-02-15 Thread Auke Kok
Andrew Morton wrote: On Thu, 15 Feb 2007 18:10:53 -0800 Brandeburg, Jesse [EMAIL PROTECTED] wrote: @@ -1431,6 +1427,10 @@ e1000_open(struct net_device *netdev) e1000_update_mng_vlan(adapter); } + err = e1000_request_irq(adapter); + if (err) +