Re: false nr_running check in load balance?

2013-08-18 Thread Lei Wen
Paul, On Tue, Aug 13, 2013 at 5:25 PM, Paul Turner wrote: > On Tue, Aug 13, 2013 at 1:18 AM, Lei Wen wrote: >> Hi Paul, >> >> On Tue, Aug 13, 2013 at 4:08 PM, Paul Turner wrote: >>> On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra >>> wrote: On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei

Re: false nr_running check in load balance?

2013-08-18 Thread Lei Wen
Paul, On Tue, Aug 13, 2013 at 5:25 PM, Paul Turner p...@google.com wrote: On Tue, Aug 13, 2013 at 1:18 AM, Lei Wen adrian.w...@gmail.com wrote: Hi Paul, On Tue, Aug 13, 2013 at 4:08 PM, Paul Turner p...@google.com wrote: On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra pet...@infradead.org

Re: false nr_running check in load balance?

2013-08-15 Thread Peter Zijlstra
On Thu, Aug 15, 2013 at 11:23:53AM -0700, Paul Turner wrote: > On Thu, Aug 15, 2013 at 10:39 AM, Peter Zijlstra wrote: > > On Tue, Aug 13, 2013 at 01:08:17AM -0700, Paul Turner wrote: > >> On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra > >> wrote: > >> > On Tue, Aug 13, 2013 at 12:45:12PM

Re: false nr_running check in load balance?

2013-08-15 Thread Paul Turner
On Thu, Aug 15, 2013 at 10:39 AM, Peter Zijlstra wrote: > On Tue, Aug 13, 2013 at 01:08:17AM -0700, Paul Turner wrote: >> On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra >> wrote: >> > On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: >> >> > Not quite right; I think you need

Re: false nr_running check in load balance?

2013-08-15 Thread Peter Zijlstra
On Tue, Aug 13, 2013 at 01:08:17AM -0700, Paul Turner wrote: > On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra wrote: > > On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: > >> > Not quite right; I think you need busiest->cfs.h_nr_running. > >> > cfs.nr_running is the number of entries

Re: false nr_running check in load balance?

2013-08-15 Thread Peter Zijlstra
On Tue, Aug 13, 2013 at 01:08:17AM -0700, Paul Turner wrote: On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: Not quite right; I think you need busiest-cfs.h_nr_running. cfs.nr_running is the number of

Re: false nr_running check in load balance?

2013-08-15 Thread Paul Turner
On Thu, Aug 15, 2013 at 10:39 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 13, 2013 at 01:08:17AM -0700, Paul Turner wrote: On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: Not quite right;

Re: false nr_running check in load balance?

2013-08-15 Thread Peter Zijlstra
On Thu, Aug 15, 2013 at 11:23:53AM -0700, Paul Turner wrote: On Thu, Aug 15, 2013 at 10:39 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 13, 2013 at 01:08:17AM -0700, Paul Turner wrote: On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug

Re: false nr_running check in load balance?

2013-08-13 Thread Paul Turner
On Tue, Aug 13, 2013 at 1:18 AM, Lei Wen wrote: > Hi Paul, > > On Tue, Aug 13, 2013 at 4:08 PM, Paul Turner wrote: >> On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra >> wrote: >>> On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: > Not quite right; I think you need

Re: false nr_running check in load balance?

2013-08-13 Thread Lei Wen
Hi Paul, On Tue, Aug 13, 2013 at 4:08 PM, Paul Turner wrote: > On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra wrote: >> On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: >>> > Not quite right; I think you need busiest->cfs.h_nr_running. >>> > cfs.nr_running is the number of entries

Re: false nr_running check in load balance?

2013-08-13 Thread Paul Turner
On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra wrote: > On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: >> > Not quite right; I think you need busiest->cfs.h_nr_running. >> > cfs.nr_running is the number of entries running in this 'group'. If >> > you've got nested groups like: >> > >>

Re: false nr_running check in load balance?

2013-08-13 Thread Peter Zijlstra
On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: > > Not quite right; I think you need busiest->cfs.h_nr_running. > > cfs.nr_running is the number of entries running in this 'group'. If > > you've got nested groups like: > > > > 'root' > >\ > >'A' > >/ \ > > t1 t2 > > > >

Re: false nr_running check in load balance?

2013-08-13 Thread Peter Zijlstra
On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: Not quite right; I think you need busiest-cfs.h_nr_running. cfs.nr_running is the number of entries running in this 'group'. If you've got nested groups like: 'root' \ 'A' / \ t1 t2 root.nr_running := 1 'A',

Re: false nr_running check in load balance?

2013-08-13 Thread Paul Turner
On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: Not quite right; I think you need busiest-cfs.h_nr_running. cfs.nr_running is the number of entries running in this 'group'. If you've got nested groups

Re: false nr_running check in load balance?

2013-08-13 Thread Lei Wen
Hi Paul, On Tue, Aug 13, 2013 at 4:08 PM, Paul Turner p...@google.com wrote: On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: Not quite right; I think you need busiest-cfs.h_nr_running. cfs.nr_running is

Re: false nr_running check in load balance?

2013-08-13 Thread Paul Turner
On Tue, Aug 13, 2013 at 1:18 AM, Lei Wen adrian.w...@gmail.com wrote: Hi Paul, On Tue, Aug 13, 2013 at 4:08 PM, Paul Turner p...@google.com wrote: On Tue, Aug 13, 2013 at 12:38 AM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 13, 2013 at 12:45:12PM +0800, Lei Wen wrote: Not

Re: false nr_running check in load balance?

2013-08-12 Thread Lei Wen
Peter, On Mon, Aug 12, 2013 at 10:43 PM, Peter Zijlstra wrote: > On Tue, Aug 06, 2013 at 09:23:46PM +0800, Lei Wen wrote: >> Hi Paul, >> >> I notice in load_balance function, it would check busiest->nr_running >> to decide whether to perform the real task movement. >> >> But in some case, I saw

Re: false nr_running check in load balance?

2013-08-12 Thread Peter Zijlstra
On Tue, Aug 06, 2013 at 09:23:46PM +0800, Lei Wen wrote: > Hi Paul, > > I notice in load_balance function, it would check busiest->nr_running > to decide whether to perform the real task movement. > > But in some case, I saw the nr_running is not matching with > the task in the queue, which

Re: false nr_running check in load balance?

2013-08-12 Thread Peter Zijlstra
On Tue, Aug 06, 2013 at 09:23:46PM +0800, Lei Wen wrote: Hi Paul, I notice in load_balance function, it would check busiest-nr_running to decide whether to perform the real task movement. But in some case, I saw the nr_running is not matching with the task in the queue, which seems make

Re: false nr_running check in load balance?

2013-08-12 Thread Lei Wen
Peter, On Mon, Aug 12, 2013 at 10:43 PM, Peter Zijlstra pet...@infradead.org wrote: On Tue, Aug 06, 2013 at 09:23:46PM +0800, Lei Wen wrote: Hi Paul, I notice in load_balance function, it would check busiest-nr_running to decide whether to perform the real task movement. But in some case,

false nr_running check in load balance?

2013-08-06 Thread Lei Wen
Hi Paul, I notice in load_balance function, it would check busiest->nr_running to decide whether to perform the real task movement. But in some case, I saw the nr_running is not matching with the task in the queue, which seems make scheduler to do many redundant checking. What I means is like

false nr_running check in load balance?

2013-08-06 Thread Lei Wen
Hi Paul, I notice in load_balance function, it would check busiest-nr_running to decide whether to perform the real task movement. But in some case, I saw the nr_running is not matching with the task in the queue, which seems make scheduler to do many redundant checking. What I means is like