Re: in:imklog segfault in 4.12+git on most sparc64's
On Wed, Jul 12, 2017 at 9:09 AM, David Millerwrote: > > Al, please push this to Linus soon. I'll take it directly, Al is currently in Boston without a real computer methinks. Linus
Re: in:imklog segfault in 4.12+git on most sparc64's
On Wed, Jul 12, 2017 at 9:09 AM, David Miller wrote: > > Al, please push this to Linus soon. I'll take it directly, Al is currently in Boston without a real computer methinks. Linus
Re: in:imklog segfault in 4.12+git on most sparc64's
From: Meelis RoosDate: Wed, 12 Jul 2017 10:09:50 +0300 (EEST) >> From: Al Viro >> Date: Wed, 12 Jul 2017 04:59:45 +0100 >> >> > Again, my apologies for format of that all - I'm almost completely >> > off-net and while typing an ed script is feasible, context diff is >> > too far over the top. Usimg mutt in ssh session from android is >> > not fun, to put it mildly... >> >> Yes, that might be it. >> >> Meelis, please test this: >> >> >> fix a braino in compat_sys_getrlimit() >> >> Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native" >> Signed-off-by: Al Viro >> Acked-by: David S. Miller > > Yes, it works right on top of 4.12.0-rc1-7-gd9e968c and on top of > todays git as well. Al, please push this to Linus soon. Thanks.
Re: in:imklog segfault in 4.12+git on most sparc64's
From: Meelis Roos Date: Wed, 12 Jul 2017 10:09:50 +0300 (EEST) >> From: Al Viro >> Date: Wed, 12 Jul 2017 04:59:45 +0100 >> >> > Again, my apologies for format of that all - I'm almost completely >> > off-net and while typing an ed script is feasible, context diff is >> > too far over the top. Usimg mutt in ssh session from android is >> > not fun, to put it mildly... >> >> Yes, that might be it. >> >> Meelis, please test this: >> >> >> fix a braino in compat_sys_getrlimit() >> >> Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native" >> Signed-off-by: Al Viro >> Acked-by: David S. Miller > > Yes, it works right on top of 4.12.0-rc1-7-gd9e968c and on top of > todays git as well. Al, please push this to Linus soon. Thanks.
Re: in:imklog segfault in 4.12+git on most sparc64's
> From: Al Viro> Date: Wed, 12 Jul 2017 04:59:45 +0100 > > > Again, my apologies for format of that all - I'm almost completely > > off-net and while typing an ed script is feasible, context diff is > > too far over the top. Usimg mutt in ssh session from android is > > not fun, to put it mildly... > > Yes, that might be it. > > Meelis, please test this: > > > fix a braino in compat_sys_getrlimit() > > Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native" > Signed-off-by: Al Viro > Acked-by: David S. Miller Yes, it works right on top of 4.12.0-rc1-7-gd9e968c and on top of todays git as well. -- Meelis Roos (mr...@linux.ee)
Re: in:imklog segfault in 4.12+git on most sparc64's
> From: Al Viro > Date: Wed, 12 Jul 2017 04:59:45 +0100 > > > Again, my apologies for format of that all - I'm almost completely > > off-net and while typing an ed script is feasible, context diff is > > too far over the top. Usimg mutt in ssh session from android is > > not fun, to put it mildly... > > Yes, that might be it. > > Meelis, please test this: > > > fix a braino in compat_sys_getrlimit() > > Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native" > Signed-off-by: Al Viro > Acked-by: David S. Miller Yes, it works right on top of 4.12.0-rc1-7-gd9e968c and on top of todays git as well. -- Meelis Roos (mr...@linux.ee)
Re: in:imklog segfault in 4.12+git on most sparc64's
From: Al ViroDate: Wed, 12 Jul 2017 04:59:45 +0100 > Again, my apologies for format of that all - I'm almost completely > off-net and while typing an ed script is feasible, context diff is > too far over the top. Usimg mutt in ssh session from android is > not fun, to put it mildly... Yes, that might be it. Meelis, please test this: fix a braino in compat_sys_getrlimit() Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native" Signed-off-by: Al Viro Acked-by: David S. Miller diff --git a/kernel/sys.c b/kernel/sys.c index 73fc0af..2855ee7 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -1362,7 +1362,7 @@ COMPAT_SYSCALL_DEFINE2(getrlimit, unsigned int, resource, ret = do_prlimit(current, resource, NULL, ); if (!ret) { - struct rlimit r32; + struct compat_rlimit r32; if (r.rlim_cur > COMPAT_RLIM_INFINITY) r32.rlim_cur = COMPAT_RLIM_INFINITY; else
Re: in:imklog segfault in 4.12+git on most sparc64's
From: Al Viro Date: Wed, 12 Jul 2017 04:59:45 +0100 > Again, my apologies for format of that all - I'm almost completely > off-net and while typing an ed script is feasible, context diff is > too far over the top. Usimg mutt in ssh session from android is > not fun, to put it mildly... Yes, that might be it. Meelis, please test this: fix a braino in compat_sys_getrlimit() Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native" Signed-off-by: Al Viro Acked-by: David S. Miller diff --git a/kernel/sys.c b/kernel/sys.c index 73fc0af..2855ee7 100644 --- a/kernel/sys.c +++ b/kernel/sys.c @@ -1362,7 +1362,7 @@ COMPAT_SYSCALL_DEFINE2(getrlimit, unsigned int, resource, ret = do_prlimit(current, resource, NULL, ); if (!ret) { - struct rlimit r32; + struct compat_rlimit r32; if (r.rlim_cur > COMPAT_RLIM_INFINITY) r32.rlim_cur = COMPAT_RLIM_INFINITY; else
Re: in:imklog segfault in 4.12+git on most sparc64's
> In following commits around this one (some bisect steps before, and the > last step) the crashes were slightly different from the original crash > yersterday, like > > in:imuxsock[1606]: segfault at fff8 ip f774e154 (rpc > f774dfe8) sp 0001f7965a68 error 30002 in > libc-2.19.so[f76cc000+16a000] > > but this was the first commit introducing the crashes. > > d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit > commit d9e968cb9f849770288f5fde3d8d3a5f7e339052 > Author: Al Viro> Date: Wed May 31 04:33:51 2017 -0400 > w getrlimit()/setrlimit(): move compat to native > > Signed-off-by: Al Viro > > :04 04 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a > 6d820451a388c5771a2a410578365d14a0194e4e M kernel > > -- > Meelis Roos (mr...@linux.ee) With apologies for ed scripts, ed kernel/sys.c <<'EOF' /struct rlimit r32/s/rlimit/compat_&/ w q EOF AFAICS, that should fix it. If it does, commit message would be fix a braino in compat_sys_getrlimit() Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native" Signed-off-by: Al Viro --- Again, my apologies for format of that all - I'm almost completely off-net and while typing an ed script is feasible, context diff is too far over the top. Usimg mutt in ssh session from android is not fun, to put it mildly...
Re: in:imklog segfault in 4.12+git on most sparc64's
> In following commits around this one (some bisect steps before, and the > last step) the crashes were slightly different from the original crash > yersterday, like > > in:imuxsock[1606]: segfault at fff8 ip f774e154 (rpc > f774dfe8) sp 0001f7965a68 error 30002 in > libc-2.19.so[f76cc000+16a000] > > but this was the first commit introducing the crashes. > > d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit > commit d9e968cb9f849770288f5fde3d8d3a5f7e339052 > Author: Al Viro > Date: Wed May 31 04:33:51 2017 -0400 > w getrlimit()/setrlimit(): move compat to native > > Signed-off-by: Al Viro > > :04 04 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a > 6d820451a388c5771a2a410578365d14a0194e4e M kernel > > -- > Meelis Roos (mr...@linux.ee) With apologies for ed scripts, ed kernel/sys.c <<'EOF' /struct rlimit r32/s/rlimit/compat_&/ w q EOF AFAICS, that should fix it. If it does, commit message would be fix a braino in compat_sys_getrlimit() Fixes: commit d9e968cb9f84 "getrlimit()/setrlimit(): move compat to native" Signed-off-by: Al Viro --- Again, my apologies for format of that all - I'm almost completely off-net and while typing an ed script is feasible, context diff is too far over the top. Usimg mutt in ssh session from android is not fun, to put it mildly...
Re: in:imklog segfault in 4.12+git on most sparc64's
From: Meelis RoosDate: Tue, 11 Jul 2017 14:48:27 +0300 (EEST) >> I tested yesterdays git with 4.13 sparc merge on a big bunch of my test >> machines. >> >> Good news: the timestamps starting from boot seem to work on all the >> machines, starting with Ultra 1 and Ultra 2. >> >> Bad news: all working sun4u machines have the following line in dmesg >> (PID varies): >> in:imklog[1036]: segfault at 49 ip 00035bb0 (rpc f779dfa0) >> sp 0002f7a78818 error 30002 in rsyslogd[1+88000] >> >> This is with Debian unstable 32-bit userland as of 2015 summer. It did >> not happen with 4.12. > > I bisected it to the commit below. CC Al Viro. > > In following commits around this one (some bisect steps before, and the > last step) the crashes were slightly different from the original crash > yersterday, like > > in:imuxsock[1606]: segfault at fff8 ip f774e154 (rpc > f774dfe8) sp 0001f7965a68 error 30002 in > libc-2.19.so[f76cc000+16a000] > > but this was the first commit introducing the crashes. > > d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit > commit d9e968cb9f849770288f5fde3d8d3a5f7e339052 > Author: Al Viro > Date: Wed May 31 04:33:51 2017 -0400 > > getrlimit()/setrlimit(): move compat to native > > Signed-off-by: Al Viro > > :04 04 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a > 6d820451a388c5771a2a410578365d14a0194e4e M kernel I can't figure out what is wrong in this change, except that it does two things at once. It moves code, and changes it at the same time. That should have been done in two changes. Because of that, we can't tell which of the two things introduced the regression. Al?
Re: in:imklog segfault in 4.12+git on most sparc64's
From: Meelis Roos Date: Tue, 11 Jul 2017 14:48:27 +0300 (EEST) >> I tested yesterdays git with 4.13 sparc merge on a big bunch of my test >> machines. >> >> Good news: the timestamps starting from boot seem to work on all the >> machines, starting with Ultra 1 and Ultra 2. >> >> Bad news: all working sun4u machines have the following line in dmesg >> (PID varies): >> in:imklog[1036]: segfault at 49 ip 00035bb0 (rpc f779dfa0) >> sp 0002f7a78818 error 30002 in rsyslogd[1+88000] >> >> This is with Debian unstable 32-bit userland as of 2015 summer. It did >> not happen with 4.12. > > I bisected it to the commit below. CC Al Viro. > > In following commits around this one (some bisect steps before, and the > last step) the crashes were slightly different from the original crash > yersterday, like > > in:imuxsock[1606]: segfault at fff8 ip f774e154 (rpc > f774dfe8) sp 0001f7965a68 error 30002 in > libc-2.19.so[f76cc000+16a000] > > but this was the first commit introducing the crashes. > > d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit > commit d9e968cb9f849770288f5fde3d8d3a5f7e339052 > Author: Al Viro > Date: Wed May 31 04:33:51 2017 -0400 > > getrlimit()/setrlimit(): move compat to native > > Signed-off-by: Al Viro > > :04 04 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a > 6d820451a388c5771a2a410578365d14a0194e4e M kernel I can't figure out what is wrong in this change, except that it does two things at once. It moves code, and changes it at the same time. That should have been done in two changes. Because of that, we can't tell which of the two things introduced the regression. Al?
Re: in:imklog segfault in 4.12+git on most sparc64's
> I tested yesterdays git with 4.13 sparc merge on a big bunch of my test > machines. > > Good news: the timestamps starting from boot seem to work on all the > machines, starting with Ultra 1 and Ultra 2. > > Bad news: all working sun4u machines have the following line in dmesg > (PID varies): > in:imklog[1036]: segfault at 49 ip 00035bb0 (rpc f779dfa0) sp > 0002f7a78818 error 30002 in rsyslogd[1+88000] > > This is with Debian unstable 32-bit userland as of 2015 summer. It did > not happen with 4.12. I bisected it to the commit below. CC Al Viro. In following commits around this one (some bisect steps before, and the last step) the crashes were slightly different from the original crash yersterday, like in:imuxsock[1606]: segfault at fff8 ip f774e154 (rpc f774dfe8) sp 0001f7965a68 error 30002 in libc-2.19.so[f76cc000+16a000] but this was the first commit introducing the crashes. d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit commit d9e968cb9f849770288f5fde3d8d3a5f7e339052 Author: Al ViroDate: Wed May 31 04:33:51 2017 -0400 getrlimit()/setrlimit(): move compat to native Signed-off-by: Al Viro :04 04 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a 6d820451a388c5771a2a410578365d14a0194e4e M kernel -- Meelis Roos (mr...@linux.ee)
Re: in:imklog segfault in 4.12+git on most sparc64's
> I tested yesterdays git with 4.13 sparc merge on a big bunch of my test > machines. > > Good news: the timestamps starting from boot seem to work on all the > machines, starting with Ultra 1 and Ultra 2. > > Bad news: all working sun4u machines have the following line in dmesg > (PID varies): > in:imklog[1036]: segfault at 49 ip 00035bb0 (rpc f779dfa0) sp > 0002f7a78818 error 30002 in rsyslogd[1+88000] > > This is with Debian unstable 32-bit userland as of 2015 summer. It did > not happen with 4.12. I bisected it to the commit below. CC Al Viro. In following commits around this one (some bisect steps before, and the last step) the crashes were slightly different from the original crash yersterday, like in:imuxsock[1606]: segfault at fff8 ip f774e154 (rpc f774dfe8) sp 0001f7965a68 error 30002 in libc-2.19.so[f76cc000+16a000] but this was the first commit introducing the crashes. d9e968cb9f849770288f5fde3d8d3a5f7e339052 is the first bad commit commit d9e968cb9f849770288f5fde3d8d3a5f7e339052 Author: Al Viro Date: Wed May 31 04:33:51 2017 -0400 getrlimit()/setrlimit(): move compat to native Signed-off-by: Al Viro :04 04 5e1a0c25f4554ccdc824b18dc50078d379cdbf9a 6d820451a388c5771a2a410578365d14a0194e4e M kernel -- Meelis Roos (mr...@linux.ee)