Re: k10temp: ZEN3 readings are broken

2020-12-23 Thread Guenter Roeck
On 12/23/20 2:41 AM, Jan Engelhardt wrote: > > On Tuesday 2020-12-22 04:58, Guenter Roeck wrote: >> On 12/21/20 5:45 PM, Gabriel C wrote: >>> Hello Guenter, >>> >>> while trying to add ZEN3 support for zenpower out of tree modules, I find >>> out >>> the in-kernel k10temp driver is broken with

Re: k10temp: ZEN3 readings are broken

2020-12-23 Thread Gabriel C
Am Mi., 23. Dez. 2020 um 11:41 Uhr schrieb Jan Engelhardt : > > > On Tuesday 2020-12-22 04:58, Guenter Roeck wrote: > >On 12/21/20 5:45 PM, Gabriel C wrote: > >> Hello Guenter, > >> > >> while trying to add ZEN3 support for zenpower out of tree modules, I find > >> out > >> the in-kernel k10temp

Re: k10temp: ZEN3 readings are broken

2020-12-23 Thread Gabriel C
Am Mi., 23. Dez. 2020 um 11:41 Uhr schrieb Jan Engelhardt : > > > On Tuesday 2020-12-22 04:58, Guenter Roeck wrote: > >On 12/21/20 5:45 PM, Gabriel C wrote: > >> Hello Guenter, > >> > >> while trying to add ZEN3 support for zenpower out of tree modules, I find > >> out > >> the in-kernel k10temp

Re: k10temp: ZEN3 readings are broken

2020-12-23 Thread Jan Engelhardt
On Tuesday 2020-12-22 04:58, Guenter Roeck wrote: >On 12/21/20 5:45 PM, Gabriel C wrote: >> Hello Guenter, >> >> while trying to add ZEN3 support for zenpower out of tree modules, I find out >> the in-kernel k10temp driver is broken with ZEN3 ( and partially ZEN2 even ). > >[...] since I do not

Re: k10temp: ZEN3 readings are broken

2020-12-22 Thread Guenter Roeck
On 12/22/20 7:26 AM, Gabriel C wrote: > Am Di., 22. Dez. 2020 um 07:16 Uhr schrieb Guenter Roeck : >> >> On Tue, Dec 22, 2020 at 05:33:17AM +0100, Gabriel C wrote: >> [ ... ] >>> At least is what the weird amd_energy driver added and since is only >>> supporting >>> fam 17h model 0x31 which is TR

Re: k10temp: ZEN3 readings are broken

2020-12-22 Thread Gabriel C
Am Di., 22. Dez. 2020 um 07:16 Uhr schrieb Guenter Roeck : > > On Tue, Dec 22, 2020 at 05:33:17AM +0100, Gabriel C wrote: > [ ... ] > > At least is what the weird amd_energy driver added and since is only > > supporting > > fam 17h model 0x31 which is TR 3000 & SP3 Rome, I guess fam 19h 0x1 is >

Re: k10temp: ZEN3 readings are broken

2020-12-21 Thread Guenter Roeck
On Tue, Dec 22, 2020 at 05:33:17AM +0100, Gabriel C wrote: [ ... ] > At least is what the weird amd_energy driver added and since is only > supporting > fam 17h model 0x31 which is TR 3000 & SP3 Rome, I guess fam 19h 0x1 is > TR/SP3 ZEN3. The limited model support is because people nowadays are

Re: k10temp: ZEN3 readings are broken

2020-12-21 Thread Wei Huang
On 12/21/20 11:09 PM, Gabriel C wrote: Am Di., 22. Dez. 2020 um 05:33 Uhr schrieb Wei Huang : On 12/21/20 9:58 PM, Guenter Roeck wrote: Hi, On 12/21/20 5:45 PM, Gabriel C wrote: Hello Guenter, while trying to add ZEN3 support for zenpower out of tree modules, I find out the in-kernel

Re: k10temp: ZEN3 readings are broken

2020-12-21 Thread Guenter Roeck
On Tue, Dec 22, 2020 at 05:33:17AM +0100, Gabriel C wrote: > > ( BTW off-topic this amd_energ driver should be removed or depend on BROKEN, > since is working as root only and breaks the sensors command output ) > That is because of a security issue. It just needs to be reworked to cache

Re: k10temp: ZEN3 readings are broken

2020-12-21 Thread Gabriel C
Am Di., 22. Dez. 2020 um 05:33 Uhr schrieb Wei Huang : > > > > On 12/21/20 9:58 PM, Guenter Roeck wrote: > > Hi, > > > > On 12/21/20 5:45 PM, Gabriel C wrote: > >> Hello Guenter, > >> > >> while trying to add ZEN3 support for zenpower out of tree modules, I find > >> out > >> the in-kernel

Re: k10temp: ZEN3 readings are broken

2020-12-21 Thread Gabriel C
Am Di., 22. Dez. 2020 um 04:58 Uhr schrieb Guenter Roeck : > > Hi, > > On 12/21/20 5:45 PM, Gabriel C wrote: > > Hello Guenter, > > > > while trying to add ZEN3 support for zenpower out of tree modules, I find > > out > > the in-kernel k10temp driver is broken with ZEN3 ( and partially ZEN2 even

Re: k10temp: ZEN3 readings are broken

2020-12-21 Thread Wei Huang
On 12/21/20 9:58 PM, Guenter Roeck wrote: Hi, On 12/21/20 5:45 PM, Gabriel C wrote: Hello Guenter, while trying to add ZEN3 support for zenpower out of tree modules, I find out the in-kernel k10temp driver is broken with ZEN3 ( and partially ZEN2 even ). commit

Re: k10temp: ZEN3 readings are broken

2020-12-21 Thread Guenter Roeck
Hi, On 12/21/20 5:45 PM, Gabriel C wrote: > Hello Guenter, > > while trying to add ZEN3 support for zenpower out of tree modules, I find out > the in-kernel k10temp driver is broken with ZEN3 ( and partially ZEN2 even ). > > commit 55163a1c00fcb526e2aa9f7f952fb38d3543da5e added: > > case 0x0

k10temp: ZEN3 readings are broken

2020-12-21 Thread Gabriel C
Hello Guenter, while trying to add ZEN3 support for zenpower out of tree modules, I find out the in-kernel k10temp driver is broken with ZEN3 ( and partially ZEN2 even ). commit 55163a1c00fcb526e2aa9f7f952fb38d3543da5e added: case 0x0 ... 0x1: /* Zen3 */ however, this is wrong, we look