Re: libata: Fix host->simplex_claimed != ap typo
Alan Cox <[EMAIL PROTECTED]> writes: > On Thu, 08 Mar 2007 10:18:24 -0500 > Jeff Garzik <[EMAIL PROTECTED]> wrote: > >> Alan Cox wrote: >> > On Thu, 08 Mar 2007 23:17:00 +0900 >> > OGAWA Hirofumi <[EMAIL PROTECTED]> wrote: >> > >> >> Hi, >> >> >> >> the following patch is needed to boot my laptop using pata_ali.ko, at >> >> least. >> >> Please apply. >> > >> > NAK - correct fix is to check != && != NULL. The correct fix was posted >> > to the list earlier by Vojtech. >> >> You mean Petr Vandrovec I presume? > > Sorry got the wrong person - I do indeed I found the Petr's patch in linux-ide and confirmed it. Thanks. -- OGAWA Hirofumi <[EMAIL PROTECTED]> - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: libata: Fix host->simplex_claimed != ap typo
On Thu, 08 Mar 2007 10:18:24 -0500 Jeff Garzik <[EMAIL PROTECTED]> wrote: > Alan Cox wrote: > > On Thu, 08 Mar 2007 23:17:00 +0900 > > OGAWA Hirofumi <[EMAIL PROTECTED]> wrote: > > > >> Hi, > >> > >> the following patch is needed to boot my laptop using pata_ali.ko, at > >> least. > >> Please apply. > > > > NAK - correct fix is to check != && != NULL. The correct fix was posted > > to the list earlier by Vojtech. > > You mean Petr Vandrovec I presume? Sorry got the wrong person - I do indeed - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: libata: Fix host->simplex_claimed != ap typo
Alan Cox wrote: On Thu, 08 Mar 2007 23:17:00 +0900 OGAWA Hirofumi <[EMAIL PROTECTED]> wrote: Hi, the following patch is needed to boot my laptop using pata_ali.ko, at least. Please apply. NAK - correct fix is to check != && != NULL. The correct fix was posted to the list earlier by Vojtech. You mean Petr Vandrovec I presume? Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: libata: Fix host->simplex_claimed != ap typo
On Thu, 08 Mar 2007 23:17:00 +0900 OGAWA Hirofumi <[EMAIL PROTECTED]> wrote: > Hi, > > the following patch is needed to boot my laptop using pata_ali.ko, at least. > Please apply. NAK - correct fix is to check != && != NULL. The correct fix was posted to the list earlier by Vojtech. Alan - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
Re: libata: Fix host->simplex_claimed != ap typo
OGAWA Hirofumi wrote: Hi, the following patch is needed to boot my laptop using pata_ali.ko, at least. Please apply. Someone else caught this as well. This will go upstream today. Jeff - To unsubscribe from this list: send the line "unsubscribe linux-kernel" in the body of a message to [EMAIL PROTECTED] More majordomo info at http://vger.kernel.org/majordomo-info.html Please read the FAQ at http://www.tux.org/lkml/
libata: Fix host->simplex_claimed != ap typo
Hi,
the following patch is needed to boot my laptop using pata_ali.ko, at least.
Please apply.
--
OGAWA Hirofumi <[EMAIL PROTECTED]>
Fix typo. "host->simplex_claimed != ap" should be "==", not "!=".
Signed-off-by: OGAWA Hirofumi <[EMAIL PROTECTED]>
---
drivers/ata/libata-core.c |2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff -puN drivers/ata/libata-core.c~ata-fix-simplex-handling-fix
drivers/ata/libata-core.c
--- linux-2.6/drivers/ata/libata-core.c~ata-fix-simplex-handling-fix
2007-03-08 07:31:49.0 +0900
+++ linux-2.6-hirofumi/drivers/ata/libata-core.c2007-03-08
07:31:59.0 +0900
@@ -3455,7 +3455,7 @@ static void ata_dev_xfermask(struct ata_
"device is on DMA blacklist, disabling DMA\n");
}
- if ((host->flags & ATA_HOST_SIMPLEX) && host->simplex_claimed != ap) {
+ if ((host->flags & ATA_HOST_SIMPLEX) && host->simplex_claimed == ap) {
xfer_mask &= ~(ATA_MASK_MWDMA | ATA_MASK_UDMA);
ata_dev_printk(dev, KERN_WARNING, "simplex DMA is claimed by "
"other device, disabling DMA\n");
_
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [EMAIL PROTECTED]
More majordomo info at http://vger.kernel.org/majordomo-info.html
Please read the FAQ at http://www.tux.org/lkml/
