Re: linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

Hi all,

On Mon, 7 Dec 2020 08:57:43 +1100 Stephen Rothwell  
wrote:
>
> We actually prefer
> 
>   git log -1 --format='Fixes: %h (\"%s\")'

git log -1 --format='Fixes: %h ("%s")'

sorry :-)

-- 
Cheers,
Stephen Rothwell


pgpUUYWFAoa1V.pgp
Description: OpenPGP digital signature

Re: linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

Hi Iskren,

On Sun, 6 Dec 2020 23:05:30 +0200 Iskren Chernev  
wrote:
>
> I'm sorry, I copied and truncated the hash by hand. I should have used
> 
>      git log --pretty=reference

We actually prefer

git log -1 --format='Fixes: %h (\"%s\")'

for fixes tags.

> Also scripts/checkpatch.pl didn't notice it. Should I submit v3 of the
> patch or it's too late.

I don't think it matters for now, just in the future, please.

-- 
Cheers,
Stephen Rothwell


pgpMQAaR63oRY.pgp
Description: OpenPGP digital signature

Re: linux-next: Fixes tag needs some work in the drm-msm tree

[Iskren Chernev]

On 12/6/20 10:05 PM, Stephen Rothwell wrote:
> Hi all,
>
> In commit
>
>   9b73bde39cf2 ("drm/msm: Fix use-after-free in msm_gem with carveout")
>
> Fixes tag
>
>   Fixes: 4b85f7f5cf7 ("drm/msm: support for an arbitrary number of 
address spaces")

>
> has these problem(s):
>
>   - SHA1 should be at least 12 digits long
>
> In the furture, this can be avoided by setting core.abbrev to 12 (or 
more)

> or (for git v2.11 or later) just making sure it is not set (or set to
> "auto").

I'm sorry, I copied and truncated the hash by hand. I should have used

    git log --pretty=reference

Also scripts/checkpatch.pl didn't notice it. Should I submit v3 of the
patch or it's too late.

Regards,
Iskren

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

Hi all,

In commit

  9b73bde39cf2 ("drm/msm: Fix use-after-free in msm_gem with carveout")

Fixes tag

  Fixes: 4b85f7f5cf7 ("drm/msm: support for an arbitrary number of address 
spaces")

has these problem(s):

  - SHA1 should be at least 12 digits long

In the furture, this can be avoided by setting core.abbrev to 12 (or more)
or (for git v2.11 or later) just making sure it is not set (or set to
"auto").

-- 
Cheers,
Stephen Rothwell


pgp62hYDd80gb.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

Hi all,

In commit

  a0b21e0ad294 ("drm/msm: Add missing stub definition")

Fixes tag

  Fixes: 8ede2ecc3e5e ("drm/msm/dp: Add DP compliance tests on

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

-- 
Cheers,
Stephen Rothwell


pgp4V7m9XjnJ2.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

Hi all,

In commit

  4a8b6b60a159 ("drm/msm/adreno: fix gpu probe if no interconnect-names")

Fixes tag

  Fixes: 8e29fb37b301 ("drm/msm: handle for EPROBE_DEFER for of_icc_get")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 08af4769c7d2 ("drm/msm: handle for EPROBE_DEFER for of_icc_get")

-- 
Cheers,
Stephen Rothwell


pgpMikJ_H9WnO.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

Hi all,

In commit

  9e3d8cc1cfbc ("drm/msm/adreno: fix gpu probe if no interconnect-names")

Fixes tag

  Fixes: 8e29fb37b301 ("drm/msm: handle for EPROBE_DEFER for of_icc_get")

has these problem(s):

  - Target SHA1 does not exist

Maybe you meant

Fixes: 937c55f6b726 ("drm/msm: handle for EPROBE_DEFER for of_icc_get")

-- 
Cheers,
Stephen Rothwell


pgp6bIiDJwFYO.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

Hi all,

In commit

  736fe23d544f ("drm/msm/dpu: request for display color blocks based on hw 
catalog entry")

Fixes tag

  Fixes: e47616df008b ("drm/msm/dpu: add support for color processing

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not truncate or split Fixes tag lines.

-- 
Cheers,
Stephen Rothwell


pgpQQsasKCgwC.pgp
Description: OpenPGP digital signature

linux-next: Fixes tag needs some work in the drm-msm tree

[Stephen Rothwell]

Hi all,

In commit

  5fddd4f5db87 ("drm/msm/dpu: request for display color blocks based on hw 
catalog entry")

Fixes tag

  Fixes: e47616df008b ("drm/msm/dpu: add support for color processing

has these problem(s):

  - Subject has leading but no trailing parentheses
  - Subject has leading but no trailing quotes

Please do not truncate Fixes tags or split them over more than one line.

Fixes: e47616df008b ("drm/msm/dpu: add support for color processing blocks in 
dpu driver")

-- 
Cheers,
Stephen Rothwell


pgpN1EHIhZeN0.pgp
Description: OpenPGP digital signature